From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#27817: 26.0.50; Dired: Support eshell/ls from the beginning if user want to Date: Tue, 25 Jul 2017 23:38:56 +0900 (JST) Message-ID: References: <87shhlypn6.fsf@calancha-pc> <8360eg7fhv.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: blaine.gmane.org 1500993726 18414 195.159.176.226 (25 Jul 2017 14:42:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 25 Jul 2017 14:42:06 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: 27817@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 25 16:41:56 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1da11y-0003xQ-BK for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jul 2017 16:41:50 +0200 Original-Received: from localhost ([::1]:32932 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1da123-0001iw-TG for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jul 2017 10:41:55 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35793) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1da10J-0000Wu-7q for bug-gnu-emacs@gnu.org; Tue, 25 Jul 2017 10:40:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1da10E-0008Oe-Ab for bug-gnu-emacs@gnu.org; Tue, 25 Jul 2017 10:40:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53347) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1da10E-0008OW-5c for bug-gnu-emacs@gnu.org; Tue, 25 Jul 2017 10:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1da10D-0006Hb-NX for bug-gnu-emacs@gnu.org; Tue, 25 Jul 2017 10:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jul 2017 14:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27817 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27817-submit@debbugs.gnu.org id=B27817.150099354724089 (code B ref 27817); Tue, 25 Jul 2017 14:40:01 +0000 Original-Received: (at 27817) by debbugs.gnu.org; 25 Jul 2017 14:39:07 +0000 Original-Received: from localhost ([127.0.0.1]:56024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1da0zK-0006GS-Tf for submit@debbugs.gnu.org; Tue, 25 Jul 2017 10:39:07 -0400 Original-Received: from mail-pf0-f176.google.com ([209.85.192.176]:34862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1da0zJ-0006G0-GS for 27817@debbugs.gnu.org; Tue, 25 Jul 2017 10:39:05 -0400 Original-Received: by mail-pf0-f176.google.com with SMTP id h29so24225444pfd.2 for <27817@debbugs.gnu.org>; Tue, 25 Jul 2017 07:39:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=HRO5B+Ed3I2Bv4KCTgiGCpjivk7W5m0tpIR7Z5+BfbY=; b=EeP+6PyFWjWAVRvaXuy8Dh3jkPe8MLdzBsZPS2hT7a6z0T/O7poIr7bgpHi16X1P8o 22WSzuUhfHjrhP1Lobw7T+jByXoBSLPZ3h+WuqJXEJyiCPBJw+Hlyx8x4lwV0iXkR+dT d/6NbkULGctCGHEvKu5NRdr/KrxjS4qIvrULVNEbSbMRoedFodJOoq9BA/ondjXy+Apc 6BPkM3ORIWN0jrhnjDk2BuCk+ZJYZnzik39y1g2zB+QD/To+7SA+kBARhUSYzK/8A4PM urcTdjm8u/v4mjNPNNT7iJfOGblnFtXnGppn63qv9sxeO3mxGA/qkBO7gM1UKXG0pbZt 1imA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=HRO5B+Ed3I2Bv4KCTgiGCpjivk7W5m0tpIR7Z5+BfbY=; b=rnAdIySiO9JEncyWr7AtQxhL+UnwAemTXFlOudIXEtyYAv1lrpkdwyAbAZmeyqNf+s ZfZG3zBl3sD0WqCBMGxjLeI94x7IpqUwsfcoWEHuQ6ua4ysffWZMMNVq6ll2Aj61U25M cSxoH1/5ZuBSc3GKMW6VmyMyd+5TlHJ9d+a4kHakkLjM1AnISu1/n476ROMP9Rs8Xs/n qJP72bipokix2sPuUo3hKA5+bQ4uaTO7PSmrQRss+Dct8ffKNo9pV0q0XLHlkx//Szl9 tszJAhtHOaPRsqiACQBCw6T6T+jMO3qooMOq4Sa2uGI3IoZfkQtTLs570SHVU/NXHOXZ KZvQ== X-Gm-Message-State: AIVw110IXrEg1ZfmGV7KK2TjRRO5Jn2NVKsr7t24Y+A7biQVqdOay3NT +QguQo6L8qFj+usa X-Received: by 10.98.65.86 with SMTP id o83mr3990983pfa.117.1500993539379; Tue, 25 Jul 2017 07:38:59 -0700 (PDT) Original-Received: from calancha-pc (170.224.128.101.dy.bbexcite.jp. [101.128.224.170]) by smtp.gmail.com with ESMTPSA id h3sm27159285pfj.72.2017.07.25.07.38.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Jul 2017 07:38:58 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: <8360eg7fhv.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134969 Archived-At: On Tue, 25 Jul 2017, Eli Zaretskii wrote: >> From: Tino Calancha >> Date: Tue, 25 Jul 2017 15:52:29 +0900 >> >> commit 6322f2932e9a083e01bb86aa219fc8256443c33f >> Author: Tino Calancha >> Date: Tue Jul 25 15:46:54 2017 +0900 >> >> Dired: Support eshell/ls from the beginning if user want to >> >> * lisp/dired.el (dired-insert-directory): Check for em-ls as well. >> * test/lisp/dired-tests.el (dired-test-bug27817): Add test. > > Looks okay, but (a) please cite the bug number in the commit log > message, and (b) shouldn't this: Thank you. i will do. > >> + (not (and (featurep 'eshell) (bound-and-true-p eshell-ls-use-in-dired))) > quote eshell-ls-use-in-dired? I don't think so. But i drank 2 beer so i migh be wrong...