bug#27559: 26.0.50; [PATCH] Add tests for cl-macs.el

[Tino Calancha <tino.calancha@gmail.com>]

On Tue, 4 Jul 2017, Alex wrote:

> Tino Calancha <tino.calancha@gmail.com> writes:
>
>> Alex <agrambot@gmail.com> writes:
>>
>>> That's more or less what I did at first, but I figured since cl-loop is
>>> a large macro, that it's best to quote the macro so that an accidental
>>> error doesn't halt testing.
>> I prefer just use (eval '...) in those cases where the expansion fails.
>> That way the file is more readable, and a reader focus her eye in those
>> failing expansions.
>
> I agree that it's more readable, and if I was doing this for my own
> project I'd just leave the (eval '...) out where possible.
>
>> Maybe we could add a comment in the file saying that those
>> `should-error' are failing expansions to be fixed.
>
> Part of the problem is that the "failing expansions that should be fixed" aren't
> wrapped in a should-error, but are wrapped in a should. The test itself
> is marked as ":expected-result :failed".
Feel free to adapt the patch to your taste: in the way you find it more
convenient.

> I also have a patch that appears to do this, but it breaks a few tests
> due to Bug#24402[1]. Perhaps a fix to that bug will also make it so that
> macro-expansion errors will be caught be should*.
>
> I hope that Bug#24402 can be fixed before committing these tests, so we
> can just remove the (eval '...) noise altogether.
I agree with you.  Thanks for point me out to such bug report (i wasn't 
aware of it).
I will teletransport to that bug report.  See you there!