From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: Re: Bound index checks in cl-seq functions Date: Tue, 25 Apr 2017 20:14:08 +0900 (JST) Message-ID: References: <87efzdrjsj.fsf@calancha-pc> <87inoisd6y.fsf@calancha-pc> <87r32f7yq6.fsf_-_@calancha-pc> <83zih2lb65.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: blaine.gmane.org 1493118868 731 195.159.176.226 (25 Apr 2017 11:14:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 25 Apr 2017 11:14:28 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: Eli Zaretskii , emacs-devel@gnu.org, Tino Calancha To: John Wiegley Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 25 13:14:24 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2yQK-00005L-5s for ged-emacs-devel@m.gmane.org; Tue, 25 Apr 2017 13:14:24 +0200 Original-Received: from localhost ([::1]:48487 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2yQP-0008K6-Lx for ged-emacs-devel@m.gmane.org; Tue, 25 Apr 2017 07:14:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60880) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2yQE-0008J0-9N for emacs-devel@gnu.org; Tue, 25 Apr 2017 07:14:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d2yQD-0000KL-Fr for emacs-devel@gnu.org; Tue, 25 Apr 2017 07:14:18 -0400 Original-Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]:32977) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d2yQ9-0000JT-GN; Tue, 25 Apr 2017 07:14:13 -0400 Original-Received: by mail-pf0-x243.google.com with SMTP id c198so9661498pfc.0; Tue, 25 Apr 2017 04:14:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=5jWR+OYWxQop9BPgzWsd1Q5ZYNaHuiPbk4tkk73sB+k=; b=JqmluQjAZ82vEG0c5YToojNCHawB9GpgHuvt0FLwIM7Ouei1sPe1YE/5q0b4uWj3PF j1w5FaMZovW+rAEaCkjPqI+fUbe78KGb2LvWJY/wbkUqk0u81+GRE/OdYL4P6cEV9p3L EWU82mAE/ZBZRX6n0KMJ3nbu1nD6wDQTW3ooGqQrye245lok+OVNVeqmG+5dyr7JidQH FEYIrBIFeNfYS2jQuR8IvGE4/iO+x+A1VomCPRX8NUlJmt3U9GVH74+7X9hdS7NlBsOq 407Plr602UXMhaIU2bmXngyrwY63/Fg27f+S+P7snuRrpk3bmrcvX7X1E4gvjXAEvEtd ovxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=5jWR+OYWxQop9BPgzWsd1Q5ZYNaHuiPbk4tkk73sB+k=; b=GcNqZV2UHzXPwvkGqCmVN5o7jpBsDcEW/OwwYbNDbtIYiobL0c2p3keZvlGoA/4TO1 h0HcOpKnhfnDHshohqzLRVlLjTcpS9RhSZ4bY1GgaA8Kqt5F2eWpjYY24IONbC2tZ/ea pmOKSG6jBcEmE1Mz9NQlijipYn/cY2Efibbq28PZPKm8sXEdUTRK87A3lGL7yCyLZbCj C3CS5bwM8+eCX90oakFqvfjYGA7miBOhJqHbo3UZO9QapKNvJ2MRrOnCtXmuAjjFJRnN f+xbfIsB9Uq1+CkqH5lxr+9X+RDlQzzQw2cBHc0U+wUJsFEaRO27aK6y/6eSfqo1fTFb 4ixQ== X-Gm-Message-State: AN3rC/4xHhPEWqWKa/HyB3QWDXSgVxVcsd6qfeoYB93lW7lL1OXryFKw 58IMa3Q2Vuq2dHtp X-Received: by 10.98.7.140 with SMTP id 12mr28578856pfh.202.1493118852430; Tue, 25 Apr 2017 04:14:12 -0700 (PDT) Original-Received: from calancha-pc (222.139.137.133.dy.bbexcite.jp. [133.137.139.222]) by smtp.gmail.com with ESMTPSA id u45sm36221650pgn.7.2017.04.25.04.14.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Apr 2017 04:14:11 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214280 Archived-At: On Fri, 14 Apr 2017, John Wiegley wrote: >>>>>> Eli Zaretskii writes: > >>> i am curious if you have any opinion on this thread. Currently just >>> `cl-subseq' performs the bounding check index. I don't see a >>> clear reason why just this function do it. >>> Are you in favour or against doing those checks in other functions >>> handling sequences? > >> I don't have any firm opinions on this. I do note, however, that your >> motivation for signaling an error was contested. So I wonder whether the >> cause for this is strong enough to make that change. But I'm willing to >> defer to people who use these features more than I do. > > I also don't have a strong opinion. Bounds checking is usually helpful, if it > would help those who are using these functions. Otherwise, I wouldn't make the > change "just to make the change", even though it sounds like a good idea. Thank you. I am fine with not adding this patch.