Re: [elpa] master 39d163a: load-dir: fix CL and free variable warnings

[Tino Calancha <tino.calancha@gmail.com>]

On Mon, 20 Mar 2017, Ted Zlatanov wrote:

> On Mon, 20 Mar 2017 09:51:07 -0400 Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>
> SM> Either use `some` instead of `cl-some`, or use `cl-lib` (and add
> SM> a corresponding `Package-Requires: ((cl-lib "0.5"))` in the file's
> SM> header).
>
> BTW, I noticed ELPAs' lmc/lmc.el has "Package-Requires" without the ":"
> afterwards.
>
> SM>         Stefan "who favors the `cl-lib` solution"
>
> Like this? I'll commit if you agree.
>
> Thanks for the help
> Ted
>
> diff --git a/packages/load-dir/load-dir.el b/packages/load-dir/load-dir.el
> index ab88ea7..b2231a5 100644
> --- a/packages/load-dir/load-dir.el
> +++ b/packages/load-dir/load-dir.el
> @@ -9,6 +9,7 @@
> ;; Maintainer: Teodor Zlatanov <tzz@lifelogs.com>
> ;; Version: 0.0.5
> ;; Keywords: lisp, files, convenience
> +;; Package-Requires: ((cl-lib "0.5"))
>
> ;; This file is part of GNU Emacs.
>
> @@ -43,7 +44,7 @@
>
> ;;; Code:
>
> -(eval-when-compile (require 'cl-extra))
> +(eval-when-compile (require 'cl-lib))
    ^^^^^^^^^^^^^^^^^^
Just plain `require' because `cl-some' is a defun not a macro:
(require 'cl-lib)