From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#25105: 26.0.50; diff navigation is broken Date: Fri, 6 Jan 2017 13:22:49 +0900 (JST) Message-ID: References: <87inpt6lce.fsf@gmail.com> <87tw9dc7bk.fsf@secretsauce.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: blaine.gmane.org 1483676601 28712 195.159.176.226 (6 Jan 2017 04:23:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 6 Jan 2017 04:23:21 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: larsi@gnus.org, Tino Calancha , npostavs@users.sourceforge.net, Mark Oteiza , schwab@linux-m68k.org, Dmitry Gutov , 25105@debbugs.gnu.org To: Dima Kogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 06 05:23:15 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPM3c-0006Dl-L2 for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Jan 2017 05:23:12 +0100 Original-Received: from localhost ([::1]:50053 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPM3e-0005ol-QR for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Jan 2017 23:23:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPM3V-0005oP-OH for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2017 23:23:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cPM3S-0006wI-KA for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2017 23:23:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57069) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cPM3S-0006wE-GI for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2017 23:23:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cPM3S-0001mW-AU for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2017 23:23:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Jan 2017 04:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25105 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25105-submit@debbugs.gnu.org id=B25105.14836765816827 (code B ref 25105); Fri, 06 Jan 2017 04:23:02 +0000 Original-Received: (at 25105) by debbugs.gnu.org; 6 Jan 2017 04:23:01 +0000 Original-Received: from localhost ([127.0.0.1]:44235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPM3Q-0001m3-QU for submit@debbugs.gnu.org; Thu, 05 Jan 2017 23:23:01 -0500 Original-Received: from mail-pg0-f65.google.com ([74.125.83.65]:35509) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPM3P-0001lo-By for 25105@debbugs.gnu.org; Thu, 05 Jan 2017 23:22:59 -0500 Original-Received: by mail-pg0-f65.google.com with SMTP id i5so42741612pgh.2 for <25105@debbugs.gnu.org>; Thu, 05 Jan 2017 20:22:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=tzIw0iI7XE2n3iIuFjbq/Pb9GwuWS9Q9kTWqFGyFiqM=; b=oeWGBSTBfQwhobQA5YhwK5rAORDq6sbgE9vnGHnWtzoASeOMcFXevIJZzfSG8txwDM nQ2slYMtEsP5GZRg0HKG5kpTmeqzoeiSGtJdUBQUJcmLwDKIm4oDNZSNkVvHnLUVmpQL elFONyMFNgi/VJLd7uyw6+SuJ5Cjj+JISmX7pYZFw5pBpG2WnWz25W7EJc4A1U5uTuUz rYp2z9ls/msoFbXx8fcNuUnIz1T2fnQC0qJGxxagul81/X/tEs8nCmHZGR3AFQHdID+N x7ZCSLFgZm6ry6Yyrj9hexsBjWoOaKMbmZVthv6hcDTpT2x1rBBStXPcRMysJ+YzyuIO 2g1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=tzIw0iI7XE2n3iIuFjbq/Pb9GwuWS9Q9kTWqFGyFiqM=; b=Q6jp7zn57iehOOh5sO6C3RA5dDXOraP7w3kJon3fBGciG0JPYfcq/q1rvhqPHROrOF hCMKAWvemcbiovsLo7KJmyiUdEJmsWDYvEDG5Gxc8L3sT9UO++H0CzwUN/LsADNbMx/V DTf5hl+nCUc4r+ffx7Kc2hKLR2yJKmGB0XTdSKyniU5gds4OFYZGVSvkhir2+XBAJt+x 6jsbWV7wn2fqomK+wBSe18uhtx7iJ2NoctZbZOiPkScDPdwbHn25VgOdh4YtoICZi3f+ eVV3BZKjK7/i5Um5ynxGQC3tzilJaLq/RfvvFrGh3t/FBFpdr0zX7IiSlnc6oxfPyUIh evqg== X-Gm-Message-State: AIkVDXL/RG/6viPaIMmvA4V7YXdQmV12x/28WSAwdO0TWNZAe0cY7zX08y+AdPVsMkjsag== X-Received: by 10.84.210.167 with SMTP id a36mr165040151pli.125.1483676573391; Thu, 05 Jan 2017 20:22:53 -0800 (PST) Original-Received: from calancha-pc (217.225.128.101.dy.bbexcite.jp. [101.128.225.217]) by smtp.gmail.com with ESMTPSA id u3sm156582002pfk.3.2017.01.05.20.22.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Jan 2017 20:22:52 -0800 (PST) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: <87tw9dc7bk.fsf@secretsauce.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127812 Archived-At: Hi Dima, thanks for your prompt replay. i am sorry, i didn't follow the discussion in Bug#17544, so i just realized its effects once the patch was pushed; those effects affect my everyday use of Emacs. (Added as CC the people who joined Bug#17544). On Thu, 5 Jan 2017, Dima Kogan wrote: > This isn't a misbehavior, it's the whole point of the patch. We can > argue about whether it's an improvement or not My point is that Bug#17544 is not a bug, it's a feature. Your fix just breaks the feature. > if this is a "bug", then the solution is a full revert. It might be the right thing to do. I was actually very happy with how Emacs-25 deal with this issue. Another posibility is the patch that Mark just sent to this thread. > The behavior I want is to always have a consistent idea of which hunk we > are currently on. IMO, this is not a good idea. Things depend of the perspective. If you are in one hunk or another it depends of what you want to do. That is part of the feature. >Navigation and use of diff buffers had several annoying corner cases that this >patch fixes. These corner cases were largely due to inconsistent treatment of >file headers. Say you have a diff such as this: I disagree, ideed i found it very consistent (see below). > --- aaa > +++ bbb > @@ -52,7 +52,7 @@ > hunk1 > @@ -74,7 +74,7 @@ > hunk2 > --- ccc > +++ ddd > @@ -608,6 +608,6 @@ > hunk3 > @@ -654,7 +654,7 @@ > hunk4 > >The file headers here are the '---' and '+++' lines. With the point on such a >line, hunk operations would sometimes refer to the next hunk and sometimes to >the previous hunk. Most of the time it would be the previous hunk, which is not >what the user would expect. It seems some users expect it :-) >This patch consistently treats such headers as the >next hunk. So with this patch, if the point is on the '--- ccc' line, the point >is seen as referring to hunk3. it's totally consistent to not consider the file header the same if you are not doing the same operation. If i am at --- ccc then, i want `diff-hunk-next' bring me to the line: @@ -608,6 +608,6 @@ and `diff-hunk-prev' bring me to the line: @@ -74,7 +74,7 @@ To this happen, in the first case the point must be considered at hunk2, but in the second case, the point must be considered in hunk3. To me, this is pretty consistent with the intended (and useful) behaviour. Regards, Tino