From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#25105: 26.0.50; diff navigation is broken Date: Fri, 6 Jan 2017 12:50:11 +0900 (JST) Message-ID: References: <87inpt6lce.fsf@gmail.com> <87tw9dc7bk.fsf@secretsauce.net> <87shoxc70l.fsf@secretsauce.net> <20170106030606.GB1101@holos.localdomain> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Trace: blaine.gmane.org 1483674682 25665 195.159.176.226 (6 Jan 2017 03:51:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 6 Jan 2017 03:51:22 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: 25105@debbugs.gnu.org, Dmitry Gutov , Tino Calancha , Dima Kogan , npostavs@users.sourceforge.net To: Mark Oteiza Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 06 04:51:17 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPLYc-0005PZ-A5 for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Jan 2017 04:51:10 +0100 Original-Received: from localhost ([::1]:49952 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPLYg-0004Dy-Hj for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Jan 2017 22:51:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55585) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPLYY-0004CR-0Z for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2017 22:51:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cPLYU-0005uV-TM for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2017 22:51:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57056) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cPLYU-0005uR-PT for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2017 22:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cPLYU-0000vh-B0 for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2017 22:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Jan 2017 03:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25105 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25105-submit@debbugs.gnu.org id=B25105.14836746233515 (code B ref 25105); Fri, 06 Jan 2017 03:51:02 +0000 Original-Received: (at 25105) by debbugs.gnu.org; 6 Jan 2017 03:50:23 +0000 Original-Received: from localhost ([127.0.0.1]:44222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPLXr-0000ud-Gb for submit@debbugs.gnu.org; Thu, 05 Jan 2017 22:50:23 -0500 Original-Received: from mail-pf0-f193.google.com ([209.85.192.193]:35745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPLXp-0000uL-6E for 25105@debbugs.gnu.org; Thu, 05 Jan 2017 22:50:21 -0500 Original-Received: by mail-pf0-f193.google.com with SMTP id f144so295374pfa.2 for <25105@debbugs.gnu.org>; Thu, 05 Jan 2017 19:50:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=rIktY9eg9OJCxvXsbjUQaFHw1R19uTvbzWhrfJQVFa0=; b=ggTbGtOwptzqO57O4M5GxuI6+5X5kJgj0IoDsSNbm5adPN4E7VTiAiNsCeuEynNEPd AKxxAhiETz90rdvoN4HQfig5ApM5eZx6B+FkbDvEL8cOJa2Xc0UxQPDw9Gbx4wNip6KU N24lzrrS/2axTa0H1T4knSFfjb7l4FpgaP1JF8/jFe6koexSPL9aGiuUppQrr3yB6iRs hBPm60W7XndUPpKB74gJMYoFKnJfBqIrV+Hc1ipqbpl6qHDmNPz01147ezTTSz6s31Bz SixamWLatT3QvMiuCCDO14N55zaexf/MlUnScKA3HwVtbw9Mvjt18N7phU+mxUeC4bQE AwgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=rIktY9eg9OJCxvXsbjUQaFHw1R19uTvbzWhrfJQVFa0=; b=MmNaCmr+PYUNaIQCfA/wU6yULyOpgduW5WLaEiEl6Ij1v5RTThEm5dEl5rp92HguFC 0uE5nGJ1SrAry/U7JQs7DLBoL4mJ3HulzVL/RR8h2+nKLqgQcBEz7d578O3GnfZAHH+d VLdTfNFZ3NfoSefUVe1GIoxZDBN1baKxxwuypInJjE9YAmfdyMnjg38xFWDaGUoI0X21 IZUQ4O/FVOcieTpJTk9C1spBe+b4Pj6spQ6r58b+G7QoSOWAXWzNxTExsSXZJDoxup86 vN840wLEpbJ0Dd8Xm6Kh0uyiXWCSk3N+gQ9WYbYNw65WnwK7fn7V0QsTm24CuO+Uol/a ceeQ== X-Gm-Message-State: AIkVDXKXvItNu/GisguBSgZ8pFwk7byozzuS7oGkuWixQo7O5Fmsbn3QYZBNLxISt0PQoQ== X-Received: by 10.84.128.1 with SMTP id 1mr5366938pla.55.1483674614953; Thu, 05 Jan 2017 19:50:14 -0800 (PST) Original-Received: from calancha-pc (217.225.128.101.dy.bbexcite.jp. [101.128.225.217]) by smtp.gmail.com with ESMTPSA id f3sm80289732pga.1.2017.01.05.19.50.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Jan 2017 19:50:14 -0800 (PST) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: <20170106030606.GB1101@holos.localdomain> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127809 Archived-At: On Thu, 5 Jan 2017, Mark Oteiza wrote: > At first glance, it looks like the following patch would restore the > previous behavior, however it completely breaks auto refinement. > > diff --git a/lisp/vc/diff-mode.el b/lisp/vc/diff-mode.el > index 9dfcd944bb..3442b01d12 100644 > --- a/lisp/vc/diff-mode.el > +++ b/lisp/vc/diff-mode.el > @@ -625,7 +625,7 @@ diff--wrap-navigation > ;; inner one does not, which breaks the loop. > (defun diff-hunk-prev (&optional count skip-hunk-start) > "Go to the previous COUNT'th hunk." > - (interactive (list (prefix-numeric-value current-prefix-arg) t)) > + (interactive (list (prefix-numeric-value current-prefix-arg) nil)) > (diff--wrap-navigation > skip-hunk-start > "prev hunk" > @@ -636,7 +636,7 @@ diff-hunk-prev > > (defun diff-hunk-next (&optional count skip-hunk-start) > "Go to the next COUNT'th hunk." > - (interactive (list (prefix-numeric-value current-prefix-arg) t)) > + (interactive (list (prefix-numeric-value current-prefix-arg) nil)) > (diff--wrap-navigation > skip-hunk-start > "next hunk" > @@ -647,7 +647,7 @@ diff-hunk-next > > (defun diff-file-prev (&optional count skip-hunk-start) > "Go to the previous COUNT'th file." > - (interactive (list (prefix-numeric-value current-prefix-arg) t)) > + (interactive (list (prefix-numeric-value current-prefix-arg) nil)) > (diff--wrap-navigation > skip-hunk-start > "prev file" > @@ -658,7 +658,7 @@ diff-file-prev > > (defun diff-file-next (&optional count skip-hunk-start) > "Go to the next COUNT'th file." > - (interactive (list (prefix-numeric-value current-prefix-arg) t)) > + (interactive (list (prefix-numeric-value current-prefix-arg) nil)) > (diff--wrap-navigation > skip-hunk-start > "next file" Hi Mark, i have checked out your patch and your right: it recovered the Emacs-25 behaviour in your snippet code. Tino