From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: Re: Reformat all of src/ Date: Thu, 29 Dec 2016 21:04:13 +0900 (JST) Message-ID: References: <87h95olvg0.fsf@gmail.com> <83eg0rv1up.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: blaine.gmane.org 1483013106 4190 195.159.176.226 (29 Dec 2016 12:05:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 29 Dec 2016 12:05:06 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: jwiegley@gmail.com, czipperz@gmail.com, rms@gnu.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 29 13:05:00 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cMZS7-00008Y-96 for ged-emacs-devel@m.gmane.org; Thu, 29 Dec 2016 13:04:59 +0100 Original-Received: from localhost ([::1]:35138 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cMZSA-000698-Ar for ged-emacs-devel@m.gmane.org; Thu, 29 Dec 2016 07:05:02 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38219) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cMZRY-00068s-UJ for emacs-devel@gnu.org; Thu, 29 Dec 2016 07:04:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cMZRY-00023w-5C for emacs-devel@gnu.org; Thu, 29 Dec 2016 07:04:24 -0500 Original-Received: from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242]:35464) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cMZRS-0001uc-Ou; Thu, 29 Dec 2016 07:04:18 -0500 Original-Received: by mail-pf0-x242.google.com with SMTP id i88so20727395pfk.2; Thu, 29 Dec 2016 04:04:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=kHog2fUqBEIT/gylWWFIvA8O/YBmdL6P5BRSAHNo98I=; b=AwKDn6ihFw0+aoc77BMBOzWyCgdb7zCa7tn2gXsnaP5MhDEKTyhifS+XqTAhKr/BF0 zxB5E9V76X405+PsawaTcUoN6VdrqLwibGIqFz0+YQ5bs/Kl9BEAjMb/B3m0CIWL6CwG lnBnfJbBTxcm6CGikkIBzp7V5L9JOmXF6vqq/2OvSATwNfbYJ0v0NdEprlJn9azqS569 FLKJ4zks1qqGEk9IIt1PswPqw8haDr/bFOd0LTihqzB74oSxDnPHDcnv8g313BqOtKEe druHW7f9qb4bwtvxNkFh+rgAJQyd92WqOUQ3Y/1FZgneswxmx0raCThgXTDyjewIS+vO LH3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=kHog2fUqBEIT/gylWWFIvA8O/YBmdL6P5BRSAHNo98I=; b=G4w4vGZayHz/63vkpQDk+8ypDaWR4MnFDFnqIaSsTg7ahDj1vSeRTgZ8gRdEqo2Rfc pC5y3bgk3Jn2WuyVPGqbpf3JMqr2kvkrHyTPyMoUVihFTw6Pfgm/rVSQAQ8N14eHxtiD vqw2rG/fl3pfkZxr+Fd7zNNoE4vwUV+lDOc0eIYuGpiB2QytPdGRw9oFUEKB9lpcxsZr lDJSBXb1K/WiFppZQq1Y8izxZ36iL31+SDSqk1dLRCjL0v/Br98jQyEbgn1Q2V3A6Z9P FLP7xduItATPcMYj0oQ9aOroX/PuNncqCiPQaX0vd10Tj9KGPQnajKa7r1UUbPOysrJR 0KNg== X-Gm-Message-State: AIkVDXLxMXS3pTzhpYvKc+TRqKc2EKnUoL/5SHstk2PsG4SyESuqVMzw1JzGAxcqFgDNdQ== X-Received: by 10.99.127.16 with SMTP id a16mr76045362pgd.60.1483013057572; Thu, 29 Dec 2016 04:04:17 -0800 (PST) Original-Received: from calancha-pc (217.225.128.101.dy.bbexcite.jp. [101.128.225.217]) by smtp.gmail.com with ESMTPSA id e1sm89650545pga.37.2016.12.29.04.04.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Dec 2016 04:04:16 -0800 (PST) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: <83eg0rv1up.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c00::242 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210950 Archived-At: On Thu, 29 Dec 2016, Eli Zaretskii wrote: >> A single change which affects only whitespace >> won't cause any confusion no matter how many places that whitespace >> is changed. > > It makes digging into code history harder, especially when files are > also renamed later. > > We arrived at the current convention of not doing such changes unless > real code changes are also committed based on our practice, so I don't > think we should reverse that decision. Is just a voluntary convention? Is is prefered or discouraged? If the former, then we might encourage it adding some instructions in CONTRIBUTE about when/how do this thing. When i am changing a function which uses tabs for indentation, i think that is a good opportunity to change such func. to use white spaces instead. The reason why i don't do it by default in any commit is the lack of official instructions on this subject.