From: Tino Calancha <tino.calancha@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: jwiegley@gmail.com, czipperz@gmail.com, rms@gnu.org, emacs-devel@gnu.org
Subject: Re: Reformat all of src/
Date: Thu, 29 Dec 2016 21:04:13 +0900 (JST) [thread overview]
Message-ID: <alpine.DEB.2.20.1612292053100.18396@calancha-pc> (raw)
In-Reply-To: <83eg0rv1up.fsf@gnu.org>
On Thu, 29 Dec 2016, Eli Zaretskii wrote:
>> A single change which affects only whitespace
>> won't cause any confusion no matter how many places that whitespace
>> is changed.
>
> It makes digging into code history harder, especially when files are
> also renamed later.
>
> We arrived at the current convention of not doing such changes unless
> real code changes are also committed based on our practice, so I don't
> think we should reverse that decision.
Is just a voluntary convention? Is is prefered or discouraged?
If the former, then we might encourage it adding some instructions
in CONTRIBUTE about when/how do this thing.
When i am changing a function which uses tabs for indentation, i
think that is a good opportunity to change such func. to use white
spaces instead. The reason why i don't do it by default in any commit
is the lack of official instructions on this subject.
next prev parent reply other threads:[~2016-12-29 12:04 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 0:59 Reformat all of src/ Chris Gregory
2016-12-28 3:43 ` Stefan Monnier
2016-12-28 4:45 ` John Wiegley
2016-12-28 4:52 ` Chris Gregory
2016-12-28 5:01 ` Chris Gregory
2016-12-28 12:58 ` Phillip Lord
2016-12-28 15:35 ` John Yates
2016-12-28 15:39 ` Lars Ingebrigtsen
2016-12-28 16:01 ` John Yates
2016-12-28 16:27 ` Lars Ingebrigtsen
2016-12-28 16:17 ` Phillip Lord
2016-12-28 17:19 ` Stefan Monnier
2016-12-28 17:35 ` Phillip Lord
2016-12-28 17:52 ` Stefan Monnier
2016-12-28 17:59 ` Eli Zaretskii
2016-12-28 16:32 ` Yuri Khan
2016-12-28 16:37 ` Lars Ingebrigtsen
2016-12-28 16:56 ` Yuri Khan
2016-12-28 16:59 ` John Wiegley
2016-12-28 17:12 ` Yuri Khan
2016-12-28 17:20 ` Phillip Lord
2016-12-28 18:38 ` Paul Eggert
2016-12-29 1:10 ` Dmitry Gutov
2016-12-29 5:53 ` Paul Eggert
2016-12-29 11:28 ` Dmitry Gutov
2016-12-30 1:07 ` Paul Eggert
2016-12-30 10:34 ` Phillip Lord
2017-01-01 1:14 ` Dmitry Gutov
2016-12-29 13:18 ` Phillip Lord
2016-12-29 16:17 ` Eli Zaretskii
2016-12-29 17:18 ` John Covici
2016-12-29 17:19 ` John Covici
2016-12-30 10:30 ` Phillip Lord
2016-12-28 17:23 ` John Yates
2016-12-31 10:23 ` Philippe Vaucher
2016-12-29 1:36 ` Richard Stallman
2016-12-29 3:41 ` Eli Zaretskii
2016-12-29 12:04 ` Tino Calancha [this message]
2016-12-29 16:15 ` Eli Zaretskii
2016-12-30 0:09 ` Richard Stallman
2016-12-30 8:21 ` Eli Zaretskii
2016-12-29 14:39 ` Stefan Monnier
2016-12-28 10:27 ` hector
-- strict thread matches above, loose matches on Subject: below --
2016-12-29 2:08 Chris Gregory
2016-12-29 3:38 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1612292053100.18396@calancha-pc \
--to=tino.calancha@gmail.com \
--cc=czipperz@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jwiegley@gmail.com \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.