From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: Re: Comment in verilog-mode.el about supported versions Date: Mon, 19 Dec 2016 23:02:26 +0900 (JST) Message-ID: References: <7q37hk82gp.fsf@emma.svaha.wsnyder.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: blaine.gmane.org 1482156199 18119 195.159.176.226 (19 Dec 2016 14:03:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 19 Dec 2016 14:03:19 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: kaushal.modi@gmail.com, Emacs developers , Tino Calancha , Noam Postavsky To: Wilson Snyder Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 19 15:03:10 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cIyWy-0002zS-0l for ged-emacs-devel@m.gmane.org; Mon, 19 Dec 2016 15:03:08 +0100 Original-Received: from localhost ([::1]:45818 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cIyX0-0007O5-SH for ged-emacs-devel@m.gmane.org; Mon, 19 Dec 2016 09:03:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46126) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cIyWO-0007Jl-22 for emacs-devel@gnu.org; Mon, 19 Dec 2016 09:02:33 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cIyWN-0000li-8u for emacs-devel@gnu.org; Mon, 19 Dec 2016 09:02:32 -0500 Original-Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]:36604) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cIyWN-0000lL-2p for emacs-devel@gnu.org; Mon, 19 Dec 2016 09:02:31 -0500 Original-Received: by mail-pg0-x244.google.com with SMTP id w68so2577838pgw.3 for ; Mon, 19 Dec 2016 06:02:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=/N5+g9XZH++CwswVXms2WPTq4nQHCceLAuS0wTWwydc=; b=qlScYpysZGsRFqgHtFWr+5Z+H5MaRg4EKja4C2holX5IxgCVSVNXXua+6a0f0wu1vr T1114tLdNXJ37TdA9wAlrwCmGpSsrrOI7SNSPQ+wvbTKm7RvhWJS0cH5E/HelyOJJsTW vNQJK4FsVNfh2velYBjMAySVwa7kyvyg6EGH7p9hV3eUZG+Gd6ZmMeNVnkE8ys3Gyol5 FFO3apUFSYrJngvRP6z0D7UODN8YDp/AQhFgpD+CHb5d+LQcDOcRuvxcv5rmEgQH3hkd kJw14flIY+v9H7swoWjLN6FNHJlUGoGqwooR/jdEsmY7I7WTyhCAK5jX0R3LwNmK19NA /lUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=/N5+g9XZH++CwswVXms2WPTq4nQHCceLAuS0wTWwydc=; b=DfTf7vQvDvpWFrczLFmOYuhSrYwfSNtNsToQIY0PvSuf1oglJitGJZEqPbMEbZRelb gX2vyzfYmD8BzuFtdnPCgWV+9UHSUbmtLQd4dN3JbAYExAFUwwdu0VB/Fnt2J4pbfqQ0 F9GaTZ53tjDVLoZHs0a42szBsPoxsiwGXtP7+8J4OfJJHwtJvUTwffKup81/knQ5vW92 +u66LdFrzR6aL2SUbnvpmlsbpQc7xizgpl6q2U4X7Zyom7PtB9tqwNJPJOwtKEeDs6Hl hf4q2PPAzIo16VyxXMdGQldbl3wePWxQfpjCMsL9b5/FoCYYmlv4byygHwoz0soDywqm +r4w== X-Gm-Message-State: AKaTC03b8jG5C/0AyWuZGXX/09bKOkkiFGRUI62yVUv+UazjYjnDbAMUoWitBr4XnY8cJA== X-Received: by 10.99.48.68 with SMTP id w65mr29095791pgw.68.1482156150137; Mon, 19 Dec 2016 06:02:30 -0800 (PST) Original-Received: from calancha-pc ([240f:6e:c111:1:87d4:550f:514f:c022]) by smtp.gmail.com with ESMTPSA id p67sm31941907pfb.2.2016.12.19.06.02.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Dec 2016 06:02:29 -0800 (PST) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: <7q37hk82gp.fsf@emma.svaha.wsnyder.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c05::244 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210632 Archived-At: On Mon, 19 Dec 2016, Wilson Snyder wrote: > >>> On Mon, Dec 19, 2016, 5:19 PM Tino Calancha wrote: >>>> >>>> in the comentary of >>>> lisp/progmodes/verilog-mode.el >>>> you can find following comment: >>>> ;; This code supports Emacs 21.1 and later >>>> ;; And XEmacs 21.1 and later >>>> ;; Please do not make changes that break Emacs 21. Thanks! >>>> >>>> I could understand this comment in a version of this file >>>> elsewhere, e.g. ELPA, but not in the built-in version in Emacs. >>>> Why is this comment needed? >>>> Is it OK to drop from the master branch this kind of comments? > > Please retain this, this entire file is identical with that > used on other versions of Emacs. It would be otherwise > be nearly impossible to manage diverging files. Sorry, I don't understand why it should be difficult or what makes more difficult to handle this file that, for instance tramp or cc-mode. Wouldn't it better to keep one verilog-mode.el version in ELPA fully compatible with Emacs-21? And let the file in the master branch to benefit of all that has come since Emacs-21? I also notice that the file is very large (> 14 klines). Maybe it would be easier to maintain if the file is split in 4-5 files. Regards, Tino