From: Tino Calancha <tino.calancha@gmail.com>
To: Wilson Snyder <wsnyder@wsnyder.org>
Cc: kaushal.modi@gmail.com, Emacs developers <emacs-devel@gnu.org>,
Tino Calancha <tino.calancha@gmail.com>,
Noam Postavsky <npostavs@users.sourceforge.net>
Subject: Re: Comment in verilog-mode.el about supported versions
Date: Mon, 19 Dec 2016 23:02:26 +0900 (JST) [thread overview]
Message-ID: <alpine.DEB.2.20.1612192241320.6414@calancha-pc> (raw)
In-Reply-To: <7q37hk82gp.fsf@emma.svaha.wsnyder.org>
On Mon, 19 Dec 2016, Wilson Snyder wrote:
>
>>> On Mon, Dec 19, 2016, 5:19 PM Tino Calancha <tino.calancha@gmail.com> wrote:
>>>>
>>>> in the comentary of
>>>> lisp/progmodes/verilog-mode.el
>>>> you can find following comment:
>>>> ;; This code supports Emacs 21.1 and later
>>>> ;; And XEmacs 21.1 and later
>>>> ;; Please do not make changes that break Emacs 21. Thanks!
>>>>
>>>> I could understand this comment in a version of this file
>>>> elsewhere, e.g. ELPA, but not in the built-in version in Emacs.
>>>> Why is this comment needed?
>>>> Is it OK to drop from the master branch this kind of comments?
>
> Please retain this, this entire file is identical with that
> used on other versions of Emacs. It would be otherwise
> be nearly impossible to manage diverging files.
Sorry, I don't understand why it should be difficult or what makes more
difficult to handle this file that, for instance tramp or cc-mode.
Wouldn't it better to keep one verilog-mode.el version in ELPA
fully compatible with Emacs-21?
And let the file in the master branch to benefit of all that
has come since Emacs-21?
I also notice that the file is very large (> 14 klines).
Maybe it would be easier to maintain if the file is split in 4-5 files.
Regards,
Tino
next prev parent reply other threads:[~2016-12-19 14:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 13:37 Comment in verilog-mode.el about supported versions Wilson Snyder
2016-12-19 14:02 ` Tino Calancha [this message]
2016-12-19 15:02 ` Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2016-12-19 14:32 Wilson Snyder
2016-12-19 15:35 ` Tino Calancha
2016-12-19 11:49 Tino Calancha
2016-12-19 13:02 ` Kaushal Modi
2016-12-19 13:09 ` Noam Postavsky
2016-12-19 13:47 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1612192241320.6414@calancha-pc \
--to=tino.calancha@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=kaushal.modi@gmail.com \
--cc=npostavs@users.sourceforge.net \
--cc=wsnyder@wsnyder.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.