Re: [Emacs-diffs] master bd22beb: Add seq-random-elt to seq.el

Re: [Emacs-diffs] master bd22beb: Add seq-random-elt to seq.el

[Stefan Monnier]

> +Return nil if SEQUENCE is nil."
> +  (if (seq-empty-p sequence)
> +      (error "Sequence cannot be empty")

Hmm... which is it?


        Stefan

Re: [Emacs-diffs] master bd22beb: Add seq-random-elt to seq.el

[Damien Cassou]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> +Return nil if SEQUENCE is nil."
>> +  (if (seq-empty-p sequence)
>> +      (error "Sequence cannot be empty")
>
> Hmm... which is it?

I'm not sure I understand your question. I could have written:

    (error "Sequence %s cannot be empty" sequence)

but I thought it was useless because SEQUENCE is empty and nothing
meaningful would be added to the message.

-- 
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

Re: [Emacs-diffs] master bd22beb: Add seq-random-elt to seq.el

[Stefan Monnier]

>>> +Return nil if SEQUENCE is nil."
>>> +  (if (seq-empty-p sequence)
>>> +      (error "Sequence cannot be empty")
>> 
>> Hmm... which is it?

> I'm not sure I understand your question.

The question was: should I obey the docstring or the code?


        Stefan

Re: [Emacs-diffs] master bd22beb: Add seq-random-elt to seq.el

[Tino Calancha]

On Tue, 25 Oct 2016, Stefan Monnier wrote:

>>>> +Return nil if SEQUENCE is nil."
>>>> +  (if (seq-empty-p sequence)
>>>> +      (error "Sequence cannot be empty")
>>>
>>> Hmm... which is it?
>
>> I'm not sure I understand your question.
>
> The question was: should I obey the docstring or the code?
The code, always the code.

Indeed, pretty consistent, after all this function is about getting a 
_random_ element from a sequence; if the doc string assures something 
opposite as the code, then it's very hard to predict the result of the 
coin flipping experiment, regardless of which is the underline random 
generation engine.

Re: [Emacs-diffs] master bd22beb: Add seq-random-elt to seq.el

[Nicolas Petton]

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

Tino Calancha <tino.calancha@gmail.com> writes:

>> The question was: should I obey the docstring or the code?
> The code, always the code.

Indeed!

Nico

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]

Re: [Emacs-diffs] master bd22beb: Add seq-random-elt to seq.el

[Nicolas Petton]

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

Hi Stefan,

> The question was: should I obey the docstring or the code?

I fixed the docstring.

Cheers,
Nico

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]