From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: Re: Proposal: font lock for `describe-variable` Date: Tue, 11 Oct 2016 22:57:01 +0900 (JST) Message-ID: References: <1474949378.32234.5.camel@gmail.com> <83shslbax3.fsf@gnu.org> <83ponpb5rv.fsf@gnu.org> <57d030e9-1f2e-bc8e-f032-6ac345798c5f@gmail.com> <3699d8e4-b580-e0cb-6d50-6cdf09b93ca4@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-811814958-1476194226=:30699" X-Trace: blaine.gmane.org 1476194688 25211 195.159.176.226 (11 Oct 2016 14:04:48 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 11 Oct 2016 14:04:48 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: Tianxiang Xiong , Emacs developers , Eli Zaretskii , monnier@iro.umontreal.ca, Tino Calancha To: =?ISO-8859-15?Q?Cl=E9ment_Pit--Claudel?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 11 16:04:40 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1btxfF-0002k3-Gv for ged-emacs-devel@m.gmane.org; Tue, 11 Oct 2016 16:04:17 +0200 Original-Received: from localhost ([::1]:55985 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btxfE-0006XZ-6j for ged-emacs-devel@m.gmane.org; Tue, 11 Oct 2016 10:04:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btxYV-0001mL-CT for emacs-devel@gnu.org; Tue, 11 Oct 2016 09:57:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btxYR-00037u-G0 for emacs-devel@gnu.org; Tue, 11 Oct 2016 09:57:19 -0400 Original-Received: from mail-pa0-x22f.google.com ([2607:f8b0:400e:c03::22f]:32801) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btxYK-00034u-Ld; Tue, 11 Oct 2016 09:57:08 -0400 Original-Received: by mail-pa0-x22f.google.com with SMTP id vu5so15587075pab.0; Tue, 11 Oct 2016 06:57:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=BtuQQyKzwpAW1jlDAcDqI5kbMUmTm/5VwYBSGmVBCZk=; b=ZnMbH0+Cy2fKfEUWoWxpEIR4d5kBzV/AfN08HnOB9Q6U09Wk4Jd1EekYkd1TcHVf/Y rwj2KhPV3hxAmiHqoYyB4p47fMgnv3e+VpdHLplqLL7Vkal6+jEWqlD/2Ioc9ESJ1T9U ZXxCK5s+wvSpnCD0Htatv8wKRmwW4TD/yxUqCesTitqYCWJ3y4lDJGdzaeOPGwCy6Idh F3R6jF4LIM9iQfYHkVXl6WDoftBOt8syc7Dbu+0vSyqJHJysneI7vCJV4tQqXje1MvIq 4CgEVsKdRv3pHDfHaaYXSksdpPwqoCoeMQrelE5TCrX2w06VedNVkL/bqGYBwZxsUkRY 5aUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=BtuQQyKzwpAW1jlDAcDqI5kbMUmTm/5VwYBSGmVBCZk=; b=OWaoU0PBaiHmvCkf32y3eiTFAeha7BfxB5VQ/OPd3P+cQfCF6VDNmoUQ2M++pxD3P8 lwzblRVafv3Gmvx88DLyllZqa4ADTudKT+/WBlbS7P+cvVL4gNyEJK10YzB/2MhSxOqv xNq1H+VHawdqY273KLSdIPhS0gEWqhuyv9kkah6B4GIzkFs832xCuvtTZgJFGaVIWxJp Hr8inieXX0+6D/xzbcmWGTGgElz1cA4gyNbJs4eOixqpvgKOa6gZpi9Yu1qdepT8po1J UuECQ2cv7OXqDgh7gmrP91h6eM+/JY3s5EBN2BSU9sBLRaEgzAq5YEkQJjL81pp3aXFE DVJQ== X-Gm-Message-State: AA6/9RngnTPp3/D6dGs7A5e/H0S/mTHVUF8YbPAcxtFHmjSZvaDXz+dR3qDOQmMVOokOqg== X-Received: by 10.66.26.49 with SMTP id i17mr7087701pag.145.1476194227750; Tue, 11 Oct 2016 06:57:07 -0700 (PDT) Original-Received: from calancha-pc (57.92.100.220.dy.bbexcite.jp. [220.100.92.57]) by smtp.gmail.com with ESMTPSA id yk6sm4647287pab.43.2016.10.11.06.57.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Oct 2016 06:57:06 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: <3699d8e4-b580-e0cb-6d50-6cdf09b93ca4@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c03::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:208159 Archived-At: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-811814958-1476194226=:30699 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8BIT On Tue, 11 Oct 2016, Clément Pit--Claudel wrote: > On 2016-10-11 01:59, Tino Calancha wrote: >> In my case i prefer how *Help* buffer looks now an i would be >> dissapointed if after one 'git pull', i found that *Help* buffer looks >> very different. But it's just my opinion :-) > > Are there things the OP can do to minimize that disappointment? My disappointment doesn't matter as longer as others find this patch nicer than what we have now. >Can you suggest specific improvements? I can test the patch and report things that are not working properly or that looks weird. It's what i have done. But I am not the right person to suggest specific improvements in the fontification part because i am not crazy with such fontifications: i do like how *Help* buffer looks now after `F1-v'. But I will suggest another thing. So far, the patch looks very large, and it tries to perform 2 different tasks: A) Simplify, refactorize the code. B) Add fontification in some parts. i am very interested in the part A. IMO it's easier to review this if first one patch is presented doing just A). Then, once we are happy with the first patch, the OP might prepare a patch on top of the previous doing the remaining part, i.e., B). Regards, Tino --8323329-811814958-1476194226=:30699--