From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add facility to collect stderr of async subprocess Date: Thu, 6 Oct 2016 16:25:39 +0900 (JST) Message-ID: References: <83pp87y6iu.fsf@gnu.org> <83mw3bxz9f.fsf@gnu.org> <83k2yfx8zi.fsf@gnu.org> <83egomxog1.fsf@gnu.org> <83ego5tjgt.fsf@gnu.org> <877ftno4fr.fsf-ueno@gnu.org> <55247A98.5020302@cs.ucla.edu> <83r3rvgn4e.fsf@gnu.org> <877ftja89d.fsf-ueno@gnu.org> <87wphnwh2q.fsf@gmail.com> <83zimjl1zp.fsf@gnu.org> <83vax7l00s.fsf@gnu.org> <83y422j7br.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: blaine.gmane.org 1475738818 21570 195.159.176.226 (6 Oct 2016 07:26:58 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 6 Oct 2016 07:26:58 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: jwiegley@gmail.com, emacs-devel@gnu.org, michael.albinus@gmx.de, Tino Calancha To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 06 09:26:51 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bs34q-0004TL-1q for ged-emacs-devel@m.gmane.org; Thu, 06 Oct 2016 09:26:48 +0200 Original-Received: from localhost ([::1]:53690 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bs34o-0001j1-KH for ged-emacs-devel@m.gmane.org; Thu, 06 Oct 2016 03:26:46 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bs33z-0001gI-DJ for emacs-devel@gnu.org; Thu, 06 Oct 2016 03:25:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bs33t-0003eB-D1 for emacs-devel@gnu.org; Thu, 06 Oct 2016 03:25:54 -0400 Original-Received: from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242]:35181) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bs33n-0003cR-HW; Thu, 06 Oct 2016 03:25:44 -0400 Original-Received: by mail-pf0-x242.google.com with SMTP id t25so707767pfg.2; Thu, 06 Oct 2016 00:25:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=hgsw0EyULLd24u5QhV7zaEqyOckiDXHh3j8Y5f6dQ8I=; b=rY1xIDF+UJpvhGx0uOQoyNFBw94h8g1ZzeBsfyICb7XkwiSO+1q2+i3MhNTkkR5BaY qc0n9Lgm36uwivaeOMVqNtwWF/JZ/Dut09+8xzmW6Axxqdx5MfelFI+V45+UkzgMGN1+ cOa6858upfLoj3CLyBfUqghIN7v1STqqJkmifx2TE5i1ZjzbC05Zc/fcFXimtCMFveMe CM3UIsfjLF60/fthTGm0Cs3IzhMVhRCF/ks2MLoYgmAR5eEn5fFmXxeagrfNIN6OTpqd fWaRWNVIhqtmXK/oaHTIUxI5hmX1tVGopvCaN+EbhHJVs2UNt2uEyzaaPIPJKXoFWmqv vWCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=hgsw0EyULLd24u5QhV7zaEqyOckiDXHh3j8Y5f6dQ8I=; b=EzbzXcKJEFPMA+IO9jjRW/9RPvLDzVYLns/NPahPIiszmbbZQProDZQd1+iZx1WSeS riWxuEyU5N7LFlzAIZKD7gYQ6nfYIYfiVVoyteeaXVhFqQ7jlgRyQl6g/w8XWcRExBjN VETiQZCdze5yaL3q+iXY1gLhnPYafgwmYM03P2PH+2GQQgz6iNwG1chw/uOKk7asp7H6 wI9pg5BFc3MITrWWKjZM4H4ePqDTAJsKAVazuTMlCbXA0lY2bTyPP4el0UmwwFRCqEmA C4TCIHbe9DgO66JfHQWVckAITpkFv2lMTef0PzoGqZzHnGri7dCw4tmXaYjU17FQclfx X8MA== X-Gm-Message-State: AA6/9RkTKwvi2TspkG8DftFXgeZred0jedQPzzczvWWSMqMafQxC64cFv96eLeG9A92ZHA== X-Received: by 10.98.129.132 with SMTP id t126mr14907340pfd.59.1475738742645; Thu, 06 Oct 2016 00:25:42 -0700 (PDT) Original-Received: from calancha-pc (57.92.100.220.dy.bbexcite.jp. [220.100.92.57]) by smtp.gmail.com with ESMTPSA id ak3sm19680891pad.19.2016.10.06.00.25.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Oct 2016 00:25:42 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: <83y422j7br.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c00::242 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:208022 Archived-At: On Thu, 6 Oct 2016, Eli Zaretskii wrote: >> From: Tino Calancha >> Date: Thu, 6 Oct 2016 12:13:11 +0900 (JST) >> >> We have an entry in the TODO list requesting exactly what i am >> suggesting :-) > > It's an old item (from 2004), written before we had make-process. > Thanks for pointing this out. > >> Question: >> can we conclude that following entry in TODO file has being >> fulfilled by Daiki work? > > Yes, I think so. I agree : i also think the idea underneath such TODO entry matches what Daiki san did. By the way, i am fine if we don't follow my suggestion. I just want to remark that my patch repect backward compatibility: callers passing a buffer will get the traditional behaviour. It is just in case we pass a list that we will separate the stderr from stdout. As a bonus, several other functions will automatically inherit this feature: `start-file-process', `start-process-shell-command', and `start-file-process-shell-command'. Personally, i find pleasant if every function creating an asynchronous process us able to separate stdout from stderr. Another minor thing is that my patch fix a bug in async-shell-command: current implementation don't use the second optional argument ERROR-BUFFER. Of course, that could be fixed using `make-process'.