From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: Re: Remove * characters from the front of variable docstrings Date: Fri, 23 Sep 2016 19:32:52 +0900 (JST) Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: blaine.gmane.org 1474626897 22053 195.159.176.226 (23 Sep 2016 10:34:57 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 23 Sep 2016 10:34:57 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: rgm@gnu.org, Emacs developers , bzg@gnu.org, tsdh@gnu.org, eliz@gnu.org, drew.adams@oracle.com To: monnier@iro.umontreal.ca Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 23 12:34:48 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnNoe-0004fF-4c for ged-emacs-devel@m.gmane.org; Fri, 23 Sep 2016 12:34:48 +0200 Original-Received: from localhost ([::1]:43888 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnNoc-0001t3-IA for ged-emacs-devel@m.gmane.org; Fri, 23 Sep 2016 06:34:46 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54879) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnNo6-0001sO-8y for emacs-devel@gnu.org; Fri, 23 Sep 2016 06:34:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bnNo4-0005Ct-2v for emacs-devel@gnu.org; Fri, 23 Sep 2016 06:34:13 -0400 Original-Received: from mail-pf0-f194.google.com ([209.85.192.194]:36235) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnNnp-000530-QY; Fri, 23 Sep 2016 06:33:57 -0400 Original-Received: by mail-pf0-f194.google.com with SMTP id n24so5091701pfb.3; Fri, 23 Sep 2016 03:33:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:message-id:user-agent:mime-version; bh=KIuJvJ4L4M1uN+SRSuaq12IM/CdB88YvpRRe6n+L8Ew=; b=D1djLCe2zlN5WDYzQ77BOR9Qf4c3HP35uO2K9khdi4mIaze7utvXWZggci8jXp39pZ sNo7/toCYTKdWj6hPOt6PF6h98/vS6NJOCCaWW9ftxSqi9jCd+yLFOA73WlItzdIotoh 2qi7x7GChrW0UN+I6HYsxDKwigAA++XEKFKMEe953sufzNWMW/4WcjemVjDisS6bM+QC Ntr7LyKUh+e2rvJjpR+bFWgeMVc3Xux7IickVm0KKhGcYOcy5t5bGa3brouStlFPIHJk 3Sjud+p77HCO/6+YUCFGV61h/v50qnVjapkChaS/GAPDNZFO0UzqPdUV5lAfK2lOrgpi 1Glw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:message-id:user-agent :mime-version; bh=KIuJvJ4L4M1uN+SRSuaq12IM/CdB88YvpRRe6n+L8Ew=; b=NhihjCMHfsdSLcBKqkW5wK4D8JEiXcowBYEF2Kx9mIJI5wm0ZjlJaKZsZbVe8T3Q6r 2+qBGh9QEF5hF6MK2Yn3b7rbfr5VB3/M5iOEk1AANwj1IhPUdenBDDCZPuc/V03tz59T bifL9wA4fn14VfGXAEfHUo48/Eh3LHmDbbF6aMMTn+zeW0id5XVrD8EKt9mXwaC9jbd5 9va6Z0HP4VFmWJrUHE+c7mjmLITG0DlCc4zrfkAM00WWwV8l+4zz7Hh7ter0niUiGBvY 3ROtVQztzVhDRn83GYTKWEDclIAxicWaEExqCewgde/v7TiWHc0M4xVUaNa8gW0UbIcw CzCg== X-Gm-Message-State: AE9vXwMSaqnG/HJno627l6g4MX7XLjktWViTOPOU91HeMUn3nwTnNAFMH80qfW4g9SPiLg== X-Received: by 10.98.77.2 with SMTP id a2mr10403652pfb.138.1474626777107; Fri, 23 Sep 2016 03:32:57 -0700 (PDT) Original-Received: from calancha-pc (57.92.100.220.dy.bbexcite.jp. [220.100.92.57]) by smtp.gmail.com with ESMTPSA id f124sm10540467pfg.7.2016.09.23.03.32.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Sep 2016 03:32:56 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.192.194 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207724 Archived-At: This is about discussion in: https://lists.gnu.org/archive/html/emacs-devel/2012-04/msg00788.html On Thu, 26 Apr 2012, Stefan Monnier wrote: >On Thu, 26 Apr 2012, Glenn Morris wrote: >> However, hasn't some information been lost in the process? >Yup. It should only have been applied to defcustoms. >> Shouldn't it (and other defvars with *s) have been converted to defcustoms? >They should be converted to defcustoms, indeed, and only after that can >the * be removed. How about updating `shell-command-default-error-buffer' to a defcustom? See patch below: PD: There are more cases in commit fb7ada5f: defvar's having before doc strings starting with '*', and not being now a defcustom. ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; >From f10d2c98c2d3c6e0e5caf6b970c27c59176036a3 Mon Sep 17 00:00:00 2001 From: Tino Calancha Date: Fri, 23 Sep 2016 19:16:00 +0900 Subject: [PATCH] * lisp/simple.el (shell-command-default-error-buffer): Make a defcustom. --- lisp/simple.el | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/lisp/simple.el b/lisp/simple.el index 7e68baa..196361d 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -3152,11 +3152,16 @@ shell-command-history (defvar shell-command-switch (purecopy "-c") "Switch used to have the shell execute its command line argument.") -(defvar shell-command-default-error-buffer nil +(defcustom shell-command-default-error-buffer nil "Buffer name for `shell-command' and `shell-command-on-region' error output. This buffer is used when `shell-command' or `shell-command-on-region' is run interactively. A value of nil means that output to stderr and -stdout will be intermixed in the output stream.") +stdout will be intermixed in the output stream." + :type '(choice + (const :tag "None" nil) + (string "*Shell Command Error*")) + :group 'shell + :version "25.2") (declare-function mailcap-file-default-commands "mailcap" (files)) (declare-function dired-get-filename "dired" (&optional localp no-error-if-not-filep)) -- 2.9.3 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; In GNU Emacs 25.2.50.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.0) of 2016-09-23 Repository revision: 65dc67c87553bec4c8b36432246b13f09d653118