all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tino Calancha <tino.calancha@gmail.com>
To: 24086-done@debbugs.gnu.org
Subject: bug#24086: 25.1.50; ibuffer-do-view-1 fails to visit in new frame
Date: Fri, 23 Sep 2016 15:26:36 +0900 (JST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1609231524510.14987@calancha-pc> (raw)
In-Reply-To: <alpine.DEB.2.20.1609231522380.14987@calancha-pc>


Fixed in master branch as commit: 87925f11

On Fri, 23 Sep 2016, Tino Calancha wrote:

> On Wed, 14 Sep 2016, Tino Calancha wrote:
>
>> If there are no further objections i will push this patch to master in
>> a few days.
>
> I have pushed to master the following much simple patch:
>
>
> From 87925f1125acf95439e4563f9a30864cadf7cafb Mon Sep 17 00:00:00 2001
> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Fri, 23 Sep 2016 15:16:15 +0900
> Subject: [PATCH] ibuffer-do-view-other-frame: Display each buffer in a new
> frame
>
> * lisp/ibuffer.el (ibuffer-do-view-1):
> When TYPE equals 'other-frame, then display each buffer
> in a new frame (Bug#24086).
> ---
> lisp/ibuffer.el | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el
> index 0336f1d..e965535 100644
> --- a/lisp/ibuffer.el
> +++ b/lisp/ibuffer.el
> @@ -1143,17 +1143,17 @@ ibuffer-do-view-horizontally
>   (ibuffer-do-view-1 (if other-frame 'other-frame 'horizontally)))
>
> (defun ibuffer-do-view-1 (type)
> -  (let ((marked-bufs (ibuffer-get-marked-buffers)))
> -    (when (null marked-bufs)
> -      (setq marked-bufs (list (ibuffer-current-buffer t))))
> +  (let ((marked-bufs (or (ibuffer-get-marked-buffers)
> +                         (list (ibuffer-current-buffer t)))))
>     (unless (and (eq type 'other-frame)
> 		 (not ibuffer-expert)
> 		 (> (length marked-bufs) 3)
> 		 (not (y-or-n-p (format "Really create a new frame for %s 
> buffers? "
> 					(length marked-bufs)))))
> -      (set-buffer-modified-p nil)
> -      (delete-other-windows)
> -      (switch-to-buffer (pop marked-bufs))
> +      (unless (eq type 'other-frame)
> +        (set-buffer-modified-p nil)
> +        (delete-other-windows)
> +        (switch-to-buffer (pop marked-bufs)))
>       (let ((height (/ (1- (if (eq type 'horizontally) (frame-width)
> 			     (frame-height)))
> 		       (1+ (length marked-bufs)))))
> -- 
> 2.9.3
>
>
> Repository revision: 0041ce81897ef837d04674b634720645379f3b18
>





      reply	other threads:[~2016-09-23  6:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-27 11:32 bug#24086: 25.1.50; ibuffer-do-view-1 fails to visit in new frame Tino Calancha
2016-07-27 17:06 ` Eli Zaretskii
2016-07-28 13:52   ` Tino Calancha
2016-09-13 15:59     ` Tino Calancha
2016-09-23  6:24       ` Tino Calancha
2016-09-23  6:26         ` Tino Calancha [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1609231524510.14987@calancha-pc \
    --to=tino.calancha@gmail.com \
    --cc=24086-done@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.