all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tino Calancha <tino.calancha@gmail.com>
To: Emacs developers <emacs-devel@gnu.org>
Cc: tino.calancha@gmail.com
Subject: grep-command: Ignore case if case-fold-search is non-nil
Date: Sun, 18 Sep 2016 18:31:03 +0900 (JST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1609181830200.4109@calancha-pc> (raw)


Hi,

Do you think `grep-compute-defaults' should add '-i', i.e., ignore case,
in the default `grep-command' when `case-fold-search' is non-nil?
Option '-i' is specified by POSIX, do we need to check if `grep-program'
support it?

Regards,
Tino
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
From 5220d4858475f0825c01926456a8932079e3d0d7 Mon Sep 17 00:00:00 2001
From: Tino Calancha <tino.calancha@gmail.com>
Date: Sun, 18 Sep 2016 18:19:52 +0900
Subject: [PATCH] grep-compute-defaults: Ignore case if case-fold-search is
  non-nil

* lisp/progmodes/grep.el (grep-compute-defaults): Use option '-i'.
---
  lisp/progmodes/grep.el | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/progmodes/grep.el b/lisp/progmodes/grep.el
index f7f097b..ac871a1 100644
--- a/lisp/progmodes/grep.el
+++ b/lisp/progmodes/grep.el
@@ -590,7 +590,8 @@ grep-compute-defaults
      (unless (and grep-command grep-find-command
  		 grep-template grep-find-template)
        (let ((grep-options
-	     (concat (if grep-use-null-device "-n" "-nH")
+	     (concat (if grep-use-null-device "-n"
+                       (if case-fold-search "-nHi" "-nH"))
  		     (if (grep-probe grep-program
  				     `(nil nil nil "-e" "foo" 
,null-device)
  				     nil 1)
-- 
2.9.3

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;



             reply	other threads:[~2016-09-18  9:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-18  9:31 Tino Calancha [this message]
2016-09-18  9:57 ` grep-command: Ignore case if case-fold-search is non-nil Dmitry Gutov
2016-09-18 10:30   ` Tino Calancha
2016-09-18 10:52     ` Richard Copley
2016-09-18 11:09       ` Tino Calancha
2016-09-18 11:55         ` Dmitry Gutov
2016-09-18 14:45 ` Eli Zaretskii
2016-09-18 15:10   ` Tino Calancha
2016-09-18 16:52     ` Andreas Schwab
2016-09-18 18:03   ` Paul Eggert
2016-09-18 15:05 ` Drew Adams
2016-09-18 15:14   ` Tino Calancha
2016-09-18 15:39     ` Eli Zaretskii
2016-09-18 17:55     ` Drew Adams
2016-09-18 18:05       ` Tino Calancha
2016-09-18 18:16         ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1609181830200.4109@calancha-pc \
    --to=tino.calancha@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.