From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: Re: Ibuffer: w and B default to buffer at current line Date: Wed, 14 Sep 2016 16:21:26 +0900 (JST) Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: blaine.gmane.org 1473837868 16163 195.159.176.226 (14 Sep 2016 07:24:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 14 Sep 2016 07:24:28 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: tino.calancha@gmail.com, Emacs developers To: jwiegley@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 14 09:24:24 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bk4YK-0002uJ-5a for ged-emacs-devel@m.gmane.org; Wed, 14 Sep 2016 09:24:16 +0200 Original-Received: from localhost ([::1]:53559 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bk4YI-0005kl-BT for ged-emacs-devel@m.gmane.org; Wed, 14 Sep 2016 03:24:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47915) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bk4X1-00052h-FN for emacs-devel@gnu.org; Wed, 14 Sep 2016 03:22:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bk4Wx-0001Ku-8F for emacs-devel@gnu.org; Wed, 14 Sep 2016 03:22:54 -0400 Original-Received: from mail-pf0-f171.google.com ([209.85.192.171]:36133) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bk4Wx-0001EQ-2B for emacs-devel@gnu.org; Wed, 14 Sep 2016 03:22:51 -0400 Original-Received: by mail-pf0-f171.google.com with SMTP id 128so2858815pfb.3 for ; Wed, 14 Sep 2016 00:22:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=4cgAWYGXkBao6UsMH884Ecewj0GCGaupSAJucrpShsI=; b=qiVupJxlKptq8DFHyblh+HHjdLHSNHj79Li5yvGAsOrbQtoV+/1PI+coFJdZsq+zhD lzBVgjIHBlo/Kr1yy0fS0C9DWvK9XVAJTeuHbfk9wJRyJql15gYgFApT11bOkqs3J7Oc L+7GXmkTOvQBTmVPDjxPV4I/s6/KUfKSxKnVKXqDQ0hL1gQM1I+sRxm3jwlNoXTd1ylL zTUHpE0yOgDLL7OyGIQe3Hf2C3wHGPyWoCfLE3N1u0cCqB36BIkZe7qrA/ghOQbHikg0 /YRAE/xd/tSQniX9oHFdLFJ2FivbP/7hh3adMsFxEXgWYQDj0pXfzLdIRF8DU7krzAp0 i7CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=4cgAWYGXkBao6UsMH884Ecewj0GCGaupSAJucrpShsI=; b=Lk4aEfMZrVPZtFNfcKhE23CBifpFPJBfVymKPUepE41/ZGgpfELdqvnvVu2H9brZ81 h1Euzrew6dIgl05Yh7jpUqafIKJcPsTkSJH5PBRUSfQPy7PMFpHVUs2IRbcJjenzh5LW aqEhZwDLLSQ54U6wSLZYbaq+9rzercDYTo/VXZhOz4CiDhwOA6XbH/9nAjgugZI+xyMK xubJJ030/PDcFDP6uITWXA+NpLzECk5wz/bVTQk6FFiwSb01YbcIlpC8OMH9STCJV4Z4 nox1jkPk/T57pG0CV3Wbl7j6Ix8bbKfYRbkPDmQxcCehZE87g6ofHHGjHfLxU5Q2Nw5C M7jg== X-Gm-Message-State: AE9vXwPZqyEBBf16nKgb0a6JrOxfvGZo+jX6Ca17ymWwKOlQKplRto7yWSzpVvGHIgVEyQ== X-Received: by 10.98.32.78 with SMTP id g75mr1872666pfg.103.1473837688996; Wed, 14 Sep 2016 00:21:28 -0700 (PDT) Original-Received: from calancha-pc (57.92.100.220.dy.bbexcite.jp. [220.100.92.57]) by smtp.gmail.com with ESMTPSA id 70sm35610257pfw.92.2016.09.14.00.21.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Sep 2016 00:21:28 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.192.171 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207429 Archived-At: Thanks for your comments John! On Tue, 13 Sep 2016, John Wiegley wrote: >>>>>> "TC" == Tino Calancha writes: > > TC> * lisp/ibuffer.el (ibuffer-get-marked-buffers): > TC> Add an optional parameter BUFFER-AT-LINE: if non-nil and > TC> there are no marked buffers, return the buffer at current line. > > Hi Tino, > > I don't like this part of your proposed change. The name of the function is > `ibuffer-get-marked-buffers'. Adding a new argument to change the meaning of > the function is not a good idea. If you compare the first patch with `dired-get-marked-files' (d-g-m-f) you might change your mind: (d-g-m-f) returns a list with the file at point when there are no marked files. The first patch follow similar idea. > Instead, there should be a new function `ibuffer-get-buffer-at-point' or some > such, to reflect the meaning you wish to express. There may even already be > such a function, I'm not all that familiar with ibuffer.el. There is one, ibuffer-current-buffer. My point is that patch1 allow me to implement 'ibuffer-copy-filename-as-kill' (i-c-f-a-k) very similar as 'dired-copy-filename-as-kill' (d-c-f-a-k). That is nice to me.