From: Tino Calancha <tino.calancha@gmail.com>
To: Leo Liu <sdl.web@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 5d7433a: image-dired: Signal an error before calling a missing executable
Date: Tue, 13 Sep 2016 12:15:46 +0900 (JST) [thread overview]
Message-ID: <alpine.DEB.2.20.1609131202300.3887@calancha-pc> (raw)
In-Reply-To: <m1lgyw7ep8.fsf@zeuss-MBP.lan>
On Tue, 13 Sep 2016, Leo Liu wrote:
> On 2016-09-12 19:38 +0000, Tino Calancha wrote:
>> + (image-dired--check-executable-exists
>> + 'image-dired-cmd-create-thumbnail-program)
>
> Why not just
>
> (image-dired--check-executable-exists
> image-dired-cmd-create-thumbnail-program)
>
> and change your image-dired--check-executable-exists accordingly?
Because i don't want image-dired-cmd-create-thumbnail-program to be
evaluated: i wanted to show the symbol name of the option instead.
For example, if one user don't have installed "jpegtran", i.e.,
image-dired-cmd-rotate-original-program default value, after see
current error message s?he might prefer to change that option,
and image-dired-cmd-rotate-original-options, to run 'convert'
instead.
If most of the people here prefer to show the option value, then i will
update the check function to do that.
Tino
prev parent reply other threads:[~2016-09-13 3:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160912193810.11308.66726@vcs.savannah.gnu.org>
[not found] ` <20160912193811.119E7220166@vcs.savannah.gnu.org>
2016-09-13 1:48 ` master 5d7433a: image-dired: Signal an error before calling a missing executable Leo Liu
2016-09-13 1:56 ` Clément Pit--Claudel
2016-09-13 3:15 ` Tino Calancha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1609131202300.3887@calancha-pc \
--to=tino.calancha@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.