From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: Re: master ca47390: image-dired: Report when a necessary executable is not found Date: Tue, 13 Sep 2016 04:44:17 +0900 (JST) Message-ID: References: <20160904134431.30494.94659@vcs.savannah.gnu.org> <20160904134431.7513F220140@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-654647567-1473709460=:28880" X-Trace: blaine.gmane.org 1473709812 26431 195.159.176.226 (12 Sep 2016 19:50:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 12 Sep 2016 19:50:12 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: Emacs developers , Tino Calancha To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 12 21:50:08 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjXEx-0005x2-Gz for ged-emacs-devel@m.gmane.org; Mon, 12 Sep 2016 21:50:03 +0200 Original-Received: from localhost ([::1]:44846 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjXEv-0005Eg-AF for ged-emacs-devel@m.gmane.org; Mon, 12 Sep 2016 15:50:01 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjXAW-0001r3-EL for emacs-devel@gnu.org; Mon, 12 Sep 2016 15:45:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjXAU-0005rf-Fo for emacs-devel@gnu.org; Mon, 12 Sep 2016 15:45:27 -0400 Original-Received: from mail-pf0-f177.google.com ([209.85.192.177]:36443) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjXAP-0005qd-Jk; Mon, 12 Sep 2016 15:45:21 -0400 Original-Received: by mail-pf0-f177.google.com with SMTP id 128so55266008pfb.3; Mon, 12 Sep 2016 12:45:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=zCtae9hpew1EANNbJsdHNkdSkFp+0V8A0UFGxiUtUjI=; b=TpFlns7c4PXffWpwy7RuzYPriSH1yXbWHARWfovfQM7aJv0qj5iK4nlxNtE5vFQrXo UIT5W+yWyHpwVd8CuhojEnLjsmD2IaGclNFI0+7Vpy2fEovziPYvNsjYJirjyrBc4ivG Vgl7f6gVcdx+E+UGx2AkDbK9KmODSesxcguz7esPRQcQwicTT+1P07Dh528B5wdmCpah 1SM/ZWo/1+akiuzxmk3c4aNReKlSM/vmTSolWiuoYe/Tdt3OEaV1rE6nScW0lrMvVfEQ WoHxqXp91CmDnsWjd4Kuf+YGaeO7KPCwBvf4ZNIuxKPa/Irf0g3ajjWdOiW28wgX6iH5 Huug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=zCtae9hpew1EANNbJsdHNkdSkFp+0V8A0UFGxiUtUjI=; b=MMT/KDym7HIv7YJXt+H5sRTm5Xgcvecj+z6RUmBi692JhGEwLzy7BzJ7uhWC21qW8O c8SyKIZkBjTQGYYjQtKqKI4wy5JJwtHkaoxN8HkOmYIx+IT3XcySlNlHltOcRrFe5mnT 3U6AIZp/o51w5aMbMoRTiudJydSZ5HLrMLYusbeJ+Vu3OP3UslAoL5ey/+yTqh2QXZYM XvjkaBtc3ZQt2df50orZKm3AWdlwRwT+OY0MGyXydjMPanK7V6LZ+gTuLq89KrUutvQI O1wzWPxgiCdieiwkyBq/6KIFHr+pmIihhbEwQymw/mFBEBU0/Toa4rHdo1t88eNWZ15s +eXA== X-Gm-Message-State: AE9vXwNM330rgGAM0nxtWqSpP9cwpR2obrBoXXrmBbYMUXpSmjBaRivaVVYcSzpNK6uHGA== X-Received: by 10.98.25.66 with SMTP id 63mr36708922pfz.94.1473709460874; Mon, 12 Sep 2016 12:44:20 -0700 (PDT) Original-Received: from calancha-pc (57.92.100.220.dy.bbexcite.jp. [220.100.92.57]) by smtp.gmail.com with ESMTPSA id t21sm26329834pfa.71.2016.09.12.12.44.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Sep 2016 12:44:20 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.192.177 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207397 Archived-At: --8323329-654647567-1473709460=:28880 Content-Type: text/plain; format=flowed; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT On Mon, 12 Sep 2016, Glenn Morris wrote: > Tino Calancha wrote: > >> "Executable used to create thumbnail. >> +If nil, `image-dired-create-thumb' signals an error. > > I think you could just say: > > "Executable used to create thumbnail, or nil if not found." That part was reverted after a suggestion from Clément in: https://lists.gnu.org/archive/html/emacs-devel/2016-09/msg00144.html I kept those definitions as the original, i.e., just strings, no call to `executable-find' there. The check for existing executables is performed in a new function image-dired--check-executable-exists which is called on each function using an external program. > Otherwise, LGTM, thanks. Thank you very much. Pushed to master as commit 5d7433ab --8323329-654647567-1473709460=:28880--