Your commit 728e4008

Your commit 728e4008

[Tino Calancha]

Dear Michal,

I see you define casify_word as:
static Lisp_Object casify_word;

but that function is not returning a Lisp object.
You may return beg or end, but your current use case
of this function resembles a void one.
Shouln't be defined as
static Lisp_Object void;
instead ?

Regards,
Tino

Re: Your commit 728e4008

[Paul Eggert]

[-- Attachment #1: Type: text/plain, Size: 339 bytes --]

On 09/12/2016 05:02 AM, Tino Calancha wrote:
> that function is not returning a Lisp object

Configuring with --enable-gcc-warnings helps catch typos like that, as 
GCC complains "no return statement in function returning non-void".

I installed the attached patches. The first fixes the problem, the 
second simplifies the code further.


[-- Attachment #2: 0001-src-casefiddle.c-casify_word-Return-Qnil.patch --]
[-- Type: application/x-patch, Size: 1532 bytes --]

[-- Attachment #3: 0002-src-casefiddle.c-casify_word-Simplify.patch --]
[-- Type: application/x-patch, Size: 1198 bytes --]

Re: Your commit 728e4008

[Michal Nazarewicz]

On Mon, Sep 12 2016, Paul Eggert wrote:
> On 09/12/2016 05:02 AM, Tino Calancha wrote:
>> that function is not returning a Lisp object

Yes, sorry, it was supposed to be a void function.

> Configuring with --enable-gcc-warnings helps catch typos like that, as 
> GCC complains "no return statement in function returning non-void".

I’ll add that to my flags from now on.

> I installed the attached patches. The first fixes the problem, the 
> second simplifies the code further.

Thanks.

-- 
Best regards
ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ
«If at first you don’t succeed, give up skydiving»