From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: Re: image-rotate: Accept angle as an argument Date: Tue, 6 Sep 2016 02:28:09 +0900 (JST) Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: blaine.gmane.org 1473096633 15753 195.159.176.226 (5 Sep 2016 17:30:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 5 Sep 2016 17:30:33 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: Emacs developers , monnier@iro.umontreal.ca, Tino Calancha To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 05 19:30:30 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgxj2-0003Ql-HR for ged-emacs-devel@m.gmane.org; Mon, 05 Sep 2016 19:30:28 +0200 Original-Received: from localhost ([::1]:55990 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgxj0-0001QF-Db for ged-emacs-devel@m.gmane.org; Mon, 05 Sep 2016 13:30:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55117) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgxgv-0000Df-2W for emacs-devel@gnu.org; Mon, 05 Sep 2016 13:28:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bgxgr-0007aL-Rg for emacs-devel@gnu.org; Mon, 05 Sep 2016 13:28:16 -0400 Original-Received: from mail-pa0-x233.google.com ([2607:f8b0:400e:c03::233]:36229) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgxgr-0007aH-KM for emacs-devel@gnu.org; Mon, 05 Sep 2016 13:28:13 -0400 Original-Received: by mail-pa0-x233.google.com with SMTP id id6so4845486pad.3 for ; Mon, 05 Sep 2016 10:28:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=WIDf/Uy+i4ypZmU45/YTo4//7AHFAo1UtkPIXARhAkc=; b=NDQed/tyIYheHQPgXGRWBk3fISwk0cX3c82dU0Arnt3iuLo2izsCJKfcZT1BozVJW7 2hGHcYMQBNwzqIVmW/3E7ZW1ZFR03Gg7ymBenD8aS+Z55auSaBR/SpU8cvVmUsQpkfRC bKtR7yL4wlRYfZktpUw1wpgUE9I6IJwTFRrF/LZyWMVhJmUNXZEcHJUcZh8DMLH7H/sk TLhpxY47rsEdRtInZMsMRkNLlgnV1y0HK+9fjo5oIZ1UsOaCz5qZs8q2ZBdsv2yGNaE/ aCaM2tCnh7Wy6WFCmkj8Awb6xlsSjJze9dI2LiXHnb9BWgi2PN89oHVZ6KmjjAml/BSt WXuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=WIDf/Uy+i4ypZmU45/YTo4//7AHFAo1UtkPIXARhAkc=; b=ERWIzZVFDE4g6FZsHq+EIhCpZQt0zVNZ/7eJcaVwgCLqE/+Cm85SUXc5tBxD2WrP6E XtbPBx7jc53lBDhiLkGBRtWMJNo/3zFWdbdjcmvn91t8PSpytnEl5K4WLE/JNthNuxQp Qz8nYrEgq1m2v+0yiYEiQlzwpRAlGaGz7q51zKRzbGBY68mHuMqJ0uQx3mdUxzWxPycO LFLpalPt3gVae5UVTdnTov64O9wB6o2Tb9H9qgCGLbblRAhlX1OSNVj4dSjRRHlO1MCA t4DX+SZpxybHFpY7rUUDsK87QpttT5ctOa6/N52K5Uwo6bsIKzFt8Rtd1DNE6dTxzqZO DoHg== X-Gm-Message-State: AE9vXwO84K77jxV3pUVpmBXRc30TCcPxi+e8XFnKJq2jw/QVHizZzD93T6qXziB2/+g5iQ== X-Received: by 10.66.220.106 with SMTP id pv10mr57490727pac.81.1473096492867; Mon, 05 Sep 2016 10:28:12 -0700 (PDT) Original-Received: from calancha-pc (69.191.218.133.dy.bbexcite.jp. [133.218.191.69]) by smtp.gmail.com with ESMTPSA id bl6sm25245503pad.6.2016.09.05.10.28.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Sep 2016 10:28:12 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c03::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207202 Archived-At: On Mon, 5 Sep 2016, Lars Ingebrigtsen wrote: > Tino Calancha writes: > >> i guess the code in image-mode.el for the rotations/resizes would be >> much simple using the API from image.el. > > Well, the image-mode rotation settings do a lot more, like keeping the > width/height from exceeding the frame width/height etc, so I don't think > there's much potential for reuse there. Unless I'm misremembering what > all that stuff was about in image-mode; it's been a while since I looked > at it. I noticed a recent change in image.c broke something in image-mode. While trying to fix it i realized that the fix is much simple if image-mode use more the API in image.el that it currently does. Maybe it's a good time to look at these two files simultaneously.