all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tino Calancha <tino.calancha@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Emacs developers <emacs-devel@gnu.org>,
	monnier@iro.umontreal.ca, Tino Calancha <tino.calancha@gmail.com>
Subject: Re: image-rotate: Accept angle as an argument
Date: Tue, 6 Sep 2016 02:28:09 +0900 (JST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1609060215390.15061@calancha-pc> (raw)
In-Reply-To: <m3eg4yqofc.fsf@gnus.org>



On Mon, 5 Sep 2016, Lars Ingebrigtsen wrote:

> Tino Calancha <tino.calancha@gmail.com> writes:
>
>> i guess the code in image-mode.el for the rotations/resizes would be
>> much simple using the API from image.el.
>
> Well, the image-mode rotation settings do a lot more, like keeping the
> width/height from exceeding the frame width/height etc, so I don't think
> there's much potential for reuse there.  Unless I'm misremembering what
> all that stuff was about in image-mode; it's been a while since I looked
> at it.
I noticed a recent change in image.c broke something in image-mode.  While
trying to fix it i realized that the fix is much simple if image-mode use
more the API in image.el that it currently does.

Maybe it's a good time to look at these two files simultaneously.



      reply	other threads:[~2016-09-05 17:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-05  5:52 image-rotate: Accept angle as an argument Tino Calancha
2016-09-05  7:52 ` Tino Calancha
2016-09-05 12:36   ` Lars Ingebrigtsen
2016-09-05 14:59     ` Stefan Monnier
2016-09-05 16:30     ` Tino Calancha
2016-09-05 16:52       ` Lars Ingebrigtsen
2016-09-05 17:28         ` Tino Calancha [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1609060215390.15061@calancha-pc \
    --to=tino.calancha@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.