From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: Re: image-dired: Check all external programs available Date: Wed, 31 Aug 2016 21:07:14 +0900 (JST) Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Trace: blaine.gmane.org 1472645460 22872 195.159.176.226 (31 Aug 2016 12:11:00 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 31 Aug 2016 12:11:00 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: Emacs developers , Tino Calancha To: Mathias Dahl Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 31 14:10:55 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bf4M2-0005O6-WD for ged-emacs-devel@m.gmane.org; Wed, 31 Aug 2016 14:10:55 +0200 Original-Received: from localhost ([::1]:53952 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bf4M0-0001sh-LP for ged-emacs-devel@m.gmane.org; Wed, 31 Aug 2016 08:10:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bf4Ic-0007sL-Qk for emacs-devel@gnu.org; Wed, 31 Aug 2016 08:07:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bf4IY-0003ed-Jv for emacs-devel@gnu.org; Wed, 31 Aug 2016 08:07:21 -0400 Original-Received: from mail-pa0-x242.google.com ([2607:f8b0:400e:c03::242]:35504) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bf4IY-0003eX-CX for emacs-devel@gnu.org; Wed, 31 Aug 2016 08:07:18 -0400 Original-Received: by mail-pa0-x242.google.com with SMTP id cf3so2588111pad.2 for ; Wed, 31 Aug 2016 05:07:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=nxoP2/LabBVQh0cPTMtDUYtd17pwggTcqakcmiMYub4=; b=qtWx/+fPpsviZknJsaULmbdkmyoLA+9jXFrC9ZzHtIiW7S9lAMrtRqMI32JbPi1vXV BfEFlP9tcqcp4KWnXBfvpZCchZbuRU2l4Gv1A7xXSun0JMLhYotz/+4wRpsozbFB7aF/ CJzzG9/i8D8mALdd4qL85CeHwTku2Yn+6sni3C4mJXedbhfnZXb1FHFN5inIozb6/vKQ 3T8egygf+J/DGi7ZlL+9G2u3EvGuReifMwZOQbxu1sdCUu2Ht83OvZnT+T1AV0Wl+xHj okHFLbUfFDpbwQS6bapfioXoqe/GsLg7S5c9xGtESu1RTMiNb03dsL9eW+egJE8/9z9Y J9Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=nxoP2/LabBVQh0cPTMtDUYtd17pwggTcqakcmiMYub4=; b=Yn2LyzBt87AU2+axPJBaNgmuRA2DYZK1Nrw66Tco6SJIynyaJLbvEnT/6ceGjkLjXi U9ykcJYGL04gtySx3TOm9FWXor/OAL/jNfxwg3KclZReQDUjXwOG7nKZytwlF1VOOm8O fNXWxNfgdiQs4EXpiemNNHEsCIvmItM/H39mqmx93bjxKEknq929MlJ0U8sS1xjfQKoO cg/8DAg+h3TJbWIFzBQ8wYLzHGjlEuArOoPME/GsKuo4m8ztAN0BOWO463yw4MwBv8er gyUpTCF3R9IFT1JMs/0oMxO6084AHN/DWlWQlTSbdvsIeV4NEgo1BflQECLo5fqKnTHw mpIg== X-Gm-Message-State: AE9vXwMPoZRM0rWsw4glPL59EYTxhWPHfSR0+9MwZh9M7MO/HGwiOMgUOz3h/SVZi9pahQ== X-Received: by 10.66.50.9 with SMTP id y9mr16383407pan.88.1472645237475; Wed, 31 Aug 2016 05:07:17 -0700 (PDT) Original-Received: from calancha-pc (69.191.218.133.dy.bbexcite.jp. [133.218.191.69]) by smtp.gmail.com with ESMTPSA id fe8sm65076855pad.2.2016.08.31.05.07.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Aug 2016 05:07:16 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c03::242 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207022 Archived-At: On Tue, 30 Aug 2016, Mathias Dahl wrote: >>From my viewpoint, and after just a quick overview of the changes, I > think it looks good. If we can present more meaningful error messages >to the user, it can only be good. >I noticed you did a small change in the logic surrounding jpegtran; IIUC > you fallback to use "convert" if jpegtran is not available. As you know, 'convert' also can rotate an image. I have noticed that 'jpegtran' is not included in the Debian repositories; 'convert' is in Debian rep. and is also used to create the thumbnail and the temporary image so it should be installed to use this lib anyway. The default value for 'image-dired-cmd-rotate-original-options' is set accordingly with the executable used: jpegtran or convert. Another way could be to drop 'jpegtran' dependency and just set 'convert' as default value for the following three options; image-dired-cmd-create-thumbnail-program image-dired-cmd-create-temp-image-program image-dired-cmd-rotate-original-program > As long as you have tested both scenarios I'm fine with the change. > The same goes for the other changes of course, that they are tested and >works well. >Someone else has to apply this to the Emacs source code however, since >I'm not up-to-date >with how commits are done these days. I will keep testing during this week. Then, if everything is OK i will push the patch to the Emacs repository. >Thanks! Thank you very much! Tino