all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tino Calancha <tino.calancha@gmail.com>
To: Mathias Dahl <mathias.dahl@gmail.com>
Cc: Emacs developers <emacs-devel@gnu.org>,
	Tino Calancha <tino.calancha@gmail.com>
Subject: Re: image-dired: Check all external programs available
Date: Wed, 31 Aug 2016 21:07:14 +0900 (JST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1608312056420.16627@calancha-pc> (raw)
In-Reply-To: <CABrcCQ6Us4qQhPd2=kk3S6Fs+e++mpLb4ayVSoGcUQZBUX6sOg@mail.gmail.com>



On Tue, 30 Aug 2016, Mathias Dahl wrote:

>From my viewpoint, and after just a quick overview of the changes, I 
> think it looks good. If we can present more meaningful error messages
>to the user, it can only be good.
>I noticed you did a small change in the logic surrounding jpegtran; IIUC
> you fallback to use "convert" if jpegtran is not available.

As you know, 'convert' also can rotate an image. I have noticed that 
'jpegtran' is not included in the Debian repositories; 'convert' is 
in Debian rep. and is also used to create the thumbnail and the temporary 
image so it should be installed to use this lib anyway.
The default value for 'image-dired-cmd-rotate-original-options' is set
accordingly with the executable used: jpegtran or convert.

Another way could be to drop 'jpegtran' dependency and 
just set 'convert' as default value for the following three options;
image-dired-cmd-create-thumbnail-program
image-dired-cmd-create-temp-image-program
image-dired-cmd-rotate-original-program

> As long as you have tested both scenarios I'm fine with the change.
> The same goes for the other changes of course, that they are tested and 
>works well.
>Someone else has to apply this to the Emacs source code however, since 
>I'm not up-to-date
>with how commits are done these days.
I will keep testing during this week.  Then, if everything is OK
i will push the patch to the Emacs repository.
>Thanks!
Thank you very much!

Tino




  reply	other threads:[~2016-08-31 12:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-28 14:58 image-dired: Check all external programs available Tino Calancha
2016-08-30 12:11 ` Mathias Dahl
2016-08-31 12:07   ` Tino Calancha [this message]
2016-08-31 13:31     ` Mathias Dahl
2016-09-04 13:49       ` Tino Calancha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1608312056420.16627@calancha-pc \
    --to=tino.calancha@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=mathias.dahl@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.