From: Tino Calancha <tino.calancha@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Tino Calancha <tino.calancha@gmail.com>, 24086@debbugs.gnu.org
Subject: bug#24086: 25.1.50; ibuffer-do-view-1 fails to visit in new frame
Date: Thu, 28 Jul 2016 22:52:05 +0900 (JST) [thread overview]
Message-ID: <alpine.DEB.2.20.1607282244350.25141@calancha-pc> (raw)
In-Reply-To: <83eg6froxn.fsf@gnu.org>
On Wed, 27 Jul 2016, Eli Zaretskii wrote:
>> From: Tino Calancha <tino.calancha@gmail.com>
>> Date: Wed, 27 Jul 2016 20:32:40 +0900 (JST)
>>
>> When the argument TYPE is 'other-frame, it should visit
>> the buffer in a new frame.
>
> Not unconditionally, though. There are clearly some conditions in the
> code under which the above should not happen.
Exactly. I wrote that sentence thinking on 'ibuffer-do-view-other-frame';
i realize the bug while calling this command.
> Does the change have to be this complicated? AFAICT, the error is
> just in the wrong logic of combining the conditions. Right?
Well, maybe someone more skillful could come with
something fancier :-)
The reason why my patch looks bigger that one could
expect is because:
1) I understand better the logic written in my patch:
it reads more explicit what the logic is doing, IMO.
2) It is also fixing the expected behaviour of
'ibuffer-do-view-other-frame'.
The orig version of 'ibuffer-do-view-1', once 'unless' condition
evaluates nil, pops to the first marked buffer in the selected window
(regardless of the value of TYPE). Then, the rest of marked buffers
are visited in a new frame if TYPE equals to 'other-frame.
That's wrong: if TYPE equals 'other-frame, all marked buffers
should be visited in a new frame.
Otherwise, if you have just one marked buffer, and you call
'ibuffer-do-view-other-frame' (bound to H), Emacs visit this buffer
in the same frame.
next prev parent reply other threads:[~2016-07-28 13:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 11:32 bug#24086: 25.1.50; ibuffer-do-view-1 fails to visit in new frame Tino Calancha
2016-07-27 17:06 ` Eli Zaretskii
2016-07-28 13:52 ` Tino Calancha [this message]
2016-09-13 15:59 ` Tino Calancha
2016-09-23 6:24 ` Tino Calancha
2016-09-23 6:26 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1607282244350.25141@calancha-pc \
--to=tino.calancha@gmail.com \
--cc=24086@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.