all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tino Calancha <tino.calancha@gmail.com>
To: Glenn Morris <rgm@gnu.org>
Cc: 23954@debbugs.gnu.org, Tino Calancha <tino.calancha@gmail.com>
Subject: bug#23954: 25.1.50; Unexpected failing test
Date: Thu, 21 Jul 2016 21:42:40 +0900 (JST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1607212138300.23161@calancha-pc> (raw)
In-Reply-To: <560rz19nf.fsf@fencepost.gnu.org>



On Thu, 21 Jul 2016, Glenn Morris wrote:

>
> It's bad to have persistently failing tests, because it can mask new failures.
> (eg several xref tests started failing in
> http://hydra.nixos.org/build/37558515, but there was no notification
> email due to this pre-existing failure.)
>
> So please consider applying your change to fix this.
Thanks for the replay.
> I see it is similar to what turn-on-font-lock does, so if explicitly
> turning on font-lock in this test also fixes it, that might be better.
Yeah, for our purposes it is the same: set `char-property-alias-alist'
to '((face font-lock-face)).

I am going to apply following patch:

diff --git a/test/lisp/erc/erc-track-tests.el 
b/test/lisp/erc/erc-track-tests.el
index 24dfcfb..7cf3ef7 100644
--- a/test/lisp/erc/erc-track-tests.el
+++ b/test/lisp/erc/erc-track-tests.el
@@ -24,6 +24,7 @@

  (require 'ert)
  (require 'erc-track)
+(require 'font-core)

  (ert-deftest erc-track--shorten-aggressive-nil ()
    "Test non-aggressive erc track buffer name shortening."
@@ -107,9 +108,12 @@
  (ert-deftest erc-track--erc-faces-in ()
    "`erc-faces-in' should pick up both 'face and 'font-lock-face 
properties."
    (let ((str0 "is bold")
-        (str1 "is bold")
-        ;;(char-property-alias-alist '((face font-lock-face)))
-        )
+        (str1 "is bold"))
+    ;; Turn on Font Lock mode: this initialize 
`char-property-alias-alist'
+    ;; to '((face font-lock-face)).  Note that `font-lock-mode' don't
+    ;; turn on the mode if the test is run on batch mode or if the
+    ;; buffer name starts with ?\s (Bug#23954).
+    (unless font-lock-mode (font-lock-default-function 1))
      (put-text-property 3 (length str0) 'font-lock-face
                         '(bold erc-current-nick-face) str0)
      (put-text-property 3 (length str1) 'face






  reply	other threads:[~2016-07-21 12:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-12 15:34 bug#23954: 25.1.50; Unexpected failing test Tino Calancha
2016-07-13 17:11 ` Glenn Morris
2016-07-21 12:02   ` Glenn Morris
2016-07-21 12:42     ` Tino Calancha [this message]
2016-07-21 12:37   ` Tino Calancha
2016-07-21 12:59 ` bug#23954: (no subject) Tino Calancha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1607212138300.23161@calancha-pc \
    --to=tino.calancha@gmail.com \
    --cc=23954@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.