From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: Re: Your changes in ibuffer.el and ibuf-ext.el Date: Mon, 11 Jul 2016 11:44:43 +0900 (JST) Message-ID: References: <83vb0gihh1.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: ger.gmane.org 1468205100 11471 80.91.229.3 (11 Jul 2016 02:45:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 11 Jul 2016 02:45:00 +0000 (UTC) Cc: emacs-devel@gnu.org, Tino Calancha To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 11 04:45:00 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bMRDQ-0007tG-0C for ged-emacs-devel@m.gmane.org; Mon, 11 Jul 2016 04:45:00 +0200 Original-Received: from localhost ([::1]:57555 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMRDP-0001mo-4v for ged-emacs-devel@m.gmane.org; Sun, 10 Jul 2016 22:44:59 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39964) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMRDJ-0001mT-Ip for emacs-devel@gnu.org; Sun, 10 Jul 2016 22:44:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMRDH-0006TA-LX for emacs-devel@gnu.org; Sun, 10 Jul 2016 22:44:52 -0400 Original-Received: from mail-pf0-x234.google.com ([2607:f8b0:400e:c00::234]:35686) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMRDF-0006Sq-1X; Sun, 10 Jul 2016 22:44:49 -0400 Original-Received: by mail-pf0-x234.google.com with SMTP id c2so31008369pfa.2; Sun, 10 Jul 2016 19:44:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=p5aCHamzRqDZyOToX05V2qR7ifGSJetus5soEQbX6Kw=; b=L+Nr6SDEF2jBWCtnTho+DKuHNdTjXHnaO1LFZTsDjOuKNYjsgy7Ds1DNz2qeqRpGar LxivMJJgX3PrV22jg0a25ITLcwodrOizrC7ftUVtVELccu3JLpLKFtN9LXZmV3cUVvEh lMfYM8w5cKdZ+Djv/qMHhRgd45TIx7RL0KyvnIqWzeZBzOFl/TM9KzE3XZql4YgaslE8 pGkK/NlR8vG1fGKNqbEJBTFygEt+a+Xatv3Ikmb7mimhGnfdA63wZPm3y9EMip1m4lDV KFBTpWRwovDFnb/duqP3oWJUunMQCmyITUaQjCaIQSACsQZobrw3eulqd+T/AafIUJhM 02QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=p5aCHamzRqDZyOToX05V2qR7ifGSJetus5soEQbX6Kw=; b=eXOZLpH/OpM4Qod4qVFWeoD8WUPSfjXpO9oUZB6nW0q1N0U61bZwVWonSyl5/cj1iY m3HKOB0cBkgDCt83EaNJZbU+tq9JZm3ek3MTIjnuZUliRsmpvwHdfwHrHBPjagjeVdny k7Fv6tAiX1Vd+36wKKwcNoy5+Z3PLYaIPDCdYKv8B4cIexV7378Q+QMBOSWjwqeWV7dn 1TYvOBmYPVDoxv0u3fyumHxu5GE6C0A4uN4o+4fq3E77mwraP17T5iphsgDxwT/jZmXy D4ILTOk+8J8WrTve+pTU5FAsIAqAcOIrWx9Iib7MXdy5BFUibW9+7EkMPs+r1/WcOIiK 2qMg== X-Gm-Message-State: ALyK8tJNRcuCdNV4WoDUkPrIRTwZG+KSjzmxVkywC3vazH4R2AtRp5MdGlatk+p//OCS8g== X-Received: by 10.98.129.130 with SMTP id t124mr30792173pfd.156.1468205086778; Sun, 10 Jul 2016 19:44:46 -0700 (PDT) Original-Received: from calancha-pc ([240f:6e:c00e:1:6875:2e94:598b:96cb]) by smtp.gmail.com with ESMTPSA id 5sm800294pac.34.2016.07.10.19.44.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Jul 2016 19:44:46 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: <83vb0gihh1.fsf@gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c00::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205533 Archived-At: On Fri, 8 Jul 2016, Eli Zaretskii wrote: > Those changes seem to trigger compilation warnings: > > ELC ibuffer.elc > > In toplevel form: > ibuffer.el:1333:1:Warning: argument `_mark' not left unused > > In toplevel form: > ibuf-ext.el:1504:1:Warning: Unused lexical variable `char' > ibuf-ext.el:1504:1:Warning: variable `_buffer' not left unused > > Those sound like actual problems that need to be fixed. (Did you know > about the special meaning of the leading underscore in argument > names?) I just fixed it. That reminds me to always compile and check the *Compile-Log* after adding changes. Thank you very much.