From: Tino Calancha <tino.calancha@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org, Tino Calancha <tino.calancha@gmail.com>
Subject: Re: Your changes in ibuffer.el and ibuf-ext.el
Date: Mon, 11 Jul 2016 11:44:43 +0900 (JST) [thread overview]
Message-ID: <alpine.DEB.2.20.1607111141530.4280@calancha-pc> (raw)
In-Reply-To: <83vb0gihh1.fsf@gnu.org>
On Fri, 8 Jul 2016, Eli Zaretskii wrote:
> Those changes seem to trigger compilation warnings:
>
> ELC ibuffer.elc
>
> In toplevel form:
> ibuffer.el:1333:1:Warning: argument `_mark' not left unused
>
> In toplevel form:
> ibuf-ext.el:1504:1:Warning: Unused lexical variable `char'
> ibuf-ext.el:1504:1:Warning: variable `_buffer' not left unused
>
> Those sound like actual problems that need to be fixed. (Did you know
> about the special meaning of the leading underscore in argument
> names?)
I just fixed it.
That reminds me to always compile and check the *Compile-Log* after
adding changes.
Thank you very much.
prev parent reply other threads:[~2016-07-11 2:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 9:53 Your changes in ibuffer.el and ibuf-ext.el Eli Zaretskii
2016-07-11 2:44 ` Tino Calancha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1607111141530.4280@calancha-pc \
--to=tino.calancha@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.