From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: Re: Is it time to drop ChangeLogs? Date: Sun, 10 Jul 2016 00:19:43 +0900 (JST) Message-ID: References: <83vb50wxhv.fsf@gnu.org> <87y49vz4cg.fsf@acer.localhost.com> <87twg2g86g.fsf@lifelogs.com> <83eg76n5h5.fsf@gnu.org> <87y45eeoor.fsf@lifelogs.com> <8337nmn2pd.fsf@gnu.org> <87shvmem2c.fsf@lifelogs.com> <87oa6adz3w.fsf@lifelogs.com> <577E056B.1060705@cs.ucla.edu> <871t35egck.fsf@lifelogs.com> <577E6697.8090603@cs.ucla.edu> <87furle9tc.fsf@wanadoo.es> <8737nkdy8a.fsf@wanadoo.es> <83h9c0i4wa.fsf@gnu.org> <87lh1ccgo6.fsf@wanadoo.es> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-573032156-1468077587=:16877" X-Trace: ger.gmane.org 1468077637 19474 80.91.229.3 (9 Jul 2016 15:20:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 9 Jul 2016 15:20:37 +0000 (UTC) Cc: emacs-devel@gnu.org To: =?ISO-8859-15?Q?=D3scar_Fuentes?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 09 17:20:37 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bLu3Y-0007nc-1e for ged-emacs-devel@m.gmane.org; Sat, 09 Jul 2016 17:20:36 +0200 Original-Received: from localhost ([::1]:51496 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLu3T-0006gp-Qc for ged-emacs-devel@m.gmane.org; Sat, 09 Jul 2016 11:20:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59989) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLu2p-0006gk-56 for emacs-devel@gnu.org; Sat, 09 Jul 2016 11:19:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLu2n-0008HJ-73 for emacs-devel@gnu.org; Sat, 09 Jul 2016 11:19:50 -0400 Original-Received: from mail-pa0-x233.google.com ([2607:f8b0:400e:c03::233]:35136) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLu2m-0008HF-Vb for emacs-devel@gnu.org; Sat, 09 Jul 2016 11:19:49 -0400 Original-Received: by mail-pa0-x233.google.com with SMTP id dx3so21133937pab.2 for ; Sat, 09 Jul 2016 08:19:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=2krUkZQeEgPkcTdyye9jLSW22x+480OBSIZNrkC4R4I=; b=QpCFOM5jG/suPPVLLqyqSgciphNMdkHFDwYVux8kcOw7378dc+DCARLdBx7msJ4kCx qKi+jjC88gbKL9EcTl1SepM8iwqPPzHqw6WLTjP/KFooOrSBEetkBPAFCb/JaE6Arwuf XtWoVO6nYjoknljcwfcKZbdfoPhw6xKGR4rHvNGekwTcuBlfmFtxw+T979QWZ8Rg3hp6 s4FdCjhjmVyiltjcypfrvLQ2cWnsY/fFAIR/CorHK4HU1gBs7FDE4XTbN270U/up7A1i oB6nmyp7963yLE7ZUgKbN6CbZ4EDmWuK7+ZfYNBXl7z63eed0cPY/KglK/xWb5DG+8p9 4ASg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=2krUkZQeEgPkcTdyye9jLSW22x+480OBSIZNrkC4R4I=; b=FJiBX9ImCgnj+G5KH2NB5hjBHnAK7DspV2bwALf4Rl2E1Qi23fALIZaYI141fvSCSs b0+i/LRK7zn1D6WkU+xi5azLHDb/sbg4BMZnK5A/4LHR4SC2UBk8hZT+lqoGCJqvUBoK +K6gjf3G441LSXyBM3B6NmLDz4BvgSOl6mjRJldkRpIRGtsmP/GLj98MSFDaJE4N0maf wLs8OiPxhAnmWnhY/sypttDfeC9eBcyncl/Zack8ipYQ0U7gk0ABrrc1foQpW+SksX7k N2yF3p6OdxlXV8tgeEhXDA1JtzhsGZdYlgM0zFu4oEVOoEM7dmPdxmTGAD8vy5kze/XR oaJg== X-Gm-Message-State: ALyK8tKZ0ZwyvgVaM3vSKzNtmajT2B67bwxQOzoPsfuK00QvxRKbUi+To4ckeWzGDtUALQ== X-Received: by 10.66.248.35 with SMTP id yj3mr19481017pac.138.1468077587898; Sat, 09 Jul 2016 08:19:47 -0700 (PDT) Original-Received: from calancha-pc ([240f:6e:c00e:1:6875:2e94:598b:96cb]) by smtp.gmail.com with ESMTPSA id w3sm5001690pax.30.2016.07.09.08.19.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 09 Jul 2016 08:19:47 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: <87lh1ccgo6.fsf@wanadoo.es> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c03::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205469 Archived-At: --8323329-573032156-1468077587=:16877 Content-Type: text/plain; format=flowed; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT On Fri, 8 Jul 2016, Óscar Fuentes wrote: > Just the second commit on the log output: > > Remove just input mark > > * lisp/ibuffer.el (ibuffer-unmark-all): When MARK is not ?\r remove > just MARK. > > no hint about why it was necessary. Sorry for not being more clear in my commit, and thanks for mentioned it, so i can try do it better next time. IMO, from this commit one emacs developper should conclude: 1) Its a change in file: lisp/ibuffer.el 2) Affects a func. to unmark buffers. 3) Affects the behaviour when an input arg (MARK) satisfy one condition (not equal ?\r): it will remove (unmark) just buffers with mark being MARK. *) Fix? Enhancement? Unclear. After that, a reader interested in the commit could check the diffs: i agree that in this case the diffs are not helpful to understand the necessity of the change. Then, a really interested reader could easily put the point in the func. name between parens and do: F1-f RET (That automatically confirms 2). After my commit the function spread 29 lines: it fully matches within my laptop screen (with average screen size). The first 3 lines help to understand the thing: '(defun ibuffer-unmark-all (mark) "Unmark all buffers with mark MARK." (interactive "cRemove marks (RET means all):") ' Basically, a command unmarking buffers marked with MARK; if MARK equals ?\r then all marked buffers are unmarked. This is what is written in the commit, so the reader should conclude that this is a fix instead of an enhancement. I don't know how much average time could take this for an experience emacs developer; negligible i would say: probably Eli can do this almost while taking a nap. I got the write permissions in this project last month and i am still a newby in git. For my lack of experience my commits are far to be perfect. Sorry. I am sure they will be better and better just with the practice. Tino --8323329-573032156-1468077587=:16877--