From: Tino Calancha <f92capac@gmail.com>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: Tino Calancha <f92capac@gmail.com>, 23820@debbugs.gnu.org
Subject: bug#23820: 25.1.50; Fix caller to ediff-setup
Date: Wed, 22 Jun 2016 13:47:07 +0900 (JST) [thread overview]
Message-ID: <alpine.DEB.2.20.1606221340350.15393@calancha-pc> (raw)
In-Reply-To: <CAM-tV-9kzg-fGKdYtw3PZPNjkdO8cLU8xtVXGp8AJ6Z88T9NRg@mail.gmail.com>
> I think that argument is not a hook but just a list of functions, so
> it should suffice to do
>
> @@ -913,7 +916,7 @@ hilit-chg-get-diff-info
> (let (hilit-e hilit-x hilit-y)
> (ediff-setup buf-a file-a buf-b file-b
> nil nil ; buf-c file-C
> - 'hilit-chg-get-diff-list-hk
> + '(hilit-chg-get-diff-info-hk)
> (list (cons 'ediff-job-name 'something))
> )
> (ediff-with-current-buffer hilit-e (ediff-really-quit nil))
Yeah, i tried that first but i thought it could be useful for
documentation adding the new var.
But if
hilit-chg-get-diff-info-hk
it is a list of functions then let's go with the
'(hilit-chg-get-diff-info-hk)
solution.
emacs25 branch wasn't affected because ediff-setup calls run-hooks
(in master branch use 'mapc).
next prev parent reply other threads:[~2016-06-22 4:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 4:15 bug#23820: 25.1.50; Fix caller to ediff-setup Tino Calancha
2016-06-22 4:33 ` Noam Postavsky
2016-06-22 4:47 ` Tino Calancha [this message]
2016-06-24 15:33 ` bug#23820: (no subject) Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1606221340350.15393@calancha-pc \
--to=f92capac@gmail.com \
--cc=23820@debbugs.gnu.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.