bug#13143: 24.2; mpc.el: mpc-songs-refresh: Args out of range

["David Cadé" <codename68@gmail.com>]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 742 bytes --]

On Wed, 12 Dec 2012, David Cadé wrote:

> My take on the bug:
> I looked at the code of this function, and from what I can gather, the bug 
> seems to be in:
> (substring text 0 (- size postwidth textwidth 1))
> postwidth and textwidth are widths obtained with string-width, that is to say 
> in number of columns, and may not have any relation with the number of 
> characters present in the string text.
> This seems wrong to me. It seems to me that truncate-string-to-width seems to 
> be the function one would want to use in this case.

This patch in attachment makes things work for me.

Stefan, I don't know if you are registered to this bug number, and I 
apologize if you received multiple copies of this mail.

Greetings,

-- 
David

[-- Attachment #2: Type: TEXT/PLAIN, Size: 731 bytes --]

=== modified file 'lisp/mpc.el'
--- lisp/mpc.el	2012-08-15 16:29:11 +0000
+++ lisp/mpc.el	2012-12-12 13:53:32 +0000
@@ -1036,9 +1036,7 @@
                             (> (+ postwidth textwidth) size))
                        ;; This doesn't even obey double-width chars :-(
                        (propertize
-                        (if (zerop (- size postwidth 1))
-                            (substring text 0 1)
-                          (concat (substring text 0 (- size postwidth textwidth 1)) "…"))
+			(truncate-string-to-width text size nil nil "…")
                         'help-echo text)
                      text)))
               (when (memq tag '(Artist Album Composer)) ;FIXME: wrong list.