From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Vivek Dasmohapatra Newsgroups: gmane.emacs.bugs Subject: bug#9914: 24.0.91; htmlfontify.el: Add support for code block fontification on ODT export Date: Tue, 13 Mar 2012 03:35:35 +0000 (GMT) Message-ID: References: <87vcmaxqtu.fsf@gnu.org> <81ipiadvot.fsf@gmail.com> <87r4wy418s.fsf@gnu.org> <81d38iduo7.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Trace: dough.gmane.org 1331609799 14491 80.91.229.3 (13 Mar 2012 03:36:39 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 13 Mar 2012 03:36:39 +0000 (UTC) Cc: Chong Yidong , 9914@debbugs.gnu.org To: Jambunathan K Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 13 04:36:38 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S7IXK-0000GL-0k for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Mar 2012 04:36:34 +0100 Original-Received: from localhost ([::1]:48362 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7IXJ-0003ke-50 for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Mar 2012 23:36:33 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7IWx-0003gW-N0 for bug-gnu-emacs@gnu.org; Mon, 12 Mar 2012 23:36:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7IWv-0002Fx-5d for bug-gnu-emacs@gnu.org; Mon, 12 Mar 2012 23:36:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40939) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7IWv-0002Fr-2Y for bug-gnu-emacs@gnu.org; Mon, 12 Mar 2012 23:36:09 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1S7Izq-0005rp-EI for bug-gnu-emacs@gnu.org; Tue, 13 Mar 2012 00:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Vivek Dasmohapatra Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Mar 2012 04:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9914 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 9914-submit@debbugs.gnu.org id=B9914.133161154022526 (code B ref 9914); Tue, 13 Mar 2012 04:06:02 +0000 Original-Received: (at 9914) by debbugs.gnu.org; 13 Mar 2012 04:05:40 +0000 Original-Received: from localhost ([127.0.0.1]:47771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S7IzS-0005rD-H4 for submit@debbugs.gnu.org; Tue, 13 Mar 2012 00:05:39 -0400 Original-Received: from flounder.pepperfish.net ([89.238.129.35]:38836) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S7IzP-0005r4-E8 for 9914@debbugs.gnu.org; Tue, 13 Mar 2012 00:05:36 -0400 Original-Received: from localhost ([127.0.0.1]) by flounder.pepperfish.net with esmtps (Exim 4.71 #1 (Debian)) id 1S7IWQ-0002Sz-VH; Tue, 13 Mar 2012 03:35:39 +0000 X-X-Sender: vivek@octopus.pepperfish.net In-Reply-To: <81d38iduo7.fsf@gmail.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:57751 Archived-At: This looks reasonable to me, I have only one point to make from an initial review: The patches seem to introduce tabs into the code - I believe I only ever used spaces, and I'd prefer to keep it that way (this is a minor point: if the project wishes to change the indent style, this should be done separately to a feature patchset, just to keep the history sane). Oh... just noticed - in the fontify-string defun: (with-temp-buffer (insert string) (htmlfontify-buffer) (prog1 (buffer-string) (setq buffer-modified-p nil) (kill-buffer))))) susect this would be neater as: (with-temp-buffer (insert string) (htmlfontify-buffer) (set-buffer-modified-p nil) (buffer-string))