From: Vivek Dasmohapatra <vivek@etla.org>
To: Jambunathan K <kjambunathan@gmail.com>
Cc: Chong Yidong <cyd@gnu.org>, 9914@debbugs.gnu.org
Subject: bug#9914: 24.0.91; htmlfontify.el: Add support for code block fontification on ODT export
Date: Tue, 13 Mar 2012 03:35:35 +0000 (GMT) [thread overview]
Message-ID: <alpine.DEB.2.00.1203130319390.6736@octopus.pepperfish.net> (raw)
In-Reply-To: <81d38iduo7.fsf@gmail.com>
This looks reasonable to me, I have only one point to make from an initial
review:
The patches seem to introduce tabs into the code - I believe I only
ever used spaces, and I'd prefer to keep it that way (this is a minor
point: if the project wishes to change the indent style, this should
be done separately to a feature patchset, just to keep the history sane).
Oh... just noticed - in the fontify-string defun:
(with-temp-buffer
(insert string)
(htmlfontify-buffer)
(prog1 (buffer-string)
(setq buffer-modified-p nil)
(kill-buffer)))))
susect this would be neater as:
(with-temp-buffer
(insert string)
(htmlfontify-buffer)
(set-buffer-modified-p nil)
(buffer-string))
next prev parent reply other threads:[~2012-03-13 3:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 9:04 bug#9914: 24.0.91; htmlfontify.el: Add support for code block fontification on ODT export Jambunathan K
2011-11-07 9:20 ` Bastien
2012-01-25 10:23 ` Jambunathan K
2012-01-25 13:44 ` Stefan Monnier
2012-01-25 14:50 ` Bastien
2012-03-12 6:42 ` Chong Yidong
2012-03-12 9:18 ` Jambunathan K
2012-03-12 9:28 ` Chong Yidong
2012-03-12 9:40 ` Jambunathan K
2012-03-13 3:35 ` Vivek Dasmohapatra [this message]
2012-03-13 8:03 ` Jambunathan K
2012-03-17 5:05 ` Jambunathan K
2012-03-17 14:04 ` Chong Yidong
2012-03-12 9:40 ` Jambunathan K
2012-03-12 13:10 ` Vivek Dasmohapatra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1203130319390.6736@octopus.pepperfish.net \
--to=vivek@etla.org \
--cc=9914@debbugs.gnu.org \
--cc=cyd@gnu.org \
--cc=kjambunathan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.