bug#4048: 23.1; erc-server-reconnect-attempts does not work

bug#4048: 23.1; erc-server-reconnect-attempts does not work

[Andreas Schwab]

When getting a connection refused from the IRC server then ERC keeps
reconnecting infinitely despite erc-server-reconnect-attempts.  This is
because erc-server-reconnect calls erc-open, which wipes all local
variables including erc-server-reconnect-count, rendering the increment
in erc-process-sentinel-2 useless.

Andreas.

-- 
Andreas Schwab, schwab@redhat.com
GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84  5EC7 45C6 250E 6F00 984E
"And now for something completely different."

bug#4048: 23.1; erc-server-reconnect-attempts does not work

[Vivek Dasmohapatra]

I just tried connecting to localhost with M-x erc (no irc server 
listening there) and I didn't see this behaviour: A few followup questions:

   Is erc-server-connect-function customised?

   Was this an irc connecton which was previously established, whose
   connection was then killed, which erc subsequently kept trying to
   connect to?

   Was this a connection using tls/ssl or a regular plaintext irc connection?

I'm sure the situation you describe can arise, I may have seen something 
similar myself, but merely initiating a connection to a port where no
server is listening does not suffice to reproduce it here - If you can
think of any other details which might help to reproduce this behaviour,
I'd be interested in those too.

bug#4048: 23.1; erc-server-reconnect-attempts does not work

[Andreas Schwab]

Vivek Dasmohapatra <vivek@etla.org> writes:

> I just tried connecting to localhost with M-x erc (no irc server
> listening there)

You need to reconnect, not connect.  erc-server-reconnect-attempts is
only used on reconnects.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#4048: 23.1; erc-server-reconnect-attempts does not work

[Vivek Dasmohapatra]

> You need to reconnect, not connect.  erc-server-reconnect-attempts is

Sorry, I should have mentioned that too: Reconnecting from the "dead"
erc buffer that results from attempting to connect to localhost via
M-x erc when there is no server there does not exhibit continuous-retry
behaviour either, at least not here.

bug#4048: 23.1; erc-server-reconnect-attempts does not work

[Andreas Schwab]

Vivek Dasmohapatra <vivek@etla.org> writes:

> Sorry, I should have mentioned that too: Reconnecting from the "dead"
> erc buffer that results from attempting to connect to localhost via
> M-x erc when there is no server there does not exhibit continuous-retry
> behaviour either, at least not here.

That's not a reconnect, since you were never connected.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#4048: 23.1; erc-server-reconnect-attempts does not work

[Vivek Dasmohapatra]

On Wed, 10 Feb 2010, Andreas Schwab wrote:

> That's not a reconnect, since you were never connected.

Well, I issued a reconnect command. What I'm trying to find out is how to 
reproduce the problem.

bug#4048: 23.1; erc-server-reconnect-attempts does not work

[Andreas Schwab]

Connect to the irc server by ip, then change the routing so that
connects to the ip are denied.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#4048: 23.1; erc-server-reconnect-attempts does not work

[Andreas Schwab]

Vivek Dasmohapatra <vivek@etla.org> writes:

> Well, I issued a reconnect command.

erc-server-reconnect-attempts is only relevant for automatic reconnects.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#4048: 23.1; erc-server-reconnect-attempts does not work

[Vivek Dasmohapatra]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 537 bytes --]

Tags: patch

Does this patch make the problem go away? It seems to work here.

The problem was that erc-mode was killing all local variables, even when
the mode was already erc-mode : The patch makes it preserve the
reconnection count in that case, which seems to have the desired effect
without adversely affecting anything else.

[ Stomping on the route didn't work for me as the existing connection was
   grandfathered in by the kernel: Installing a local ircd and shutting it
   down behind the client's back worked nicely though. ]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: TEXT/x-diff; name=0001-Preserve-the-reconnection-count-when-reinitialising-.patch, Size: 572 bytes --]

diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
--- a/lisp/erc/erc.el
+++ b/lisp/erc/erc.el
@@ -1445,7 +1445,10 @@ Special commands:
 \\{erc-mode-map}
 
 Turning on `erc-mode' runs the hook `erc-mode-hook'."
-  (kill-all-local-variables)
+  (let ((recon-count erc-server-reconnect-count) (old-mode major-mode))
+    (kill-all-local-variables)
+    (if (and (eq old-mode 'erc-mode) (integerp recon-count) (< 0 recon-count)) 
+	(setq erc-server-reconnect-count recon-count)))
   (use-local-map erc-mode-map)
   (setq mode-name "ERC"
 	major-mode 'erc-mode

bug#4048: 23.1; erc-server-reconnect-attempts does not work

[Andreas Schwab]

Vivek Dasmohapatra <vivek@etla.org> writes:

> Does this patch make the problem go away?

Looks good.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#4048: 23.1; erc-server-reconnect-attempts does not work

[Glenn Morris]

Andreas Schwab wrote:

> Vivek Dasmohapatra <vivek@etla.org> writes:
>
>> Does this patch make the problem go away?
>
> Looks good.

I cannot see that this patch was ever applied.
Can someone re-work it for the current trunk please?

bug#4048: 23.1; erc-server-reconnect-attempts does not work

[Lars Ingebrigtsen]

Vivek Dasmohapatra <vivek@etla.org> writes:

> Does this patch make the problem go away? It seems to work here.
>
> The problem was that erc-mode was killing all local variables, even when
> the mode was already erc-mode : The patch makes it preserve the
> reconnection count in that case, which seems to have the desired effect
> without adversely affecting anything else.
>
> [ Stomping on the route didn't work for me as the existing connection was
>   grandfathered in by the kernel: Installing a local ircd and shutting it
>   down behind the client's back worked nicely though. ]

IThis patch no longer applies:

diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
--- a/lisp/erc/erc.el
+++ b/lisp/erc/erc.el
@@ -1445,7 +1445,10 @@ Special commands:
 \\{erc-mode-map}
 
 Turning on `erc-mode' runs the hook `erc-mode-hook'."
-  (kill-all-local-variables)
+  (let ((recon-count erc-server-reconnect-count) (old-mode major-mode))
+    (kill-all-local-variables)
+    (if (and (eq old-mode 'erc-mode) (integerp recon-count) (< 0 recon-count)) 
+	(setq erc-server-reconnect-count recon-count)))
   (use-local-map erc-mode-map)
   (setq mode-name "ERC"
 	major-mode 'erc-mode

Is this still a problem in erc in Emacs 25?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#4048: 23.1; erc-server-reconnect-attempts does not work

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Vivek Dasmohapatra <vivek@etla.org> writes:
>
>> Does this patch make the problem go away? It seems to work here.
>>
>> The problem was that erc-mode was killing all local variables, even when
>> the mode was already erc-mode : The patch makes it preserve the
>> reconnection count in that case, which seems to have the desired effect
>> without adversely affecting anything else.
>>
>> [ Stomping on the route didn't work for me as the existing connection was
>>   grandfathered in by the kernel: Installing a local ircd and shutting it
>>   down behind the client's back worked nicely though. ]
>
> IThis patch no longer applies:
>
> diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
> --- a/lisp/erc/erc.el
> +++ b/lisp/erc/erc.el
> @@ -1445,7 +1445,10 @@ Special commands:
>  \\{erc-mode-map}
>  
>  Turning on `erc-mode' runs the hook `erc-mode-hook'."
> -  (kill-all-local-variables)
> +  (let ((recon-count erc-server-reconnect-count) (old-mode major-mode))
> +    (kill-all-local-variables)
> +    (if (and (eq old-mode 'erc-mode) (integerp recon-count) (< 0 recon-count)) 
> +	(setq erc-server-reconnect-count recon-count)))
>    (use-local-map erc-mode-map)
>    (setq mode-name "ERC"
>  	major-mode 'erc-mode
>
> Is this still a problem in erc in Emacs 25?

More information was requested, but no response was given within a 
month, so I'm closing this bug report.  If the problem still exists,
please reopen this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#4048: 23.1; erc-server-reconnect-attempts does not work

[Vivek Dasmohapatra]

> Is this still a problem in erc in Emacs 25?

It appears to have been fixed in emacs 25 in the definition
of erc-open (similar fix in a different location).

Fix was included in 68cdc4bd7a780641a45b53b8fb71431e2da1a058

bug#4048: 23.1; erc-server-reconnect-attempts does not work

[Chong Yidong]

Hi Michael,

Could you take a look at this bug report?  Thanks.

Andreas Schwab <schwab@linux.m68k.org> wrote:

> When getting a connection refused from the IRC server then ERC keeps
> reconnecting infinitely despite erc-server-reconnect-attempts.  This is
> because erc-server-reconnect calls erc-open, which wipes all local
> variables including erc-server-reconnect-count, rendering the increment
> in erc-process-sentinel-2 useless.