From: Vivek Dasmohapatra <vivek@etla.org>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: 5526@debbugs.gnu.org
Subject: bug#5526: 23.1; (master) - charset.c possible unwise use of alloca(3)
Date: Sat, 6 Feb 2010 18:08:19 +0000 (GMT) [thread overview]
Message-ID: <alpine.DEB.2.00.1002061758170.1248@octopus.pepperfish.net> (raw)
In-Reply-To: <87636ao5nq.fsf@stupidchicken.com>
> Actually, after looking at this further, I think we need to use
> SAFE_ALLOCA instead of xmalloc. I've changed the code accordingly.
Whatever you think is best... I wasn't sure if SAFE_ALLOCA was the right
thing to use, since the size of the struct was so much > than MAX_ALLOCA
that the xmalloc path would always be taken.
I suspect it's unlikely to impact performance as I don't imagine emacs
spends a lot of time loading charsets over and over again.
prev parent reply other threads:[~2010-02-06 18:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 2:55 bug#5526: 23.1; (master) - charset.c possible unwise use of alloca(3) Vivek Dasmohapatra
2010-02-05 4:15 ` Chong Yidong
2010-02-05 14:05 ` Vivek Dasmohapatra
2010-02-06 13:27 ` Chong Yidong
2010-02-06 18:08 ` Vivek Dasmohapatra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1002061758170.1248@octopus.pepperfish.net \
--to=vivek@etla.org \
--cc=5526@debbugs.gnu.org \
--cc=cyd@stupidchicken.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.