From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#1744: bug-reference-mode doesn't fontify when called from mode hook Date: Thu, 08 Jan 2009 20:48:28 -0500 Message-ID: References: <877i5hfctm.fsf@jurta.org> Reply-To: Glenn Morris , 1744@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1231466626 5140 80.91.229.12 (9 Jan 2009 02:03:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 9 Jan 2009 02:03:46 +0000 (UTC) Cc: 1744@emacsbugs.donarmstrong.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 09 03:04:54 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LL6k2-0007ad-5s for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Jan 2009 03:04:54 +0100 Original-Received: from localhost ([127.0.0.1]:40271 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LL6im-0006Vf-2c for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Jan 2009 21:03:36 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LL6ih-0006Ul-V8 for bug-gnu-emacs@gnu.org; Thu, 08 Jan 2009 21:03:32 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LL6id-0006Rx-AD for bug-gnu-emacs@gnu.org; Thu, 08 Jan 2009 21:03:31 -0500 Original-Received: from [199.232.76.173] (port=44857 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LL6id-0006Ro-5T for bug-gnu-emacs@gnu.org; Thu, 08 Jan 2009 21:03:27 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:47774) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LL6ic-0003DH-Gt for bug-gnu-emacs@gnu.org; Thu, 08 Jan 2009 21:03:26 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0923O5F002313; Thu, 8 Jan 2009 18:03:24 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n091t4II032470; Thu, 8 Jan 2009 17:55:04 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Glenn Morris Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 09 Jan 2009 01:55:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 1744 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1744-submit@emacsbugs.donarmstrong.com id=B1744.123146578531132 (code B ref 1744); Fri, 09 Jan 2009 01:55:04 +0000 Original-Received: (at 1744) by emacsbugs.donarmstrong.com; 9 Jan 2009 01:49:45 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n091ng1B031126 for <1744@emacsbugs.donarmstrong.com>; Thu, 8 Jan 2009 17:49:44 -0800 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1LL6U8-0001Zg-BV; Thu, 08 Jan 2009 20:48:28 -0500 X-Spook: NORAD Israel bank cryptographic gamma Majic assassinate X-Ran: QsCS`qJ;J^}An&@hZ/:qCd45Y^Qa+!F9ke(Ze"8T[ X-Hue: blue X-Attribution: GM In-Reply-To: <877i5hfctm.fsf@jurta.org> (Juri Linkov's message of "Wed, 31 Dec 2008 01:44:21 +0200") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Thu, 08 Jan 2009 21:03:31 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:23930 Archived-At: Juri Linkov wrote: > (add-hook 'change-log-mode-hook 'bug-reference-mode) > > and a file local variable `bug-reference-url-format' > in the ChangeLog file: [...] > bug references never get fontified because `bug-reference-mode' tests > whether a variable `bug-reference-url-format' is non-nil before calling > `(jit-lock-register #'bug-reference-fontify)' in `bug-reference-mode', > and this variable is not yet set because it gets initialized later > in `hack-local-variables' called after `set-auto-mode' in `normal-mode'. This reminds me a bit of bug#347. How about something like this: *** bug-reference.el 5 Jan 2009 03:23:16 -0000 1.6 --- bug-reference.el 9 Jan 2009 01:47:30 -0000 *************** *** 114,121 **** "" nil (if bug-reference-mode (when bug-reference-url-format ! (jit-lock-register #'bug-reference-fontify)) (jit-lock-unregister #'bug-reference-fontify) (save-restriction (widen) --- 114,125 ---- "" nil (if bug-reference-mode + (progn + (let ((enable-local-variables :safe) + (enable-local-eval nil)) + (hack-local-variables)) (when bug-reference-url-format ! (jit-lock-register #'bug-reference-fontify))) (jit-lock-unregister #'bug-reference-fontify) (save-restriction (widen)