From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Tue, 26 Nov 2019 01:50:23 +0200 Message-ID: References: <87o8xwrjba.fsf@bernoul.li> <834kzooo8e.fsf@gnu.org> <877e4d7yzf.fsf@bernoul.li> <83imnvg53q.fsf@gnu.org> <87zhh2ofc9.fsf@bernoul.li> <87k186nsku.fsf@bernoul.li> <87imna18nc.fsf@mail.linkov.net> <42c596c2-b5c1-9fc9-4b92-9c13b386d93d@yandex.ru> <83pnhgrlni.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="190838"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 37774@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 26 00:51:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iZO8O-000nVH-Qu for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Nov 2019 00:51:12 +0100 Original-Received: from localhost ([::1]:49208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZO8N-0002lP-Lh for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Nov 2019 18:51:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49694) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZO8F-0002io-Lm for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 18:51:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZO8E-0006R2-KN for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 18:51:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43988) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iZO8E-0006Qu-Fp for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 18:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iZO8E-0007lg-Ew for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 18:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Nov 2019 23:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157472583529824 (code B ref 37774); Mon, 25 Nov 2019 23:51:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 25 Nov 2019 23:50:35 +0000 Original-Received: from localhost ([127.0.0.1]:49961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZO7n-0007ky-GG for submit@debbugs.gnu.org; Mon, 25 Nov 2019 18:50:35 -0500 Original-Received: from mail-wr1-f50.google.com ([209.85.221.50]:42932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZO7k-0007ki-F2 for 37774@debbugs.gnu.org; Mon, 25 Nov 2019 18:50:33 -0500 Original-Received: by mail-wr1-f50.google.com with SMTP id a15so20283827wrf.9 for <37774@debbugs.gnu.org>; Mon, 25 Nov 2019 15:50:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Dzp7SMpaXNW+VnYur6a2TF25nLhpKi4CsHRufp2yZtc=; b=XkC4oNo4YJJlpjK0MVFp50mFh9eLwWL76ZkUKS6D/QHqc6UvU84LJz1UGhE9BlOpN+ 0QMhdR2XabWL+Cpx5A2k1nNSlh1SZd+NibN8qYqqSF5QL65FQ6TCdSbsfGVM5EKBUC36 sXTSCHdvhG8WyCGp59vgtoaFJzy/EbgobZN+83BvM5kT5duFVJ/cezaz4De3dAKJtrdP dHMycpbMWnCn/34aDs9YSS3n4MlSXdCSLmL4o17EHHFMYYmw9ibZumEElsx3/pXZa51H mijkYUiwqw6Xu1IYSf0y9frnadG9DDypQYcU0SXCeFdLQQ4frH3WaUCDMbZlEI+5QWRh 3cEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Dzp7SMpaXNW+VnYur6a2TF25nLhpKi4CsHRufp2yZtc=; b=Oo5vDurjG5FsUoqhnLNi5vdbxYhiPAfmK1VSfAl/B58AsG+U72MpuaFUK7rMz0+0R4 mTtaoxd3XVPRTEBU1pbsLptRtX07Cc4TISERTIV4TZFxPcXTJLQQZay8SmhcWXqQn6// z65/xbBa/6/WD90L1pRcUaV+nwqX1m1oBD8ZH/Ael+C4hPkAhPZBQrG40pmYScR06MUz 7vbYNhMCpwwOgTz7ZG2+gvXESsiD9rFAEX5lUjOWkF3KkdnEQxsxq5HzN0DDz3p9zcBZ E8QDD0NgN4biMiu9mHuhRIPbWWiuAr5KqNVk8XNt5tNG7rfP/DmVbnqNzogFB2x9c7e3 KLUw== X-Gm-Message-State: APjAAAVddx/G7ULaJZoYGhoJUeaWjKCmqAc42t3agCtT1mOWEy/Am7vx t48SOLQJhjAjyrx2BNbYeqdxY01L X-Google-Smtp-Source: APXvYqwNK8nPZIm9eABdcYOGm7ucl3KLt1rGqeOKzzvudq1rRSWn+STrXVmAIxYvhS1dbXCaWKldyw== X-Received: by 2002:a5d:570f:: with SMTP id a15mr14603706wrv.316.1574725825866; Mon, 25 Nov 2019 15:50:25 -0800 (PST) Original-Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id o21sm954806wmc.17.2019.11.25.15.50.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Nov 2019 15:50:24 -0800 (PST) In-Reply-To: <83pnhgrlni.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172402 Archived-At: On 25.11.2019 18:00, Eli Zaretskii wrote: > Should be fixed now. Thanks. >> BTW, the diff-context needs ':extend t' as well. > > Feel free to make that change (although when did you last see a > context diff?). It's not for context diffs, it's for context around the changes in unified diffs as well. Notice the gray background on the screenshot. >> But that's of little importance since as soon as I load a custom >> theme, whatever defaults were there don't seem to matter. > > We need to modify all the themes we provide to specify :extend for > faces where we do that by default. It seems there's no way around > that, since the semantics of custom-theme-set-faces is clearly to > reset all face attributes to 'unspecified' before applying the face > spec, so keeping some attributes from the default face spec is out of > the question, unfortunately. It's clear that the faces stuff was not > designed to accommodate addition of attributes easily. Seems like it's a consequence of the implementation strategy. There were a couple of others that had been proposed (splitting the attribute in two, with different default values) or using a symbol property. You said the latter would complicate the face merging code (which makes sense) and "is extremely unclean". I have to take you at your word here. But it would relieve the theme authors of having to support this attribute explicitly.