From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#29599: 26.0; `dframe.el' binds keys unconditionally when loaded Date: Mon, 18 Dec 2017 21:21:25 -0800 (PST) Message-ID: References: <878tdzbimi.fsf@users.sourceforge.net> <161e969d-1b2b-4bcc-9e24-a932fe6a2655@default> <876093bck5.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1513660818 28526 195.159.176.226 (19 Dec 2017 05:20:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 19 Dec 2017 05:20:18 +0000 (UTC) Cc: 29599@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 19 06:20:14 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRAK4-00071k-Ps for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Dec 2017 06:20:13 +0100 Original-Received: from localhost ([::1]:49397 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRAM2-0004Ai-Tn for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Dec 2017 00:22:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59489) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRALv-00049Z-7q for bug-gnu-emacs@gnu.org; Tue, 19 Dec 2017 00:22:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRALq-0002nY-L4 for bug-gnu-emacs@gnu.org; Tue, 19 Dec 2017 00:22:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60610) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eRALq-0002lg-Co for bug-gnu-emacs@gnu.org; Tue, 19 Dec 2017 00:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eRALq-0003mF-4F for bug-gnu-emacs@gnu.org; Tue, 19 Dec 2017 00:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Dec 2017 05:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29599 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 29599-submit@debbugs.gnu.org id=B29599.151366089614488 (code B ref 29599); Tue, 19 Dec 2017 05:22:02 +0000 Original-Received: (at 29599) by debbugs.gnu.org; 19 Dec 2017 05:21:36 +0000 Original-Received: from localhost ([127.0.0.1]:41058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRALQ-0003lc-Dh for submit@debbugs.gnu.org; Tue, 19 Dec 2017 00:21:36 -0500 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:47186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRALO-0003lO-Dw for 29599@debbugs.gnu.org; Tue, 19 Dec 2017 00:21:35 -0500 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.21/8.16.0.21) with SMTP id vBJ5J482182499; Tue, 19 Dec 2017 05:21:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=KAvW1ddujGO00DhwZjvKxr/vJ8f10thQeS/0q+/jXFI=; b=a+NEFkpnmbnc/IzhsD+808lvo4JCXhhiM1G29tg6tE67m8vdiuokemlrr1qL6IexSMsV dE7/QTSNW3SQWLLyfYK7IYFKZk8lXl1m6INQWrrNkoqkWAORIuZWbmv0XSPoRL+hJh/3 MtY4WXBifDUDnRochygSekG4cH0Tc5ipxuA4cMWRTKARA/4MmOYQ5MMN4T8SUGrdRWlw FK4Lry4cXPxuC4Q2vTrEFgBHbVOF2oPaJMKfbxhhMfwplK05CeVG/Ks3xF2d0sk5HDxc IwdQmmoVU2U9v0YkDqrUVWGAbVNCwx3gyTNF5Tf5ZeStsbyrbvASGfGP3jQ1f3CvnbWh Sg== Original-Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2120.oracle.com with ESMTP id 2exvh1808h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Dec 2017 05:21:28 +0000 Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id vBJ5LRnD025940 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 19 Dec 2017 05:21:27 GMT Original-Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id vBJ5LQ8l015182; Tue, 19 Dec 2017 05:21:27 GMT In-Reply-To: <876093bck5.fsf@users.sourceforge.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4627.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8749 signatures=668649 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=873 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1712190077 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141244 Archived-At: > tags 29599 + patch > quit >=20 > Drew Adams writes: >=20 > >> Yeah (it's probably the loading-on-completion thing again). > > > > I don't think I know (or didn't know or at least don't > > recall) anything about such a thing. Is it something new? >=20 > Yes, see Bug#28607. That's quite a bug report - no report at all (?). Perhaps it was because all of the actual report was in another bug report that was closed, and that now redirects to this (vacuous) report? The only thing in #28607 is a link to an emacs-devel thread. No description of the problem (?). Anyway, it's not clear to me how that bug relates to this one. This one is about explicitly binding keys when the source code loads. I don't get the impression that that one is about this at all. (What am I missing?) > > But (without looking at them), those sound like specific > > replacements for the standard iconify etc. If so, it's > > great to provide such functions, but they shouldn't be > > bound to special events by default (i.e., upon loading). >=20 > As far as I can tell, there is no code in Emacs which sets those > functions to anything. So presumably the idea is to allow the user to > run some code when a "dframe" is made visible/iconified/deleted. No doubt. But (I think we agree?) that possibility should be offered to users, to choose, and not imposed just by loading the file. > >> Here's a patch which moves the keybinding to dframe-frame-mode > >> activation instead. > > > > I can't speak to the value of the patch (I know nothing > > about this), but thanks for working on this. >=20 > Okay, it should take care of this bug, and it should be perfectly safe, > since the functions do nothing before dframe-frame-mode is activated > anyway. I'll push to emacs-26 in a few days if there are no objections. Thanks.