all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Philip Kaludercic <philipk@posteo.net>
Cc: Damien Cassou <damien@cassou.me>, 66649@debbugs.gnu.org
Subject: bug#66649: 29.1; `project-remember-projects-under' behavior doesn't match its doc
Date: Wed, 1 Nov 2023 21:04:00 +0200	[thread overview]
Message-ID: <af172fc0-8142-0110-d2f9-be5aed3a5655@yandex.ru> (raw)
In-Reply-To: <87bkcd1utg.fsf@posteo.net>

On 01/11/2023 15:12, Philip Kaludercic wrote:
> One idea would be to just simplify the entire implementation by relying
> on directory-files and directory-files-recursively.  Say something like
> this:

Looks, good, just once thing:

> +                  (directory-files-recursively dir "" t #'file-directory-p)

The argument PREDICATE is not in Emacs 26.1 (which should remain 
compatible). But it doesn't help anyway, because that predicate is only 
used to determine whether to recurse into a subdirectory, and not to 
filter out files. So the full list of all files is generated anyway.

If the performance still looks okay to you, I have no objections. Just 
remove that last argument, and it's good to install.





  reply	other threads:[~2023-11-01 19:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-20 11:48 bug#66649: 29.1; `project-remember-projects-under' behavior doesn't match its doc Damien Cassou
2023-10-20 15:46 ` Dmitry Gutov
2023-11-01 13:12   ` Philip Kaludercic
2023-11-01 19:04     ` Dmitry Gutov [this message]
2023-11-01 21:36       ` Philip Kaludercic
2023-11-01 22:39         ` Dmitry Gutov
2023-11-02 19:58           ` Damien Cassou
2023-11-02 20:41             ` Dmitry Gutov
2023-11-03 13:00               ` Damien Cassou
2023-11-08  8:13                 ` Philip Kaludercic
2023-11-08 19:56                   ` Dmitry Gutov
2023-11-08 19:58                     ` Philip Kaludercic
2023-11-08 20:16                       ` Dmitry Gutov
2023-11-08 21:13                         ` Damien Cassou
2023-11-08 21:16                           ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af172fc0-8142-0110-d2f9-be5aed3a5655@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=66649@debbugs.gnu.org \
    --cc=damien@cassou.me \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.