From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Cl=c3=a9ment_Pit-Claudel?= Newsgroups: gmane.emacs.devel Subject: Re: face-attribute and face-remapping-alist Date: Wed, 31 Mar 2021 09:00:34 -0400 Message-ID: References: <834kgsjwdf.fsf@gnu.org> <8335wcjvzh.fsf@gnu.org> <83sg4bizbr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10900"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 31 15:02:12 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lRaU7-0002io-I2 for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Mar 2021 15:02:11 +0200 Original-Received: from localhost ([::1]:57070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRaU6-0002MU-GV for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Mar 2021 09:02:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRaSi-0001tt-4P for emacs-devel@gnu.org; Wed, 31 Mar 2021 09:00:44 -0400 Original-Received: from mail-qk1-x731.google.com ([2607:f8b0:4864:20::731]:38767) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lRaSb-0003oS-G8 for emacs-devel@gnu.org; Wed, 31 Mar 2021 09:00:43 -0400 Original-Received: by mail-qk1-x731.google.com with SMTP id c3so19178374qkc.5 for ; Wed, 31 Mar 2021 06:00:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=t7kk9zQbSpaPbABKchVWp99bmm0xF10N5R3cl/jj+zo=; b=lKOwmjsg6MzKi2dRinJkVEEu2QP2IaAA/nJHvqQFBbsy9KHHRatC/+YEMkjmtAnkC6 7I8aRSWLaYP6oZAzX2ctTtfRnIdt+j2qAgphv5M0XY6kMgoh14v2CTQGXBnvT4k17kx5 fTtSxgSgZbNymAsu0po7NjCkFF+qWMtIKzQMZRBtYYQR4UA60azshF+UpeZdGpcn0TOg SGQbYjODlEYpGWmYdj41oIoDgOq0SL6qL9HCU6CBMVeZSxQaru14hPwiXrrXE2hys6Oh L9LCeNVKwDtmfmfOma46lfjKKCFrfooFoM967MPJuaDOui7wOixdrMpq2GLHmdL17vlL OXUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=t7kk9zQbSpaPbABKchVWp99bmm0xF10N5R3cl/jj+zo=; b=SEe4msCFGG7Rhsu7wEdZIwT4w+qvKdvD43Y3P6a3otUPgs36PdmhCtrIrDifBRD3Ud n18osuPHnn55/EvlO3czCA4Y/TJaOjVfgBF6RJnvFsuPdvxwrhM9oeNeviJ/Hpgz5PHc 6RJqWCrOCQmuie4Q4An+GiUUx4YTKuRh1aU219QuXiFMqx5MEO272GP9PhKxsf+7+0K7 +NAq4fDSSaikLhCEG0X6X/ylqrWBhldg+etrKsIF3bKL5Z6ly1rJMukSUobq+h1eiZct hlfK78SnDsLBSgO8V3COxkijE9D8gUaFNPGiHdlhQMvyVckH6LRiFT9a7y4kOrlF5+yd KXwA== X-Gm-Message-State: AOAM533T5UbpKW8szGHswmcFx9QzZxQypp8srhw/u9zTq4vBeI4Xc7iQ MbnTgXVJZ9cxcKhI0iOSdFW3IX0xohk= X-Google-Smtp-Source: ABdhPJxvlFIyuWOGOzNPhWadJuO9XHnQCgRSQBbhUI8qNoAnzPDdH0klUyi8eQIpzHpZ5KY4hpm1AA== X-Received: by 2002:a05:620a:88e:: with SMTP id b14mr2875736qka.166.1617195636041; Wed, 31 Mar 2021 06:00:36 -0700 (PDT) Original-Received: from [192.168.1.11] (c-24-61-240-80.hsd1.ma.comcast.net. [24.61.240.80]) by smtp.googlemail.com with ESMTPSA id y13sm1292033qto.39.2021.03.31.06.00.35 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Mar 2021 06:00:35 -0700 (PDT) In-Reply-To: <83sg4bizbr.fsf@gnu.org> Content-Language: en-GB Received-SPF: pass client-ip=2607:f8b0:4864:20::731; envelope-from=cpitclaudel@gmail.com; helo=mail-qk1-x731.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267217 Archived-At: On 3/31/21 2:58 AM, Eli Zaretskii wrote: > Sure, but the only change needed in all the cases you described in > order to return attributes that are aware of the remapping is to look > up the face in face-remapping-alist, before calling face-attribute. You need to look it up recursively, which adds to the complexity. And it's more complicated than that if you use the "inherit" argument, since you need to check whether the default face is remapped as well, and merge that with the real default face.