From: Dmitry Gutov <dmitry@gutov.dev>
To: Damien Cassou <damien@cassou.me>, 65704@debbugs.gnu.org
Subject: bug#65704: 29.1; Most code of `project-ignores' seems to be dead code
Date: Mon, 4 Sep 2023 23:17:49 +0300 [thread overview]
Message-ID: <ae96a7c7-d419-f374-9d7b-ac1e2541b818@gutov.dev> (raw)
In-Reply-To: <8734zthf5z.fsf@cassou.me>
On 04/09/2023 23:11, Damien Cassou wrote:
> Dmitry Gutov <dgutov@yandex.ru> writes:
>> That's the reason I've added project-vc-extra-root-markers: so that
>> honoring files like .gitignore still makes sense, but the user can split
>> the project into pieces using these markers while keeping the same
>> backend in use.
>
> thank you very much for your explanation. I simplified my setup as you
> suggested.
Very good.
> That being said, `project-files' for 'vc' seems not to work for
> me. Inside my client/ folder, (project-current) returns
>
> (vc nil "…/client/")
>
> The `project-files' method has this line:
>
> (if (and (file-equal-p dir (cdr project))
Its current definition (in Emacs 29 and later) looks like this:
(if (and (file-equal-p dir (nth 2 project))
Perhaps you have an older version installed somewhere?
Though that wouldn't explain why (project-current) would return an
incompatible value.
> Because `dir' is a string and (cdr project) is the list (nil
> "…/client/), `file-equal-p' always returns nil. If I change `cdr' to be
> `caddr', things seem to work perfectly.
>
> Am I doing something wrong again or is it a bug and I should submit a
> patch?
Some investigation could help.
next prev parent reply other threads:[~2023-09-04 20:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-02 16:03 bug#65704: 29.1; Most code of `project-ignores' seems to be dead code Damien Cassou
2023-09-02 16:17 ` bug#65704: [PATCH] project.el: Fix bug in project-ignores Damien Cassou
2023-09-03 0:26 ` bug#65704: 29.1; Most code of `project-ignores' seems to be dead code Dmitry Gutov
2023-09-04 16:03 ` Damien Cassou
2023-09-04 18:30 ` Dmitry Gutov
2023-09-04 20:11 ` Damien Cassou
2023-09-04 20:17 ` Dmitry Gutov [this message]
2023-09-05 7:58 ` Damien Cassou
2023-09-05 14:09 ` Dmitry Gutov
2023-09-05 20:22 ` Damien Cassou
2023-09-06 19:12 ` Damien Cassou
2023-09-06 21:16 ` Dmitry Gutov
2023-09-04 18:31 ` Dmitry Gutov
2023-09-04 18:48 ` Eli Zaretskii
2023-09-04 18:58 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae96a7c7-d419-f374-9d7b-ac1e2541b818@gutov.dev \
--to=dmitry@gutov.dev \
--cc=65704@debbugs.gnu.org \
--cc=damien@cassou.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.