From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Paul W. Rankin" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#41198: 28.0.50; heading cycling command for outline Date: Tue, 17 Nov 2020 12:47:33 +1000 Message-ID: References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <73ee5b37b78bdc410554aebbc7a4c31b@skeletons.cc> <87a6vhvu7g.fsf@gnus.org> Reply-To: "Paul W. Rankin" Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=_e8c2e950f0899f7cbf9527053090597d" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14293"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Purely Mail via Roundcube/1.4.7 Cc: 41198@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 17 04:04:21 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kerI3-0003WS-Gh for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 17 Nov 2020 04:04:20 +0100 Original-Received: from localhost ([::1]:39232 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kerI2-0003kL-I0 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Nov 2020 22:04:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33874) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kerHm-0003k2-S8 for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2020 22:04:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46396) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kerHm-0005BF-Ic for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2020 22:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kerHm-0008Q8-F5 for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2020 22:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Paul W. Rankin" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Nov 2020 03:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41198 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41198-submit@debbugs.gnu.org id=B41198.160558224132361 (code B ref 41198); Tue, 17 Nov 2020 03:04:02 +0000 Original-Received: (at 41198) by debbugs.gnu.org; 17 Nov 2020 03:04:01 +0000 Original-Received: from localhost ([127.0.0.1]:57942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kerHi-0008Pp-Up for submit@debbugs.gnu.org; Mon, 16 Nov 2020 22:04:00 -0500 Original-Received: from sendmail.purelymail.com ([34.202.193.197]:39486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ker2D-00080O-UN for 41198@debbugs.gnu.org; Mon, 16 Nov 2020 21:48:00 -0500 DKIM-Signature: a=rsa-sha256; b=UUNrQIOTm3Dnn5AVB/EkoAkWdf2CauC731Qmsm0r26AZg2AhaE2aFVgt4Qa6oJAJ3kqd3PTvTAOPOMvvUC7Zd8hKpn/FZ26SP4Z9Pu4PSpHdimahr3kajZsMAfQoXNowQ+VpwEyH6B6sYMVuVSFK9dZ3ZlO2+Ll81QyQP3MYJqB1LiGpTicwiVeB/EQK8BuCnKimfWtudPANuKjDdX9Z7kl/XcBLmBQJ02Zwg70w1uE2svNpGyPA2sedQrMMZTHtmj8eRw8nxjGeEH32RPuBNVxE150mTCv2i76DqCqlTbGbfteJ7Qk8blEo6TZEVySZ2oBUfCLL0tGrg61+uE5rhw==; s=purelymail1; d=skeletons.cc; v=1; bh=deSgAckohWRCh39FuHH8FP0s2sjJLcg2B0xY4am8io4=; h=Received:From:To; DKIM-Signature: a=rsa-sha256; b=q29aNFNGOj69coqux/mCr0wTCo+WeVklFXCPJJUuXqs0ouzMDIVx5Q//OOL6PReuLohN3fp525v13j67DM4drFNSfKMwto3QE/qgtkj3v8R3+WIsjTtbBYnLFw0n7f6OIK4fyVgHZ1GoGz2rJxg5FNS69IEAGa7MHD+XDaVDgbgT0ecppJYtdXpAhPuTPgqpX/xrg3aIu02cOuCukhFCu+j0yGpY0ssAuLxgDUvjaovq2h2aEQfP+IIJEJDur4ZLROjCiAXiJ25xupxSvK43xSWOw4waCojId0ciMo3cg1sblHC4hsOIN+Ox8kK6onzvLiCOYBzPWjPhp/yf+pq94w==; s=purelymail1; d=purelymail.com; v=1; bh=deSgAckohWRCh39FuHH8FP0s2sjJLcg2B0xY4am8io4=; h=Feedback-ID:Received:From:To; Feedback-ID: 791:353:null:purelymail X-Pm-Original-To: 41198@debbugs.gnu.org Original-Received: by ip-172-30-0-247.ec2.internal (JAMES SMTP Server ) with ESMTPA ID 868856346; Tue, 17 Nov 2020 02:47:33 +0000 (UTC) In-Reply-To: <87a6vhvu7g.fsf@gnus.org> X-Sender: pwr@skeletons.cc X-Mailman-Approved-At: Mon, 16 Nov 2020 22:03:57 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:193513 Archived-At: --=_e8c2e950f0899f7cbf9527053090597d Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed On 2020-11-17 07:59, Lars Ingebrigtsen wrote: > > The patches look OK to me, but look like they've been slightly mangled > during transmission, so could you include them as a single patch as an > attachment? (And adding a ChangeLog-format text would also be nice.) 2x patches attached with changelog. I took a more precise approach with outline--cycle-state, where the +1 case is only handled when the subtree end is point-max, otherwise the overlay-end must equal end of subtree point in all other cases. I rewrote outline-cycle-buffer; it now first checks that the buffer has top-level headings before attempting to show only top-level headings, thus avoiding the disconcerting state where all buffer content is reduced to "...". If buffer has no outline headings, we still get an annoying message toggle from "All headings" to "Show all". Also this avoids using pcase, which is awful. --=_e8c2e950f0899f7cbf9527053090597d Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-lisp-outline.el-better-handing-of-outline-overlays-w.patch Content-Disposition: attachment; filename=0001-lisp-outline.el-better-handing-of-outline-overlays-w.patch; size=1902 RnJvbSBjNTg5ZTQwNTVhYWQ5M2FjZWVmZTBlYmIzMjgxYzAwOGM4MmEwYjQ2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiUGF1bCBXLiBSYW5raW4iIDxwd3JAc2tlbGV0b25zLmNjPgpE YXRlOiBUdWUsIDE3IE5vdiAyMDIwIDEyOjQyOjQ3ICsxMDAwClN1YmplY3Q6IFtQQVRDSCAxLzJd ICogbGlzcC9vdXRsaW5lLmVsOiBiZXR0ZXIgaGFuZGluZyBvZiBvdXRsaW5lIG92ZXJsYXlzCiB3 aGVuIGN5Y2xpbmcKCihvdXRsaW5lLS1jeWNsZS1zdGF0ZSk6IG9ubHkgY29uc2lkZXIgb3V0bGlu ZSBvdmVybGF5cyB0aGF0IGFyZSBvbgogIG91dGxpbmUgaGVhZGluZ3M7IHdoZW4gc3VidHJlZSBl bmQgaXMgcG9pbnQtbWF4LCByZXR1cm4gb3ZlcmxheS1lbmQgKzEKICBiZWNhdXNlIGZpbmFsIHN1 YnRyZWUgb3ZlcmxheSBvbmx5IHJlYWNoZXMgcG9pbnQtbWF4IC0xLgotLS0KIGxpc3Avb3V0bGlu ZS5lbCB8IDIxICsrKysrKysrKysrKystLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDEzIGluc2Vy dGlvbnMoKyksIDggZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9vdXRsaW5lLmVsIGIv bGlzcC9vdXRsaW5lLmVsCmluZGV4IDQ3ZTY1Mjg4NTkuLjhjYzhhM2NkODkgMTAwNjQ0Ci0tLSBh L2xpc3Avb3V0bGluZS5lbAorKysgYi9saXNwL291dGxpbmUuZWwKQEAgLTExMjEsMTQgKzExMjEs MTkgQEAgb3V0bGluZS0tY3ljbGUtc3RhdGUKICAgICAgIChzZXRxIGhlYWRpbmctZW5kIChwb2lu dCkpCiAgICAgICAob3V0bGluZS1lbmQtb2Ytc3VidHJlZSkKICAgICAgIChzZXRxIGVuZCAocG9p bnQpKQotICAgICAgKHNldHEgb3YtbGlzdCAoY2wtcmVtb3ZlLWlmLW5vdAotICAgICAgICAgICAg ICAgICAgICAgKGxhbWJkYSAobykgKGVxIChvdmVybGF5LWdldCBvICdpbnZpc2libGUpICdvdXRs aW5lKSkKLSAgICAgICAgICAgICAgICAgICAgIChvdmVybGF5cy1pbiBzdGFydCBlbmQpKSkKLSAg ICAgIChjb25kICgoZXEgb3YtbGlzdCBuaWwpICdzaG93LWFsbCkKLSAgICAgICAgICAgIDs7IChl cSAobGVuZ3RoIG92LWxpc3QpIDEpIHdvdWxkbuKAmXQgd29yazogd2hhdCBpZiB0aGVyZSBpcwot ICAgICAgICAgICAgOzsgb25lIGZvbGRlZCBzdWJoZWFkaW5nPwotICAgICAgICAgICAgKChhbmQg KGVxIChvdmVybGF5LWVuZCAoY2FyIG92LWxpc3QpKSBlbmQpCi0gICAgICAgICAgICAgICAgICAo ZXEgKG92ZXJsYXktc3RhcnQgKGNhciBvdi1saXN0KSkgaGVhZGluZy1lbmQpKQorICAgICAgKHNl dHEgb3YtbGlzdAorICAgICAgICAgICAgKHNlcS1maWx0ZXIKKyAgICAgICAgICAgICAobGFtYmRh IChvKQorICAgICAgICAgICAgICAgKGFuZCAoZXEgKG92ZXJsYXktZ2V0IG8gJ2ludmlzaWJsZSkg J291dGxpbmUpCisgICAgICAgICAgICAgICAgICAgIChzYXZlLWV4Y3Vyc2lvbgorICAgICAgICAg ICAgICAgICAgICAgIChnb3RvLWNoYXIgKG92ZXJsYXktc3RhcnQgbykpCisgICAgICAgICAgICAg ICAgICAgICAgKG91dGxpbmUtb24taGVhZGluZy1wIHQpKSkpCisgICAgICAgICAgICAgKG92ZXJs YXlzLWluIHN0YXJ0IGVuZCkpKQorICAgICAgKGNvbmQgKChudWxsIG92LWxpc3QpICdzaG93LWFs bCkKKyAgICAgICAgICAgICgoYW5kIChvciAoPSBlbmQgKHBvaW50LW1heCkKKyAgICAgICAgICAg ICAgICAgICAgICAgICAoMSsgKG92ZXJsYXktZW5kIChjYXIgb3YtbGlzdCkpKSkKKyAgICAgICAg ICAgICAgICAgICAgICAoPSAob3ZlcmxheS1lbmQgKGNhciBvdi1saXN0KSkgZW5kKSkKKyAgICAg ICAgICAgICAgICAgICg9IChvdmVybGF5LXN0YXJ0IChjYXIgb3YtbGlzdCkpIGhlYWRpbmctZW5k KSkKICAgICAgICAgICAgICAnaGlkZS1hbGwpCiAgICAgICAgICAgICAodCAnaGVhZGluZ3Mtb25s eSkpKSkpCiAKLS0gCjIuMjkuMgoK --=_e8c2e950f0899f7cbf9527053090597d Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0002-lisp-outline.el-avoid-hiding-all-buffer-content.patch Content-Disposition: attachment; filename=0002-lisp-outline.el-avoid-hiding-all-buffer-content.patch; size=2252 RnJvbSA2ODAyMTBjNjQ1NDUzODk1MDJlN2EyZDA1ZWMwYzk4ZTdiMjVjMjRiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiUGF1bCBXLiBSYW5raW4iIDxwd3JAc2tlbGV0b25zLmNjPgpE YXRlOiBUdWUsIDE3IE5vdiAyMDIwIDEyOjQ0OjQ0ICsxMDAwClN1YmplY3Q6IFtQQVRDSCAyLzJd ICogbGlzcC9vdXRsaW5lLmVsOiBhdm9pZCBoaWRpbmcgYWxsIGJ1ZmZlciBjb250ZW50Cgoob3V0 bGluZS1jeWNsZS1idWZmZXIpOiBjaGVjayB0aGF0IGJ1ZmZlciBoYXMgdG9wLWxldmVsIGhlYWRp bmdzCiAgYmVmb3JlIGNhbGxpbmcgb3V0bGluZS1oaWRlLXN1YmxldmVscyAxIHRodXMgcHJldmVu dGluZyBkaXNjb25jZXJ0aW5nCiAgYnVmZmVyIHN0YXRlIG9mIGNvbnRlbnQgcmVkdWNlZCB0byBz aW5nbGUgIi4uLiIKLS0tCiBsaXNwL291dGxpbmUuZWwgfCAzOCArKysrKysrKysrKysrKysrKysr KysrKystLS0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDE0 IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Avb3V0bGluZS5lbCBiL2xpc3Avb3V0bGlu ZS5lbAppbmRleCA4Y2M4YTNjZDg5Li45YjExYjg2YjlkIDEwMDY0NAotLS0gYS9saXNwL291dGxp bmUuZWwKKysrIGIvbGlzcC9vdXRsaW5lLmVsCkBAIC0xMTczLDIwICsxMTczLDMwIEBAIG91dGxp bmUtLWN5Y2xlLWJ1ZmZlci1zdGF0ZQogKGRlZnVuIG91dGxpbmUtY3ljbGUtYnVmZmVyICgpCiAg ICJDeWNsZSB0aGUgd2hvbGUgYnVmZmVyIGxpa2UgaW4gYG91dGxpbmUtY3ljbGUnLiIKICAgKGlu dGVyYWN0aXZlKQotICAocGNhc2Ugb3V0bGluZS0tY3ljbGUtYnVmZmVyLXN0YXRlCi0gICAgKCdz aG93LWFsbAotICAgICAob3V0bGluZS1oaWRlLXN1YmxldmVscyAxKQotICAgICAoc2V0cSBvdXRs aW5lLS1jeWNsZS1idWZmZXItc3RhdGUgJ3RvcC1sZXZlbCkKLSAgICAgKG1lc3NhZ2UgIlRvcCBs ZXZlbCBoZWFkaW5ncyIpKQotICAgICgndG9wLWxldmVsCi0gICAgIChvdXRsaW5lLXNob3ctYWxs KQotICAgICAob3V0bGluZS1oaWRlLXJlZ2lvbi1ib2R5IChwb2ludC1taW4pIChwb2ludC1tYXgp KQotICAgICAoc2V0cSBvdXRsaW5lLS1jeWNsZS1idWZmZXItc3RhdGUgJ2FsbC1oZWFkaW5nKQot ICAgICAobWVzc2FnZSAiQWxsIGhlYWRpbmdzIikpCi0gICAgKCdhbGwtaGVhZGluZwotICAgICAo b3V0bGluZS1zaG93LWFsbCkKLSAgICAgKHNldHEgb3V0bGluZS0tY3ljbGUtYnVmZmVyLXN0YXRl ICdzaG93LWFsbCkKLSAgICAgKG1lc3NhZ2UgIlNob3cgYWxsIikpKSkKKyAgKGxldCAoaGFzLXRv cC1sZXZlbCkKKyAgICAoc2F2ZS1leGN1cnNpb24KKyAgICAgIChnb3RvLWNoYXIgKHBvaW50LW1p bikpCisgICAgICAod2hpbGUgKG5vdCAob3IgaGFzLXRvcC1sZXZlbCAoZW9icCkpKQorICAgICAg ICAod2hlbiAob3V0bGluZS1vbi1oZWFkaW5nLXAgdCkKKyAgICAgICAgICAod2hlbiAoPSAoZnVu Y2FsbCBvdXRsaW5lLWxldmVsKSAxKQorICAgICAgICAgICAgKHNldHEgaGFzLXRvcC1sZXZlbCB0 KSkpCisgICAgICAgIChvdXRsaW5lLW5leHQtaGVhZGluZykpKQorICAgIChjb25kCisgICAgICgo YW5kIChlcSBvdXRsaW5lLS1jeWNsZS1idWZmZXItc3RhdGUgJ3Nob3ctYWxsKQorICAgICAgICAg ICBoYXMtdG9wLWxldmVsKQorICAgICAgKG91dGxpbmUtaGlkZS1zdWJsZXZlbHMgMSkKKyAgICAg IChzZXRxIG91dGxpbmUtLWN5Y2xlLWJ1ZmZlci1zdGF0ZSAndG9wLWxldmVsKQorICAgICAgKG1l c3NhZ2UgIlRvcCBsZXZlbCBoZWFkaW5ncyIpKQorICAgICAoKG9yIChlcSBvdXRsaW5lLS1jeWNs ZS1idWZmZXItc3RhdGUgJ3Nob3ctYWxsKQorICAgICAgICAgIChlcSBvdXRsaW5lLS1jeWNsZS1i dWZmZXItc3RhdGUgJ3RvcC1sZXZlbCkpCisgICAgICAob3V0bGluZS1zaG93LWFsbCkKKyAgICAg IChvdXRsaW5lLWhpZGUtcmVnaW9uLWJvZHkgKHBvaW50LW1pbikgKHBvaW50LW1heCkpCisgICAg ICAoc2V0cSBvdXRsaW5lLS1jeWNsZS1idWZmZXItc3RhdGUgJ2FsbC1oZWFkaW5nKQorICAgICAg KG1lc3NhZ2UgIkFsbCBoZWFkaW5ncyIpKQorICAgICAodAorICAgICAgKG91dGxpbmUtc2hvdy1h bGwpCisgICAgICAoc2V0cSBvdXRsaW5lLS1jeWNsZS1idWZmZXItc3RhdGUgJ3Nob3ctYWxsKQor ICAgICAgKG1lc3NhZ2UgIlNob3cgYWxsIikpKSkpCiAKIChwcm92aWRlICdvdXRsaW5lKQogKHBy b3ZpZGUgJ25vdXRsaW5lKQotLSAKMi4yOS4yCgo= --=_e8c2e950f0899f7cbf9527053090597d--