From: Ken Brown <kbrown@cornell.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 62450-done@debbugs.gnu.org
Subject: bug#62450: 29.0.60; Skip failing tests on Cygwin with native compilation
Date: Sun, 26 Mar 2023 10:15:17 -0400 [thread overview]
Message-ID: <ae6007bb-5d78-89ae-f3d7-a30faa10d4d4@cornell.edu> (raw)
In-Reply-To: <835yaoazp7.fsf@gnu.org>
On 3/26/2023 12:44 AM, Eli Zaretskii wrote:
> OK, but please add in both places comments explaining the reason, and
> in particular include there a pointer to etc/PROBLEMS.
Done.
> (I do wonder whether this is a good idea in the long run. Native
> compilation is here to stay, so avoiding its testing for Cygwin might
> not be the best solution. The PROBLEMS entry seems to imply that
> relatively simple measures, which the test suite could take, could
> avoid the fork failures, so my recommendation would be to try to find
> a better fix in the future, albeit not in Emacs 29.)
I agree, and I hope I can do it. By the way, I've been experimenting
with building the .eln files with ASLR enabled, via the following:
--- a/lisp/emacs-lisp/comp.el
+++ b/lisp/emacs-lisp/comp.el
@@ -186,8 +186,9 @@ native-comp-compiler-options
:type '(repeat string)
:version "28.1")
-(defcustom native-comp-driver-options (when (eq system-type 'darwin)
- '("-Wl,-w"))
+(defcustom native-comp-driver-options
+ (cond ((eq system-type 'darwin) '("-Wl,-w"))
+ ((eq system-type 'cygwin) '("-Wl,-dynamicbase")))
"Options passed verbatim to the native compiler's back-end driver.
Note that not all options are meaningful; typically only the options
affecting the assembler and linker are likely to be useful.
I've been building and running Emacs like this for a couple months and
not doing any rebasing, and I haven't seen a single fork failure outside
of the test suite. So this might be the way to handle the problem in
the long run. But I still hope to figure out what's different about
native compilation in the test suite.
Ken
next prev parent reply other threads:[~2023-03-26 14:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-25 20:55 bug#62450: 29.0.60; Skip failing tests on Cygwin with native compilation Ken Brown
2023-03-26 4:44 ` Eli Zaretskii
2023-03-26 14:15 ` Ken Brown [this message]
2023-03-26 14:54 ` Eli Zaretskii
2023-03-26 15:13 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae6007bb-5d78-89ae-f3d7-a30faa10d4d4@cornell.edu \
--to=kbrown@cornell.edu \
--cc=62450-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.