From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 37774@debbugs.gnu.org
Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages
Date: Wed, 23 Oct 2019 23:28:50 +0300 [thread overview]
Message-ID: <ae49bae4-f0d6-ed0d-1267-89e319a09bc5@yandex.ru> (raw)
In-Reply-To: <831rv3z6cn.fsf@gnu.org>
On 23.10.2019 21:04, Eli Zaretskii wrote:
>>> AFAIU, that's a list of faces one particular user decided to customize
>>> to have them extended. It's a far cry from the list of faces that
>>> actually need to be extended, lest some important functionality will
>>> suffer. IOW, we need some rationale for each face, so that we could
>>> consider that and decide whether or not to extend each one by default.
>>
>> Magit's maintainer will decide for each face, sure.
>
> I don't mind if package maintainers want to make that decision by
> themselves, but if that is the case, I don't think there's anything
> left to do for this bug report? I though some action will be required
> from us, that's why I asked all those questions.
We should define and document a "migration path", e.g. say what a
package author should do if they have a face which needs to be extended,
preferably without breaking compatibility with Emacs 26.
>> But I don't really see much a difference between having 2 and 20 faces
>> that will need to be updated, if it's within one package.
>
> It's a difference between a small number and a very large number.
> Theoretically, someone could argue that a change that requires to
> modify lots of faces shouldn't be so unconditional, or shouldn't be
> the default, or should have a "fire escape", or something to that
> effect. But if people don't mind changing their faces, then such
> fears have no basis, and we are good with what we have.
A "fire escape" would depend on a user's config, right? I don't like the
sound of that approach, personally.
>> Even if it's just 2, do we have a recommended way to write their
>> definitions in third-party packages in a way that's compatible with
>> Emacs 26?
>
> The best way is to inherit from some suitable parent face, I think.
A lot of face don't inherit from anything on purpose. Anyway, I've
pinged Magit's maintainer, let's see what he says.
>>> If too many faces in unbundled packages indeed need to change in that
>>> way, we should consider additional measures. That's why we need good
>>> reasons for extending each face, not just "because they were before"
>>> or because people were used to see them extended.
>>
>> Those are not the worst reasons, though.
>
> Not sure I understand in what sens did you use "the worst" here.
"People were used to ..." is basically 99% of the arguments that were
given in all past discussions for not changing defaults to be more
"modern" or whatever. And there's some merit to that.
next prev parent reply other threads:[~2019-10-23 20:28 UTC|newest]
Thread overview: 170+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 7:00 bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Andrey Orst
2019-10-16 7:53 ` Eli Zaretskii
2019-10-16 8:12 ` Andrey Orst
2019-10-16 11:05 ` Eli Zaretskii
2019-10-16 14:20 ` Stefan Kangas
2019-10-16 16:25 ` Eli Zaretskii
2019-10-16 8:59 ` Michael Heerdegen
2019-10-16 9:17 ` martin rudalics
2019-10-16 11:26 ` Eli Zaretskii
2019-10-16 11:38 ` Michael Heerdegen
2019-10-16 12:59 ` Eli Zaretskii
2019-10-16 11:10 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-10-16 11:17 ` Andrey Orst
2019-10-16 11:41 ` Eli Zaretskii
2019-10-16 12:08 ` Andrey Orst
2019-10-16 13:05 ` Eli Zaretskii
2019-10-16 11:42 ` Eli Zaretskii
2019-10-16 13:18 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-10-16 13:33 ` Andrey Orst
2019-10-16 14:21 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-10-16 17:33 ` Eli Zaretskii
2019-10-16 18:13 ` Andrey Orst
2019-10-16 18:50 ` Eli Zaretskii
2019-10-17 19:05 ` Kévin Le Gouguec
2019-10-17 20:38 ` Kévin Le Gouguec
2019-10-17 11:36 ` Michael Albinus
2019-10-17 12:38 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-10-17 13:05 ` Eli Zaretskii
2019-10-17 16:18 ` Michael Albinus
2019-10-17 16:39 ` Eli Zaretskii
2019-10-16 17:27 ` Juri Linkov
2019-10-16 18:07 ` Andrey Orst
2019-10-16 18:18 ` Juri Linkov
2019-10-16 18:54 ` Eli Zaretskii
2019-10-16 19:52 ` Juri Linkov
2019-10-16 20:06 ` Eli Zaretskii
2019-10-16 19:55 ` Eli Zaretskii
2019-10-16 20:14 ` Juri Linkov
2019-10-17 6:18 ` Eli Zaretskii
2019-10-17 8:52 ` Andrey Orst
2019-10-17 8:59 ` Eli Zaretskii
2019-10-17 9:20 ` Andrey Orst
2019-10-17 12:54 ` Eli Zaretskii
2019-10-17 13:40 ` Andrey Orst
2019-10-17 14:02 ` Eli Zaretskii
2019-10-17 14:13 ` Andrey Orst
2019-10-17 14:38 ` Eli Zaretskii
2019-10-17 14:02 ` Dmitry Gutov
2019-10-17 16:20 ` Eli Zaretskii
2019-10-17 16:46 ` Dmitry Gutov
2019-10-17 17:20 ` Eli Zaretskii
2019-10-17 8:25 ` martin rudalics
2019-10-17 14:08 ` Dmitry Gutov
2019-10-17 16:29 ` Eli Zaretskii
2019-10-17 16:50 ` Dmitry Gutov
2019-10-17 17:23 ` Eli Zaretskii
2019-10-18 14:25 ` Dmitry Gutov
2019-10-20 20:07 ` Dmitry Gutov
2019-10-21 6:10 ` Eli Zaretskii
2019-10-23 12:47 ` Dmitry Gutov
2019-10-23 15:39 ` Eli Zaretskii
2019-10-23 16:12 ` Dmitry Gutov
2019-10-23 18:04 ` Eli Zaretskii
2019-10-23 20:28 ` Dmitry Gutov [this message]
2019-10-24 14:56 ` Eli Zaretskii
2019-10-24 17:04 ` Kévin Le Gouguec
2019-10-17 22:22 ` Juri Linkov
2019-10-18 5:28 ` Andrey Orst
2019-10-18 6:53 ` Eli Zaretskii
2019-10-19 20:53 ` Juri Linkov
2019-10-20 6:03 ` Eli Zaretskii
2019-10-20 15:42 ` Juri Linkov
2019-10-20 16:59 ` Eli Zaretskii
2019-10-21 21:29 ` Juri Linkov
2019-10-18 8:25 ` martin rudalics
2019-10-18 12:41 ` Dmitry Gutov
2019-10-18 13:04 ` Andrey Orst
2019-10-17 13:56 ` Dmitry Gutov
2019-10-17 16:28 ` Eli Zaretskii
2019-10-17 13:54 ` Dmitry Gutov
2019-10-16 18:46 ` Eli Zaretskii
2019-10-16 19:46 ` Juri Linkov
2019-10-16 20:03 ` Eli Zaretskii
2019-10-16 20:23 ` Juri Linkov
2019-10-16 20:37 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-10-17 6:43 ` Eli Zaretskii
2019-10-17 6:40 ` Eli Zaretskii
2019-10-16 20:29 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-10-17 14:12 ` Dmitry Gutov
2019-10-16 20:23 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-10-16 11:33 ` Andrey Orst
2019-10-16 15:30 ` Eli Zaretskii
2019-10-31 16:06 ` Jonas Bernoulli
2019-10-31 16:48 ` Eli Zaretskii
2019-11-06 16:26 ` Jonas Bernoulli
2019-11-06 17:06 ` martin rudalics
2019-11-07 13:58 ` Eli Zaretskii
2019-11-07 15:41 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-11-07 17:10 ` martin rudalics
2019-11-07 21:57 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-11-08 9:20 ` martin rudalics
2019-11-08 10:37 ` Eli Zaretskii
2019-11-08 18:26 ` martin rudalics
2019-11-08 19:14 ` Eli Zaretskii
2019-11-08 11:39 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-11-08 18:27 ` martin rudalics
2019-12-05 16:48 ` Kévin Le Gouguec
2019-12-05 18:02 ` Eli Zaretskii
2019-12-05 19:05 ` Kévin Le Gouguec
2019-12-05 19:19 ` Eli Zaretskii
2019-12-05 18:22 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-12-05 18:47 ` Eli Zaretskii
2019-11-07 13:59 ` Eli Zaretskii
2019-11-11 10:52 ` Jonas Bernoulli
2019-11-11 19:03 ` Jonas Bernoulli
2019-11-14 11:33 ` Eli Zaretskii
2019-11-14 14:14 ` Dmitry Gutov
2019-11-14 14:41 ` Eli Zaretskii
2019-11-14 22:42 ` Dmitry Gutov
2019-11-15 8:08 ` Eli Zaretskii
2019-11-15 23:50 ` Dmitry Gutov
2019-11-16 8:09 ` Eli Zaretskii
2019-11-16 8:17 ` Dmitry Gutov
2019-11-23 23:20 ` Juri Linkov
2019-11-24 16:14 ` Eli Zaretskii
2019-11-25 23:45 ` Juanma Barranquero
2019-11-26 17:44 ` Eli Zaretskii
2019-11-25 0:29 ` Dmitry Gutov
2019-11-25 16:00 ` Eli Zaretskii
2019-11-25 23:50 ` Dmitry Gutov
2019-11-26 17:43 ` Eli Zaretskii
2019-12-02 0:05 ` Dmitry Gutov
2019-12-02 16:21 ` Eli Zaretskii
2019-12-03 0:01 ` Dmitry Gutov
2019-12-03 16:21 ` Eli Zaretskii
2019-12-05 1:44 ` Dmitry Gutov
2019-12-05 15:47 ` Eli Zaretskii
2019-12-06 15:44 ` Dmitry Gutov
2019-12-06 16:18 ` Eli Zaretskii
2019-12-06 16:58 ` Dmitry Gutov
2019-12-06 17:31 ` Eli Zaretskii
2019-12-07 1:06 ` Dmitry Gutov
2019-12-07 7:53 ` Eli Zaretskii
2019-12-07 17:06 ` Dmitry Gutov
2019-12-07 17:53 ` Eli Zaretskii
2019-12-07 18:55 ` Dmitry Gutov
2019-12-07 19:14 ` Eli Zaretskii
2019-12-08 0:42 ` Dmitry Gutov
2019-12-08 3:32 ` Eli Zaretskii
2019-12-08 10:39 ` Dmitry Gutov
2019-12-08 15:50 ` Eli Zaretskii
2019-12-08 21:20 ` Dmitry Gutov
2019-12-09 12:59 ` Eli Zaretskii
2019-12-09 14:07 ` Dmitry Gutov
2019-12-09 14:42 ` Eli Zaretskii
2019-12-09 15:24 ` Dmitry Gutov
2019-12-09 15:42 ` Eli Zaretskii
2019-12-10 0:20 ` Dmitry Gutov
2019-12-10 15:57 ` Eli Zaretskii
2019-12-11 23:02 ` Juri Linkov
2019-12-12 4:36 ` Eli Zaretskii
2019-12-12 23:44 ` Juri Linkov
2019-12-13 7:03 ` Eli Zaretskii
2019-11-27 21:30 ` Juri Linkov
2019-11-27 23:34 ` Dmitry Gutov
2019-11-28 15:19 ` Eli Zaretskii
2019-11-28 15:16 ` Eli Zaretskii
2019-11-30 11:35 ` Eli Zaretskii
2019-12-02 0:07 ` Dmitry Gutov
2019-10-31 17:29 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae49bae4-f0d6-ed0d-1267-89e319a09bc5@yandex.ru \
--to=dgutov@yandex.ru \
--cc=37774@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.