From: Drew Adams <drew.adams@oracle.com>
To: Tino Calancha <tino.calancha@gmail.com>, jwiegley@gmail.com
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: RE: Ibuffer: w and B default to buffer at current line
Date: Wed, 14 Sep 2016 07:08:56 -0700 (PDT) [thread overview]
Message-ID: <ae089e2a-90d2-434b-b4f6-e1e60cf6f017@default> (raw)
In-Reply-To: <alpine.DEB.2.20.1609141605280.10395@calancha-pc>
> > I don't like this part of your proposed change. The name of the
> > function is `ibuffer-get-marked-buffers'. Adding a new argument
> > to change the meaning of the function is not a good idea.
>
> If you compare the first patch with `dired-get-marked-files' (d-g-m-f)
> you might change your mind:
> (d-g-m-f) returns a list with the file at point when there are no
> marked files. The first patch follow similar idea.
I was going to say something similar to Tino. The same is true
of Dired commands generally - e.g., all of the `dired-do-*'
commands act on the file/dir of the current line if none are
marked: A, B, C, D, G, H, L, M, O, P, Q, R, S, T, U, X, and Z.
(And a few of them correspond to single-file commands for the
current-line's file/dir: c, d, and u. In Dired+ this is a bit
more the case: e/E, c/C, d/D, f/F, i/I, j/J, u/U, and z/Z)
I have no opinion about the proposal for Ibuffer. But it
sounds like it is applying a longstanding UI approach that
is used in Dired - one that I think is sound and useful.
> > Instead, there should be a new function `ibuffer-get-buffer-at-point'
> > or some such, to reflect the meaning you wish to express.
> > There may even already be such a function, I'm not all that
> > familiar with ibuffer.el.
>
> There is one, ibuffer-current-buffer.
> My point is that patch1 allow me to implement
> 'ibuffer-copy-filename-as-kill' (i-c-f-a-k) very similar as
> 'dired-copy-filename-as-kill' (d-c-f-a-k). That is nice to me.
Again, Dired offers separate commands that apply only to the
file/dir of the current line. They are on menus, for example.
Keys are generally not needed for them, precisely because of
the if-none-marked-then-act-on-this-one behavior.
The point of this design is to let you use the same key to act
on a single file/buffer. In addition, in Dired you can provide
a numeric prefix arg to act on the next (or previous) N files.
N defaults to 1, of course, which provides the this-line's-file
behavior.
(In Emacs there is more than one way to skin the cat...
This is a plus, not a minus.)
next prev parent reply other threads:[~2016-09-14 14:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 5:35 Ibuffer: w and B default to buffer at current line Tino Calancha
2016-09-14 6:41 ` John Wiegley
2016-09-14 7:21 ` Tino Calancha
2016-09-14 14:08 ` Drew Adams [this message]
2016-09-15 22:05 ` John Wiegley
2016-09-16 6:40 ` Eli Zaretskii
[not found] ` <<83intw5our.fsf@gnu.org>
2016-09-16 14:53 ` Drew Adams
2016-09-17 16:30 ` John Wiegley
2016-09-17 17:21 ` Eli Zaretskii
2016-09-17 21:35 ` John Wiegley
2016-09-17 23:26 ` Drew Adams
2016-09-17 23:51 ` John Wiegley
2016-09-18 1:45 ` Drew Adams
2016-09-18 2:18 ` John Wiegley
2016-09-18 14:26 ` Eli Zaretskii
2016-09-18 19:35 ` John Wiegley
[not found] ` <<83zin630i9.fsf@gnu.org>
2016-09-17 18:47 ` Drew Adams
2016-09-17 19:25 ` Eli Zaretskii
[not found] ` <<83vaxuib1p.fsf@gnu.org>
2016-09-17 19:33 ` Drew Adams
2016-09-18 14:29 ` Eli Zaretskii
[not found] ` <<d33a60f5-b8b6-4637-b3e6-ea1b09d98f85@default>
[not found] ` <<83poo1i8nf.fsf@gnu.org>
2016-09-18 17:55 ` naming functions [was: Ibuffer: w and B default to buffer at current line] Drew Adams
2016-09-18 19:23 ` John Wiegley
2016-09-18 23:24 ` Drew Adams
2016-09-19 16:35 ` Eli Zaretskii
2016-09-17 18:22 ` Ibuffer: w and B default to buffer at current line Tino Calancha
2016-09-26 12:08 ` Tino Calancha
2016-10-03 12:28 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae089e2a-90d2-434b-b4f6-e1e60cf6f017@default \
--to=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=jwiegley@gmail.com \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.