From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Francesc Rocher" Newsgroups: gmane.emacs.devel Subject: Re: New look for Emacs-23.0 Date: Wed, 16 Jul 2008 11:56:43 +0200 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1216202239 29766 80.91.229.12 (16 Jul 2008 09:57:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 16 Jul 2008 09:57:19 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Stefan Monnier" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 16 11:58:07 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KJ3lq-0004y6-IR for ged-emacs-devel@m.gmane.org; Wed, 16 Jul 2008 11:58:02 +0200 Original-Received: from localhost ([127.0.0.1]:46303 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KJ3kv-0003oa-R2 for ged-emacs-devel@m.gmane.org; Wed, 16 Jul 2008 05:57:05 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KJ3kf-0003lV-Ew for emacs-devel@gnu.org; Wed, 16 Jul 2008 05:56:49 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KJ3kd-0003i4-SD for emacs-devel@gnu.org; Wed, 16 Jul 2008 05:56:48 -0400 Original-Received: from [199.232.76.173] (port=49973 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KJ3kd-0003hH-DJ for emacs-devel@gnu.org; Wed, 16 Jul 2008 05:56:47 -0400 Original-Received: from ti-out-0910.google.com ([209.85.142.189]:54683) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KJ3kd-0004SG-96 for emacs-devel@gnu.org; Wed, 16 Jul 2008 05:56:47 -0400 Original-Received: by ti-out-0910.google.com with SMTP id u5so2633342tia.10 for ; Wed, 16 Jul 2008 02:56:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references :x-google-sender-auth; bh=QpTFYncFejCRs3Peg2MwG+dUvSfyDYY3mkAW8r1sw2w=; b=uXL2/KhFH80Cl/IjFb+PD/fluZcHsPI8MQt9HV1YrHBJH0drbwGid70zV9q8wCiXVU HYBkbr5twM776bB1NGF/d3et/XshX9YlqGWP7CsXdhRO4wRudKHEWRn3p2iGVTLPI+TP h3Jvh3vP2rS48S24z0mlOBYBUMAaA93g5SQVY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=Wsmo72/ZVZZfcYIZQKiPDnHWrm1DyhBQ5/gGo6ODAipLDqnHvmExWxGBPnDGKxN3tX DwKzGB3/F35ublhkqOmbXGDbTPO6WsDBdtsEZnYrHTQ/TSmZMv1rtiieva6eqDnkdV1F 4ji7fsiRKzCnCZU0UcTNhR6uP579dHN9QisiE= Original-Received: by 10.142.142.16 with SMTP id p16mr5049112wfd.277.1216202203407; Wed, 16 Jul 2008 02:56:43 -0700 (PDT) Original-Received: by 10.142.226.6 with HTTP; Wed, 16 Jul 2008 02:56:43 -0700 (PDT) In-Reply-To: Content-Disposition: inline X-Google-Sender-Auth: 437b5675ac21c368 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:100793 Archived-At: > Indeed, I also saw that the 2 images are low-color versions, so the test > didn't make much sense, but the situation now is very different because > the new files use up many colors, so the display-depth should be used to > guard the use of those new high-color images. You're right, so my proposal is to use the following patch and to delete the file 'splash8.xpm' from the repository. -----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<----- --- startup.el.~1.495~ 2008-07-16 10:17:39.000000000 +0200 +++ startup.el 2008-07-16 10:53:20.000000000 +0200 @@ -1443,13 +1443,15 @@ fancy-splash-image) ((display-color-p) - (cond ((image-type-available-p 'svg) + (cond ((<= (display-planes) 8) + (if (image-type-available-p 'xpm) + "splash.xpm" + "splash.pbm")) + ((image-type-available-p 'svg) "splash.svg") ((image-type-available-p 'png) "splash.png") ((image-type-available-p 'xpm) - (if (and (fboundp 'x-display-planes) - (= (funcall 'x-display-planes) 8)) - "splash8.xpm" - "splash.xpm")))) + "splash.xpm") + (t "splash.pbm"))) (t "splash.pbm"))) (img (create-image image-file)) -----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<----- -- Francesc Rocher