all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Francesc Rocher" <rocher@member.fsf.org>
To: "Stefan Monnier" <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: New look for Emacs-23.0
Date: Wed, 16 Jul 2008 11:56:43 +0200	[thread overview]
Message-ID: <ade856a30807160256y330ed79cx2b4cb9e03941da7a@mail.gmail.com> (raw)
In-Reply-To: <jwvfxqluq23.fsf-monnier+emacs@gnu.org>

> Indeed, I also saw that the 2 images are low-color versions, so the test
> didn't make much sense, but the situation now is very different because
> the new files use up many colors, so the display-depth should be used to
> guard the use of those new high-color images.

You're right, so my proposal is to use the following patch and to delete the
file 'splash8.xpm' from the repository.

-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----
--- startup.el.~1.495~  2008-07-16 10:17:39.000000000 +0200
+++ startup.el  2008-07-16 10:53:20.000000000 +0200
@@ -1443,13 +1443,15 @@
                            fancy-splash-image)
                           ((display-color-p)
-                           (cond ((image-type-available-p 'svg)
+                           (cond ((<= (display-planes) 8)
+                                  (if (image-type-available-p 'xpm)
+                                      "splash.xpm"
+                                    "splash.pbm"))
+                                 ((image-type-available-p 'svg)
                                   "splash.svg")
                                  ((image-type-available-p 'png)
                                   "splash.png")
                                  ((image-type-available-p 'xpm)
-                                  (if (and (fboundp 'x-display-planes)
-                                           (= (funcall 'x-display-planes) 8))
-                                      "splash8.xpm"
-                                    "splash.xpm"))))
+                                  "splash.xpm")
+                                 (t "splash.pbm")))
                           (t "splash.pbm")))
         (img (create-image image-file))
-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----

-- Francesc Rocher




  reply	other threads:[~2008-07-16  9:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-28 15:46 New look for Emacs-23.0 Francesc Rocher
2008-06-30 10:12 ` Juanma Barranquero
2008-06-30 10:22   ` Werner LEMBERG
2008-06-30 10:24     ` Miles Bader
2008-07-01 22:30 ` Leo
2008-07-01 23:35 ` Chong Yidong
2008-07-03 19:39 ` Dmitry Dzhus
2008-07-03 21:55 ` Stefan Monnier
2008-07-07 21:28   ` Francesc Rocher
2008-07-08  1:24     ` Stefan Monnier
2008-07-16  9:56       ` Francesc Rocher [this message]
2008-07-16 16:22         ` Stefan Monnier
2008-07-18 14:25           ` Juanma Barranquero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ade856a30807160256y330ed79cx2b4cb9e03941da7a@mail.gmail.com \
    --to=rocher@member.fsf.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.