Re: Terrible underline

["Francesc Rocher" <francesc.rocher@gmail.com>]

> "Lennart Borgman (gmail)" <address@hidden> writes:
>> David Kastrup wrote:
>>>    "Lennart Borgman (gmail)" <address@hidden> writes:
>>>
>>>        I get terrible underlines with CVS Emacs 23, see the attached
>>>        picture. I guess this has something to do with the new font handling,
>>>        or?
>>
>>    They look fine to me.  Have you looked at the screenshot?  Maybe it
>>    captures the way things should look rather than how they actually do?
>>
> Thanks, yes I looked at the screen shot. There is no space
> between the characters and the underline. To me that is nearly
> unreadable.
>
> It looked much better before the merge I think.

Yes, you're right. It's time to get support for the variable
'x-underline-at-descent-line' under win32. Before the merge it
was not necessary, but now this patch should be installed:

---8<------8<------8<------8<------8<------8<------8<------8<---
--- w32term.c   3 Mar 2008 06:32:12 -0000       1.284
+++ w32term.c   8 Mar 2008 18:50:46 -0000
@@ -2950,11 +2950,13 @@
 #ifdef USE_FONT_BACKEND
          if (enable_font_backend)
            {
-             if (s->face->font)
-               /* In the future, we must use information of font.  */
-               y = s->ybase + (s->face->font->max_bounds.descent + 1) / 2;
-             else
-               y = s->y + s->height - h;
+             y = s->y + s->height - h;
+             if (!x_underline_at_descent_line)
+               {
+                 if (s->face->font)
+                   /* In the future, we must use information of font.  */
+                   y = s->ybase + (s->face->font->max_bounds.descent + 1) / 2;
+               }
            }
          else
 #endif
---8<------8<------8<------8<------8<------8<------8<------8<---

Then,

   (setq x-underline-at-descent-line t)

should make the underlining readable (it should look as before).

Please note that I have no write access to CVS so, if approved, the patch
should be updated by some maintainer.

-- 
Francesc Rocher