From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cCvXKJ0R52B6tgAAgWs5BA (envelope-from ) for ; Thu, 08 Jul 2021 16:54:21 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id QCaJJJ0R52AZGAAAbx9fmQ (envelope-from ) for ; Thu, 08 Jul 2021 14:54:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E8AC6C4F5 for ; Thu, 8 Jul 2021 16:54:20 +0200 (CEST) Received: from localhost ([::1]:38098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1VPv-0003Lr-Ul for larch@yhetil.org; Thu, 08 Jul 2021 10:54:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1VPY-0003LP-OX for emacs-orgmode@gnu.org; Thu, 08 Jul 2021 10:53:56 -0400 Received: from mail-4323.protonmail.ch ([185.70.43.23]:18614) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1VPW-000096-3s for emacs-orgmode@gnu.org; Thu, 08 Jul 2021 10:53:56 -0400 Date: Thu, 08 Jul 2021 14:53:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1625756024; bh=oDnV38mmMe41rPfOwcu747HBUk0aqtQ05Q/RPUDsOwc=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=d4YhXbjfNSnZv1UFlMEY/5QQ19fJaNWpvRcJO+i2wRWfK4bxgO3i8EKjZG/Oh/tIW zH07Sufmf2S/Ya8A52n6qKTSH/fWyWT8UA9ZTev41mnMqdus4+6CtACqtitQs1oEp6 8hu5PrjTgbNWhgKBRmocp/YLNYNAHo8lmkfKKNMg= To: sebastien.miquel@posteo.eu From: Jacopo De Simoi Cc: Org-mode Org-Mode Subject: Re: [PATCH] Do not throw error when parameter of :tangle is not a string Message-ID: In-Reply-To: <7a8dc44c-9b27-0ac9-8a88-3faf4d8f60b8@posteo.eu> References: <7267271.EvYhyI6sBW@bl4ckspoons> <7a8dc44c-9b27-0ac9-8a88-3faf4d8f60b8@posteo.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.43.23; envelope-from=wilderjds@protonmail.com; helo=mail-4323.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Jacopo De Simoi Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625756061; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=oDnV38mmMe41rPfOwcu747HBUk0aqtQ05Q/RPUDsOwc=; b=C0Ken2anzoTxduZaXqe8Ai3AuRWcPDMsHkMZDKDdvhtPJRc5sdKQMIpqnd//MY5mkZm254 oxvazWayjHwhBK3HwmVvpkRIJCDN97bD7bxiThoRsHwSXhYLVApzPfcC0RG0FNOv32Jj4R Db4CUI5gpq+RnaeHs7nsF+2ssD3OPrm9Xy58DVTpUB/1d6RtBb7dSWXl1mbhQGambYSiFP 2JM+vZVjK1V3QQegZPBh5ZlF+oGggXNFv5S+/4hDMai2rIEGRzXNktbpNNbVQt3D8c0hCC UAcJqOUTjTjET1yq7Omlqs8Hx/pqU/1hcWjXPuBDBwvGE3/a3SygRP4Jq2uAlA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625756061; a=rsa-sha256; cv=none; b=FoS8CdOM/7FEExAKcsWhNaYARqGdR7glMQS9dgHCqQdHoDJPJ+tpBUXtvGGqtnHmT38Q+6 v5D/eUUzlY5aqwHcDLIj0CwF2D/goTjv6sBoVqZzrQ4L8l4DwP+akDv24iyRWHv3a4NYO/ toCKsSCPpBWr+XZHCzrw69I3hH04oU7mR4BmMuvklg+oEWvuEvXudk8o8si7LbKvU3Mq04 3Mmk9CYoVT2AHXsMRt/m4zTldm31fcwW2KW0EKLDDI1YU93iAKlMzxYn8c01beOTlgIW2G NPHOjTtOdJ03sdy9dNuavWUaq6LgXmgSX3oVwHwayVoh94dYGe+B9dvbxnei7Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=protonmail.com header.s=protonmail header.b=d4YhXbjf; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.11 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=protonmail.com header.s=protonmail header.b=d4YhXbjf; dmarc=pass (policy=quarantine) header.from=protonmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: E8AC6C4F5 X-Spam-Score: -3.11 X-Migadu-Scanner: scn0.migadu.com X-TUID: VKq6sJ84vPlt Hi S=C3=A9bastien, =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Thursday, July 8th, 2021 at 4:44 AM, S=C3=A9bastien Miquel wrote: > Hi, > > Jacopo De Simoi writes: > > > in the current master branch, if the parameter :tangle of a src block i= s not > > > > a string, tangling fails by throwing an error when calling `file-name- = directory' This patch checks if the parameter is a string before calling` f= ile-name-directory'. > > > > This makes construct such as :tangle (when condition-applies "filename"= ) work > > > > again (as they did a few versions ago=E2=80=A6) > > Thanks for the patch. It looks good to me (had to run `dos2unix' to apply= ). Dos2unix? I'll make sure it doesn't happen again. It might have to do with = having sent the patch from Android. >To clarify, it fixes` :tangle (when condition-applies "filename")' when th= e > > condition doesn't apply, such as `(when nil "filename")'. Yes, I will update the commit message and resubmit. Thanks! > > Regards, > > -------------------------------------------------------------------------= ---------------------------------------------------------------------------= ------------------------------------------------------------------------- > > S=C3=A9bastien Miquel