all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#23344: 25.0.93; (vc-call-backend 'Git 'mode-line-string default-directory)
@ 2016-04-23 14:32 Leo Liu
  2016-04-23 19:22 ` Dmitry Gutov
  0 siblings, 1 reply; 5+ messages in thread
From: Leo Liu @ 2016-04-23 14:32 UTC (permalink / raw)
  To: 23344


1. Open a directory under git in dired and eval
2. (progn (vc-file-clearprops default-directory)
          (vc-call-backend 'Git 'mode-line-string default-directory))
3. observe the odd string: "Git-04030c40afcef0b9b41fd79ad094c4a7d2c2cc27master"

Leo





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#23344: 25.0.93; (vc-call-backend 'Git 'mode-line-string default-directory)
  2016-04-23 14:32 bug#23344: 25.0.93; (vc-call-backend 'Git 'mode-line-string default-directory) Leo Liu
@ 2016-04-23 19:22 ` Dmitry Gutov
  2016-04-24  1:22   ` Leo Liu
  0 siblings, 1 reply; 5+ messages in thread
From: Dmitry Gutov @ 2016-04-23 19:22 UTC (permalink / raw)
  To: Leo Liu, 23344-done

Hi Leo,

On 04/23/2016 05:32 PM, Leo Liu wrote:

> 1. Open a directory under git in dired and eval
> 2. (progn (vc-file-clearprops default-directory)
>           (vc-call-backend 'Git 'mode-line-string default-directory))
> 3. observe the odd string: "Git-04030c40afcef0b9b41fd79ad094c4a7d2c2cc27master"

Thanks for the report. I've fixed it in 87ee542.

Is there a particular place where you're calling `mode-line-string' on a 
directory, though?

The return value in this case is poorly defined, because the string 
includes a character indicator of the current VC state of FILE, and the 
VC API doesn't define VC states for directories.





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#23344: 25.0.93; (vc-call-backend 'Git 'mode-line-string default-directory)
  2016-04-23 19:22 ` Dmitry Gutov
@ 2016-04-24  1:22   ` Leo Liu
  2016-04-24  9:52     ` Dmitry Gutov
  0 siblings, 1 reply; 5+ messages in thread
From: Leo Liu @ 2016-04-24  1:22 UTC (permalink / raw)
  To: 23344

On 2016-04-23 22:22 +0300, Dmitry Gutov wrote:
> Is there a particular place where you're calling `mode-line-string' on
> a directory, though?

I use vc-mode-line on a directory. But it was broken after upgrading to
25.0.93 and the form in the subject is the culprit.

Thanks,
Leo






^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#23344: 25.0.93; (vc-call-backend 'Git 'mode-line-string default-directory)
  2016-04-24  1:22   ` Leo Liu
@ 2016-04-24  9:52     ` Dmitry Gutov
  2016-04-24 10:01       ` Leo Liu
  0 siblings, 1 reply; 5+ messages in thread
From: Dmitry Gutov @ 2016-04-24  9:52 UTC (permalink / raw)
  To: Leo Liu, 23344

On 04/24/2016 04:22 AM, Leo Liu wrote:

> I use vc-mode-line on a directory.

But where?





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#23344: 25.0.93; (vc-call-backend 'Git 'mode-line-string default-directory)
  2016-04-24  9:52     ` Dmitry Gutov
@ 2016-04-24 10:01       ` Leo Liu
  0 siblings, 0 replies; 5+ messages in thread
From: Leo Liu @ 2016-04-24 10:01 UTC (permalink / raw)
  To: 23344

On 2016-04-24 12:52 +0300, Dmitry Gutov wrote:
> But where?

For example, in eshell-mode-hook in my init.

Leo






^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-04-24 10:01 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-23 14:32 bug#23344: 25.0.93; (vc-call-backend 'Git 'mode-line-string default-directory) Leo Liu
2016-04-23 19:22 ` Dmitry Gutov
2016-04-24  1:22   ` Leo Liu
2016-04-24  9:52     ` Dmitry Gutov
2016-04-24 10:01       ` Leo Liu

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.